https://bugzilla.redhat.com/show_bug.cgi?id=1750159
Bug ID: 1750159 Summary: Review Request: ibm-plex-fonts - IBM's Plex fonts Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: suraia@ikkoku.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ikkoku.de/~suraia/ibm-plex/ibm-plex-fonts.spec SRPM URL: https://ikkoku.de/~suraia/ibm-plex/ibm-plex-fonts-2.0.0-1.fc30.src.rpm Description: Plex is an open-source project (OFL) and free to download and use. The Plex family comes in a Sans, Serif, Mono and Sans Condensed, all with roman and true italics. The fonts have been designed to work well in user interface (UI) environments as well as other mediums. Fedora Account System Username: suraia
https://bugzilla.redhat.com/show_bug.cgi?id=1750159
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Add Version-Release info to your %changelog entry:
* Sun Sep 08 2019 Michael Kuhn suraia@fedoraproject.org - 2.0.0-1
Package approved., please fix the aforementioned issue before import.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "SIL Open Font License (v1.1)". Detailed output of licensecheck in /home/bob/packaging/review/ibm-plex-fonts/review-ibm-plex- fonts/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/IBM/plex/releases/download/v2.0.0/OpenType.zip##/ibm- plex-fonts-2.0.0.zip See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: ibm-plex-fonts-common-2.0.0-1.fc32.noarch.rpm ibm-plex-fonts-2.0.0-1.fc32.src.rpm ibm-plex-fonts-common.noarch: W: no-version-in-last-changelog ibm-plex-fonts-common.noarch: W: no-documentation ibm-plex-fonts.src: W: no-version-in-last-changelog 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1750159
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ibm-plex-fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1750159
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-a77a997301 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a77a997301
https://bugzilla.redhat.com/show_bug.cgi?id=1750159
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-1851ce5a1c has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1851ce5a1c
https://bugzilla.redhat.com/show_bug.cgi?id=1750159
--- Comment #5 from Michael Kuhn suraia@ikkoku.de --- Thanks for the review! The package has been built and updates have been submitted.
https://bugzilla.redhat.com/show_bug.cgi?id=1750159
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- ibm-plex-fonts-2.0.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1851ce5a1c
https://bugzilla.redhat.com/show_bug.cgi?id=1750159
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- ibm-plex-fonts-2.0.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a77a997301
https://bugzilla.redhat.com/show_bug.cgi?id=1750159
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-10-02 00:47:12
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- ibm-plex-fonts-2.0.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1750159
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- ibm-plex-fonts-2.0.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1750159
--- Comment #10 from Nicolas Mailhot nicolas.mailhot@laposte.net --- Hi,
Thanks for looking at Plex!
Note that Condensed is a style face and should not be split in a separate package as per current Fedora packaging guidelines. That will be made cleared in the guidelines updates FPC is reviewing now.
A guidelines-compliant Plex packageset is available here https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/
and can be used as update as soon as FPC finishes reviewing the new guidelines
(this package actually antedates the one approved here — getting the packaging and guidelines and fontconfig rules right took quite a long time)
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com