https://bugzilla.redhat.com/show_bug.cgi?id=2250408
Bug ID: 2250408 Summary: Review Request: golang-maunium-mautrix - A Golang Matrix framework Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: V02460@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://v02460.fedorapeople.org/golang-maunium-mautrix.spec SRPM URL: https://v02460.fedorapeople.org/golang-maunium-mautrix-0.16.2-1.fc40.src.rpm Description: A Golang Matrix framework Fedora Account System Username: v02460
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
Kai A. Hiller V02460@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2250315, 2249894, 2249890, | |2249878, 2249896 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2249878 [Bug 2249878] Review Request: golang-mau-util - Various Go utilities used by mautrix-go and bridges https://bugzilla.redhat.com/show_bug.cgi?id=2249890 [Bug 2249890] Review Request: golang-maunium-mauflag - An extendable argument parser for Golang https://bugzilla.redhat.com/show_bug.cgi?id=2249894 [Bug 2249894] Review Request: golang-maunium-maulogger-2 - A logger for Go programs https://bugzilla.redhat.com/show_bug.cgi?id=2249896 [Bug 2249896] Review Request: golang-mau-zeroconfig - A relatively simple declarative config format for zerolog https://bugzilla.redhat.com/show_bug.cgi?id=2250315 [Bug 2250315] Review Request: golang-github-matrix-org-gomatrixserverlib - Go library for matrix federation
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6666938 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
--- Comment #2 from Kai A. Hiller V02460@gmail.com --- Spec URL: https://v02460.fedorapeople.org/golang-maunium-mautrix.spec SRPM URL: https://v02460.fedorapeople.org/golang-maunium-mautrix-0.16.2-2.fc40.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6677359 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2250408 Bug 2250408 depends on bug 2249878, which changed state.
Bug 2249878 Summary: Review Request: golang-mau-util - Various Go utilities used by mautrix-go and bridges https://bugzilla.redhat.com/show_bug.cgi?id=2249878
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2250408 Bug 2250408 depends on bug 2249890, which changed state.
Bug 2249890 Summary: Review Request: golang-maunium-mauflag - An extendable argument parser for Golang https://bugzilla.redhat.com/show_bug.cgi?id=2249890
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2250408 Bug 2250408 depends on bug 2249896, which changed state.
Bug 2249896 Summary: Review Request: golang-mau-zeroconfig - A relatively simple declarative config format for zerolog https://bugzilla.redhat.com/show_bug.cgi?id=2249896
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2250408 Bug 2250408 depends on bug 2250315, which changed state.
Bug 2250315 Summary: Review Request: golang-github-matrix-org-gomatrixserverlib - Go library for matrix federation https://bugzilla.redhat.com/show_bug.cgi?id=2250315
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
Kai A. Hiller V02460@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|2249894 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2249894 [Bug 2249894] Review Request: golang-maunium-maulogger2 - A logger for Go programs
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
--- Comment #4 from Kai A. Hiller V02460@gmail.com --- Spec URL: https://v02460.fedorapeople.org/golang-maunium-mautrix.spec SRPM URL: https://v02460.fedorapeople.org/golang-maunium-mautrix-0.18.1-1.fc41.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@olasagasti.info Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mikel@olasagasti.info Flags| |fedora-review?
--- Comment #5 from Mikel Olasagasti Uranga mikel@olasagasti.info ---
Patch1: 0001-Unvendor-crypto-canonicaljson.patch
Why do you prefer to patch the package to remove the bundled library? I'm not sure how this benefits the package.
BuildRequires: gcc-c++ BuildRequires: libolm-devel
Where are these required? I can't see in the code or in the spec where they're used.
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
--- Comment #6 from Kai A. Hiller V02460@gmail.com ---
BuildRequires: gcc-c++ BuildRequires: libolm-devel
Where are these required? I can't see in the code or in the spec where they're used.
It’s here: https://github.com/mautrix/go/blob/2810465ef29466b531d3424bd4175fa8f0af4c26/...
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Golang Package Review ==============
This package was generated using go2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-maunium-mautrix
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-90318b414d (golang-maunium-mautrix-0.18.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-90318b414d
https://bugzilla.redhat.com/show_bug.cgi?id=2250408
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-05-06 19:02:51
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-90318b414d (golang-maunium-mautrix-0.18.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org