[Bug 1844225] New: Review Request: python-sphinx-pyreverse - A simple sphinx extension to generate UML diagrams with pyreverse
https://bugzilla.redhat.com/show_bug.cgi?id=1844225
Bug ID: 1844225 Summary: Review Request: python-sphinx-pyreverse - A simple sphinx extension to generate UML diagrams with pyreverse Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: sumukher@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/sumantro93/python-sphinx-pyreverse/blob/master/python-sph... SRPM URL: https://github.com/sumantro93/python-sphinx-pyreverse/blob/master/python-sph... Description: A simple sphinx extension to generate UML diagrams with pyreverse Fedora Account System Username: sumantrom Koji Scratch Build : https://koji.fedoraproject.org/koji/taskinfo?taskID=45421515
I am not yet in the packager group and I am looking forward to a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=1844225
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1844225
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1844225
--- Comment #1 from Parag AN(पराग) panemade@gmail.com --- The fedora-review tool does not work if you do not give direct downloadable files. Hence, your package links should be
SPEC URL: https://raw.githubusercontent.com/sumantro93/python-sphinx-pyreverse/master/... SRPM URL: https://github.com/sumantro93/python-sphinx-pyreverse/raw/master/python-sphi...
https://bugzilla.redhat.com/show_bug.cgi?id=1844225
--- Comment #2 from sumantro sumukher@redhat.com --- (In reply to Parag AN(पराग) from comment #1)
The fedora-review tool does not work if you do not give direct downloadable files. Hence, your package links should be
SPEC URL: https://raw.githubusercontent.com/sumantro93/python-sphinx-pyreverse/master/ python-sphinx-pyreverse.spec SRPM URL: https://github.com/sumantro93/python-sphinx-pyreverse/raw/master/python- sphinx-pyreverse-0.0.13-1.fc32.src.rpm
Noted. Do I have to change anything in this bug? I will keep this in mind for the next time.
https://bugzilla.redhat.com/show_bug.cgi?id=1844225
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@fabian-affolter.ch
--- Comment #3 from Fabian Affolter mail@fabian-affolter.ch --- Could you please remove the reStructuredText formatting from the descriptions?
https://bugzilla.redhat.com/show_bug.cgi?id=1844225
--- Comment #4 from sumantro sumukher@redhat.com --- (In reply to Fabian Affolter from comment #3)
Could you please remove the reStructuredText formatting from the descriptions?
I updated the SPEC file.
https://bugzilla.redhat.com/show_bug.cgi?id=1844225
--- Comment #5 from Parag AN(पराग) panemade@gmail.com --- sorry for late comment. I was supposed to post this review last weekend.
Issues to be fixed:
1) The descriptions in SPEC is in "reStructuredText" format, make it normal text format. The other noticeable thing is that the description text start with package name. We don't write description like that. Drop the package name and keep rest of the text.
2) Like many other pypi packages, this package also did not add tests and license file in tarball. In this case we can think to use github released tarball but upstream has not tagged/released recent tarballs on github.
Better add license file as separate source as given below in SPEC file.
Source1: https://raw.githubusercontent.com/alendit/sphinx-pyreverse/master/LICENSE
then at the end of %prep section add cp -p %{SOURCE1} .
then in %files section add line for this license file as %license LICENSE
3) Running test in %check also have problem because pypi tarball contains only 1 upstream file from tests directory. This is just note here no action needed for this issue.
4) As per https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs guidelines, you need to add your email address in changelog. Everytime you make a change in SPEC file, bump the release tag, add a new changelog entry describing what got changed from last release and submit new URLS for further package review.
https://bugzilla.redhat.com/show_bug.cgi?id=1844225
--- Comment #6 from Parag AN(पराग) panemade@gmail.com --- Forgot this one
5) As per https://github.com/alendit/sphinx-pyreverse/blob/master/setup.py#L34 , change the package license from "GPLv3" to "GPLv3+".
https://bugzilla.redhat.com/show_bug.cgi?id=1844225
--- Comment #7 from Parag AN(पराग) panemade@gmail.com --- any update here?
https://bugzilla.redhat.com/show_bug.cgi?id=1844225
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|panemade@gmail.com |nobody@fedoraproject.org Flags|fedora-review? |
Product: Fedora Version: rawhide Component: Package Review
Package Review package-review@lists.fedoraproject.org has canceled Package Review package-review@lists.fedoraproject.org's request for sumantro sumukher@redhat.com's needinfo: Bug 1844225: Review Request: python-sphinx-pyreverse - A simple sphinx extension to generate UML diagrams with pyreverse https://bugzilla.redhat.com/show_bug.cgi?id=1844225
--- Comment #9 from Package Review package-review@lists.fedoraproject.org --- This is an automatic action taken by review-stats script.
The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com