Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
Summary: Review Request: geda-symbols - Electronic symbols for gEDA Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cgoorah@yahoo.com.au QAContact: fedora-package-review@redhat.com
Spec URL: http://chitlesh.googlepages.com/geda-symbols.spec SRPM URL: http://chitlesh.googlepages.com/geda-symbols-20060123-3.src.rpm Description: This package contains a bunch of symbols of electronic devices used by gschem, the gEDA project schematic editor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
cgoorah@yahoo.com.au changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wk@ire.pw.edu.pl
------- Additional Comments From cgoorah@yahoo.com.au 2006-08-27 18:11 EST ------- *** Bug 177109 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-08-29 08:37 EST ------- Created an attachment (id=135122) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=135122&action=vie...) file lists of geda-symbols
First review.
1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Timestamps - Well, it seems this package has many text files. So preserving timestamps is very desirable. Try to change "make install" option so that (perhaps) most files can keep timestamps. In xscreensaver case (I maintain xscreensaver), I use
make INSTALL="install -p" install
Check if this package accepts such options, or, if not, change Makefile so that install command is used with -p option.
* File and Directory Ownership
- %{_datadir}/gEDA/scheme %{gedadocdir}/man
I don't know why these empty directories needs to be included in this package.
Usually if other packages install some files in these directories, it is the package which should own these directories, not this package. However, * if you aim to sumbit other packages and * the packages install some files in that directories and * the packages surely requires this package, these directories can be owned by this package.
Let me know your opinion about these directories.
2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : okay.
3. Other things I have noticed :
- Consider if /usr/share/gEDA/docs can be moved to usual document files' location, i.e. /usr/share/doc/geda-symbols-%{version}
- I will attach the file entry of geda-symbols rebuilt in mock. Please check if all files you want to install in this package are correctly packaged.
--------------------- BTW, could you review my package (bug 204461) ? Again, this package is aimed for Japanese users......
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #135122|application/octet-stream |text/plain mime type| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
------- Additional Comments From cgoorah@yahoo.com.au 2006-08-29 10:51 EST ------- (In reply to comment #2)
Try to change "make install" option so that (perhaps) most files can keep timestamps. In xscreensaver case (I maintain xscreensaver), I use make INSTALL="install -p" install Check if this package accepts such options, or, if not,
It accepts "-p" ::) make INSTALL="install -p" install DESTDIR=%{buildroot}
- File and Directory Ownership
%{_datadir}/gEDA/scheme %{gedadocdir}/man
I don't know why these empty directories needs to be included in this package.
- Other things I have noticed :
- Consider if /usr/share/gEDA/docs can be moved to usual document files' location, i.e. /usr/share/doc/geda-symbols-%{version}
Actually geda-gsymbols are required by geda-gschem geda-gsymcheck geda-doc geda-gattrib geda-gnetlist geda-utils. And all these are required by geda which is a suite. (though i haven't YET included them as Requires in the geda package)
Hence these act as a centralised repository for geda.
- I will attach the file entry of geda-symbols rebuilt in mock. Please check if all files you want to install in this package are correctly packaged.
Yes, everything is included :) luckily
Updated: SPEC: http://chitlesh.googlepages.com/geda-symbols.spec SRPM: http://chitlesh.googlepages.com/geda-symbols-20060123-4.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-08-29 11:11 EST ------- (In reply to comment #3)
Actually geda-gsymbols are required by geda-gschem geda-gsymcheck geda-doc geda-gattrib geda-gnetlist geda-utils. And all these are required by geda which is a suite. (though i haven't YET included them as Requires in the geda package)
Hence these act as a centralised repository for geda.
Okay.
Now this package is APPROVED by me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-08-29 21:15 EST ------- Closing as it seems that geda-symbols is released under FE-5, FE6-devel.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Keywords| |Reopened Resolution|NEXTRELEASE | OtherBugsDependingO| |204598, 204605 nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-08-31 09:20 EST ------- Well...
A problem of owning the directory %{_datadir}/gEDA/bitmap between geda-symbols <-> geda-gsymcheck geda-symbols <-> geda-gschem .
I reopen this bug to fix directory owning problem.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
cgoorah@yahoo.com.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From cgoorah@yahoo.com.au 2006-09-01 19:59 EST ------- # geda-symbols is the Owner of the following directories #%dir %{_datadir}/gEDA #%dir %{_datadir}/gEDA/bitmap #%dir %{_datadir}/gEDA/docs #%dir %{_datadir}/gEDA/docs/man #%dir %{_datadir}/gEDA/examples #%dir %{_datadir}/gEDA/scheme
fixed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/show_bug.cgi?id=204263
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=204263
Chitlesh GOORAH cgoorah@yahoo.com.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Chitlesh GOORAH cgoorah@yahoo.com.au 2008-12-21 14:40:52 EDT --- New Package CVS Request ======================= Package Name: geda-symbols Short Description: Electronic symbols for gEDA Owners: chitlesh Branches: EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=204263
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2008-12-22 22:17:41 EDT --- cvs done.
package-review@lists.fedoraproject.org