[Bug 225075] New: Review Request: ntfs-config - A front-end to Enable/Disable writable support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
Summary: Review Request: ntfs-config - A front-end to Enable/Disable writable support Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lxtnow@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://blog.fedora-fr.org/public/smootherfrogz/SPECS/ntfs-config.spec SRPM URL: http://blog.fedora-fr.org/public/smootherfrogz/RPMs/ntfs-config-0.5.2-1.fc6.... Description:
ntfs-config will allow you to enable/disable write support for external and/or internal device with only two click. This will configure your system to use the new ntfs-3g driver instead of the current read-only kernel one.
-----------------
Hi, here is another package from me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable writable support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: ntfs-config |Review Request: ntfs-config |- A front-end to |- A front-end to |Enable/Disable writable |Enable/Disable writable |support |support OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable writable support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |fc6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: ntfs-config |Review Request: ntfs-config |- A front-end to |- A front-end to |Enable/Disable writable |Enable/Disable write support |support |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-09 09:47 EST ------- Created an attachment (id=147773) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147773&action=vie...) Mock build log of ntfs-config-0.5.2-1.fc7
Mockbuild of ntfs-config-0.5.2-1 fails on FC-devel i386. It seems that many needes BuildRequires are missing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From lxtnow@gmail.com 2007-02-09 10:18 EST ------- yeah, my bad, forgot to upload fixed files. it'll done to night
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From lxtnow@gmail.com 2007-02-10 08:40 EST ------- Rebuild to updated ntfs-config to 0.5.4-1 New spec and srpm files below
Spec: http://blog.fedora-fr.org/public/smootherfrogz/SPECS/ntfs-config.spec SRPM: http://blog.fedora-fr.org/public/smootherfrogz/RPMs/ntfs-config-0.5.4-1.fc6....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From lxtnow@gmail.com 2007-02-10 08:47 EST ------- s/updated/update
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-10 11:05 EST ------- Well, for 0.5.4-1:
* BuildRequires/Requires: - This is gtk2 application and gtk+ is not necessary. - Also, libglade is not needed. - pkgconfig for BuildRequires is redundant as gtk2-devel requires (and should require) pkgconfig. - gtk2-devel for BuildRequires is redundant. libglade2-devel requires gtk2-devel.
* Source vs using echo - Personally, I don't like to use "echo ???? >> file" because: - it may update timestamp of the file unnecessarily. - this makes the spec file larger. Rather I like to make a file and include it as sources.
* Desktop file - Category ------------------------------------------------------------- --add-category X-Fedora \ ------------------------------------------------------------- This category is deprecated and should be removed. - Icon ------------------------------------------------------------- Icon=gnome-dev-harddisk ------------------------------------------------------------- aracarte shows that this is taken from /usr/share/icons/Bluecurve/48x48/devices/gnome-dev-harddisk.png, so adding "Requires: redhat-artwork" is preferable, IMO (on FC-devel. on FC-6, this may differs).
* soft linking - soft linking should be relative. ------------------------------------------------------------- ln -s /%{_bindir}/consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name} ------------------------------------------------------------- should be: ------------------------------------------------------------- ln -s consolehelper $RPM_BUILD_ROOT%{_bindir}/%{name} -------------------------------------------------------------
* Timestamps - Keep timestamps on text files, for example, .fdi files in /usr/share/ntfs-config/. Perhaps ------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -c -p" ------------------------------------------------------------- will work (check this).
* Documentation - Please add the following documents. ------------------------------------------------------------- README TODO -------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-10 11:09 EST ------- s|aracarte|alacarte|
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From lxtnow@gmail.com 2007-02-12 21:26 EST ------- all fixed.
new spec and srpm files:
http://blog.fedora-fr.org/public/smootherfrogz/SPECS/ntfs-config.spec http://blog.fedora-fr.org/public/smootherfrogz/RPMs/ntfs-config-0.5.4-2.fc6....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-13 07:53 EST ------- I hope I can check this by tomorrow... may take a bit long..
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-14 03:52 EST ------- For -2:
* Timestamps - Well, to keep timestamps on files installed from source, using "cp -p" or "install -p" is needed. Then please "install -p -Dm 644 ...", for example.
* disttag - Well, disttag for %changelog entry is not needed. rpmlint ignored when disttag is missing on %changelog, however if you explicitly write .fc6 on disttag, rpmlint complains to me because... I use rawhide. i.e. please write: --------------------------------------------------- * Mon Feb 13 2007 Xavier Lamien lxtnow@gmail.com - 0.5.4-2 ---------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From lxtnow@gmail.com 2007-02-14 17:17 EST ------- Files updated, just click above....same location.
(in reply to comment #9)
[...] rpmlint complains to me because... I use rawhide. [...]
i've not this problem with mock building for rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-15 00:45 EST ------- Umm... where?
Would you bump release to -3 and re-upload? At least I viewed your spec file http://blog.fedora-fr.org/public/smootherfrogz/SPECS/ntfs-config.spec and "install" does not keep timestamps (still written as install -Dm 644, not install -p -Dm 644)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From lxtnow@gmail.com 2007-02-15 06:27 EST ------- timestamps already added to "install -p -Dm 644" clean your cache and retry please.
i'll bump it to -3 -;)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-15 09:55 EST ------- ???
Still http://blog.fedora-fr.org/public/smootherfrogz/SPECS/ntfs-config.spec says "install -Dm 644" and -3 srpm doesn't seem to be available from http://blog.fedora-fr.org/public/smootherfrogz/RPMs/ ...
(Please bump release tag every time you change/fix spec/srpm. Changing spec/srpm without changing release number causes confusion on people who are watching the package)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From lxtnow@gmail.com 2007-02-15 11:53 EST ------- New updated files:
http://blog.fedora-fr.org/public/smootherfrogz/SPECS/ntfs-config.spec http://blog.fedora-fr.org/public/smootherfrogz/RPMs/ntfs-config-0.5.4-3.fc7....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-15 14:21 EST ------- I should write what I meant more politely...
Well, ----------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p -Dm 644" ----------------------------------------------------- should be ----------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ----------------------------------------------------- Executable bits on scripts/binaries will be removed when adding "-Dm 644". And the following lines ----------------------------------------------------- install -Dm 644 %{SOURCE1} $RPM_BUILD_ROOT/%{_sysconfdir}/pam.d/%{name} install -Dm 644 %{SOURCE2} $RPM_BUILD_ROOT/%{_sysconfdir}/security/console.apps/%{name} ----------------------------------------------------- are not fixed yet ("install -p -Dm 644" should be used also on the two lines above)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From lxtnow@gmail.com 2007-02-15 15:09 EST -------
I should write what I meant more politely...
lol....^^
updated:
http://blog.fedora-fr.org/public/smootherfrogz/SPECS/ntfs-config.spec http://blog.fedora-fr.org/public/smootherfrogz/RPMs/ntfs-config-0.5.4-4.fc6....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | Flag| |fedora-review+
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-16 08:45 EST ------- Okay. Two minor issues.
* setup directory -------------------------------------------- %setup -q -n %{name}-%{version} -------------------------------------------- is okay with -------------------------------------------- %setup -q -------------------------------------------- because the default directory is %{name}-%{version}
* For Requires/BuildRequires of perl modules: -------------------------------------------- BuildRequires: perl-XML-Parser -------------------------------------------- Well, for perl modules, the preferred style is -------------------------------------------- BuildRequires: perl(XML::Parser) --------------------------------------------
Anything else is okay. ----------------------------------------------- This package (ntfs-config) is APPROVED by me. -----------------------------------------------
Please fill up http://fedoraproject.org/wiki/Extras/CVSSyncNeeded and import this package after cvsadmin does some needed procedure.
By the way, are you in need of sponsor? I see that you assigned some review requests to yourself, however as far as I know the person who can review the bug must be in fedorabugs group, and then must be in cvsadmin group...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From lxtnow@gmail.com 2007-02-16 10:18 EST -------
- setup directory
%setup -q -n %{name}-%{version}
is okay with
%setup -q
because the default directory is %{name}-%{version}
It's why i let it like that ;-)
Well, for perl modules, the preferred style is
BuildRequires: perl(XML::Parser)
okay, i can change it to perl(XML::Parser) ;-)
Please fill up http://fedoraproject.org/wiki/Extras/CVSSyncNeeded and import this package after cvsadmin does some needed procedure.
By the way, are you in need of sponsor? I see that you assigned some review requests to yourself, however as far as I know the person who can review the bug must be in fedorabugs group, and then must be in cvsadmin group...
I'm in the fedorabugs group but, not in cvsadmin group yet. And i'm in fact still looking for sponsors... If you can do something for me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-16 10:30 EST ------- (In reply to comment #18)
- setup directory
It's why i let it like that ;-)
Okay, I don't force it.
Please fill up http://fedoraproject.org/wiki/Extras/CVSSyncNeeded and import this package after cvsadmin does some needed procedure.
By the way, are you in need of sponsor?
I'm in the fedorabugs group but, not in cvsadmin group yet. And i'm in fact still looking for sponsors... If you can do something for me.
Then I will sponsor you. Please follow the procedure of http://fedoraproject.org/wiki/Extras/Contributors .
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-16 13:11 EST ------- Removing NEEDSPONSOR. I am now sponsoring.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Keywords| |Reopened Resolution|NEXTRELEASE | Flag|fedora-review+, fedora-cvs+ |fedora-review?
------- Additional Comments From lxtnow@gmail.com 2007-03-01 12:28 EST ------- New release cames up
SPEC: http://download.tuxfamily.org/lxtnow/fedora/SPECS/ntfs-config.spec SRPM: http://download.tuxfamily.org/lxtnow/fedora/devel/SRPMS/ntfs-config-0.5.5-1.... Mock log: http://download.tuxfamily.org/lxtnow/fedora/devel/Logs/build.log
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163779 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-03-01 12:33 EST ------- ... Why did you reopen this?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ntfs-config - A front-end to Enable/Disable write support
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225075
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE OtherBugsDependingO|163778 | nThis| | Flag|fedora-review? |fedora-review+, fedora-cvs+
------- Additional Comments From lxtnow@gmail.com 2007-03-02 13:00 EST ------- New review isn't requires for this updated release, no major changes happened.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla