https://bugzilla.redhat.com/show_bug.cgi?id=2180450
Bug ID: 2180450 Summary: Review Request: hirte - a service orchestrator tool intended for multi-node devices (e.g.: edge devices) clusters Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pingou@pingoured.fr QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://pingou.fedorapeople.org/RPMs/hirte.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/hirte-0.1.0-1.el9.src.rpm Description: Hirte is a service orchestrator tool intended for multi-node devices (e.g.: edge devices) clusters with a predefined number of nodes and with a focus on highly regulated environment such as those requiring functional safety (for example in cars).
Fedora Account System Username: pingou
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review? Status|NEW |ASSIGNED CC| |ngompa13@gmail.com
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/containe | |rs/hirte
--- Comment #2 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5690411 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #3 from Pierre-YvesChibon pingou@pingoured.fr --- Spec URL: https://pingou.fedorapeople.org/RPMs/hirte.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/hirte-0.1.0-2.el9.src.rpm
With a happier rpmlint :)
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #4 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5690809 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #5 from Pierre-YvesChibon pingou@pingoured.fr --- Spec URL: https://pingou.fedorapeople.org/RPMs/hirte.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/hirte-0.1.0-2.fc39.src.rpm
Sorry I had the wrong dist-tag in the src.rpm...
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #6 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5690816 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- Style nit: if you're going to have scriptlets near the package definition, you should probably group the file lists there too.
For example: https://src.fedoraproject.org/rpms/libheif/blob/rawhide/f/libheif.spec
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #8 from Pierre-YvesChibon pingou@pingoured.fr --- Spec URL: https://pingou.fedorapeople.org/RPMs/hirte.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/hirte-0.1.0-3.fc39.src.rpm
Structure adjusted as proposed
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #9 from Pierre-YvesChibon pingou@pingoured.fr --- Spec URL: https://pingou.fedorapeople.org/RPMs/hirte.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/hirte-0.1.0-4.fc39.src.rpm
Fixed the Source0 and replaces tabs with spaces to be consistent
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #10 from Pierre-YvesChibon pingou@pingoured.fr --- Spec URL: https://pingou.fedorapeople.org/RPMs/hirte.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/hirte-0.1.0-5.fc39.src.rpm
Adjusted summary and description from the upstream PR: https://github.com/containers/hirte/pull/218
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #11 from Neal Gompa ngompa13@gmail.com --- Spec review:
License: GPLv2
The license is "GPL-2.0-or-later" from what I see in the sources.
Source0: %{url}/archive/refs/tags/%{name}-%{version}.tar.gz
The format should be "%{url}/archive/%{name}-%{version}.tar.gz"
%{_sysconfdir}/dbus-1/system.d/org.containers.hirte.conf
This should be installed into "%{_datadir}/dbus-1/system.d"
%{_sysconfdir}/dbus-1/system.d/org.containers.hirte.Agent.conf
Ditto.
%setup -c -q
Shouldn't this be just "%autosetup"? And why are we creating a directory ("-c")?
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #12 from Neal Gompa ngompa13@gmail.com --- (In reply to Neal Gompa from comment #11)
Source0: %{url}/archive/refs/tags/%{name}-%{version}.tar.gz
The format should be "%{url}/archive/%{name}-%{version}.tar.gz"
Gah, it's "%{url}/archive/%{name}-%{version}/%{name}-%{version}.tar.gz"
Which means you need "%autosetup -n %{name}-%{name}-%{version}" since your tag format is %name-%version.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #13 from Pierre-YvesChibon pingou@pingoured.fr --- $ wget https://github.com/containers/hirte/archive/hirte-0.1.0/hirte-0.1.0.tar.gz .. 2023-03-27 16:49:30 ERROR 404: Not Found.
Same for 0.1.1
Granted, https://github.com/containers/hirte/archive/refs/tags/hirte-0.1.1.tar.gz also returns a 404 :(
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #14 from Martin Perina mperina@redhat.com --- (In reply to Pierre-YvesChibon from comment #13)
$ wget https://github.com/containers/hirte/archive/hirte-0.1.0/hirte-0.1.0.tar.gz .. 2023-03-27 16:49:30 ERROR 404: Not Found.
Same for 0.1.1
Granted, https://github.com/containers/hirte/archive/refs/tags/hirte-0.1.1.tar.gz also returns a 404 :(
:-(
Looks like GitHub is performing different magic based on the tag name used.
I'm going to revert to the official URL from the GitHub release page:
https://github.com/containers/hirte/archive/refs/tags/v0.1.1.tar.gz
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #15 from Neal Gompa ngompa13@gmail.com --- (In reply to Martin Perina from comment #14)
(In reply to Pierre-YvesChibon from comment #13)
$ wget https://github.com/containers/hirte/archive/hirte-0.1.0/hirte-0.1.0.tar.gz .. 2023-03-27 16:49:30 ERROR 404: Not Found.
Same for 0.1.1
Granted, https://github.com/containers/hirte/archive/refs/tags/hirte-0.1.1.tar.gz also returns a 404 :(
:-(
Looks like GitHub is performing different magic based on the tag name used.
I'm going to revert to the official URL from the GitHub release page:
https://github.com/containers/hirte/archive/refs/tags/v0.1.1.tar.gz
This works: https://github.com/containers/hirte/archive/v0.1.1/hirte-0.1.1.tar.gz
Please use "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #16 from Neal Gompa ngompa13@gmail.com --- It was unclear which tag format you were using.
Looking here, it's much more obvious: https://github.com/containers/hirte/tags
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #17 from Neal Gompa ngompa13@gmail.com --- (In reply to Neal Gompa from comment #15)
(In reply to Martin Perina from comment #14)
(In reply to Pierre-YvesChibon from comment #13)
$ wget https://github.com/containers/hirte/archive/hirte-0.1.0/hirte-0.1.0.tar.gz .. 2023-03-27 16:49:30 ERROR 404: Not Found.
Same for 0.1.1
Granted, https://github.com/containers/hirte/archive/refs/tags/hirte-0.1.1.tar.gz also returns a 404 :(
:-(
Looks like GitHub is performing different magic based on the tag name used.
I'm going to revert to the official URL from the GitHub release page:
https://github.com/containers/hirte/archive/refs/tags/v0.1.1.tar.gz
This works: https://github.com/containers/hirte/archive/v0.1.1/hirte-0.1.1.tar.gz
Please use "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"
This means that the inner folder in the archive will be %{name}-%{version}, so you don't need -n for %autosetup at all.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #18 from Pierre-YvesChibon pingou@pingoured.fr --- yup thanks, found it just before refreshing this page :D
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #19 from Pierre-YvesChibon pingou@pingoured.fr --- Spec URL: https://pingou.fedorapeople.org/RPMs/hirte.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/hirte-0.1.1-1.fc39.src.rpm
- Update to 0.1.1 - Adjust Source0 to point to /archive/hirte-<version>/hirte-<version>.tar.gz - Adjust the location of dbus-1/system.d/org.containers.hirte.conf and bus-1/system.d/org.containers.hirte.Agent.conf so they are in _datadir - Add the hirte-ctl subpackage (which provides hirtectl for convenience)
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #20 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1953958 --> https://bugzilla.redhat.com/attachment.cgi?id=1953958&action=edit The .spec file difference from Copr build 5690816 to 5712539
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #21 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5712539 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #22 from Neal Gompa ngompa13@gmail.com --- For the ctl subpackage
Requires: %{name} = %{version}-%{release}
Is this actually true? Or can it be installed to control a remote hirte agent?
- Adjust Source0 to point to /archive/hirte-<version>/hirte-<version>.tar.gz
This is not actually what happened. :)
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #23 from Neal Gompa ngompa13@gmail.com --- Also, hirtectl is included in the agent package too. You should probably remove it from there.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #24 from Pierre-YvesChibon pingou@pingoured.fr ---
Requires: %{name} = %{version}-%{release}
Is this actually true? Or can it be installed to control a remote hirte agent?
The CLI talks locally to hirte, so yeah, they need to be both on the same system.
This is not actually what happened. :)
Busted :)
Also, hirtectl is included in the agent package too. You should probably remove it from there.
On it!
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #25 from Pierre-YvesChibon pingou@pingoured.fr --- Spec URL: https://pingou.fedorapeople.org/RPMs/hirte.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/hirte-0.1.1-2.fc39.src.rpm
Adjusted for the cli in hirte and fixed the built issue from 0.1.1-1
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #26 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1953961 --> https://bugzilla.redhat.com/attachment.cgi?id=1953961&action=edit The .spec file difference from Copr build 5712539 to 5712589
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #27 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5712589 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #28 from Neal Gompa ngompa13@gmail.com ---
%{_mandir}/man1/hirtectl.*
Still in agent package and ctl package. :)
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #29 from Neal Gompa ngompa13@gmail.com --- (In reply to Neal Gompa from comment #28)
%{_mandir}/man1/hirtectl.*
Still in agent package and ctl package. :)
Err, main package and ctl package.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #30 from Pierre-YvesChibon pingou@pingoured.fr --- Ah the man page, with the glob, I had missed it. Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #31 from Pierre-YvesChibon pingou@pingoured.fr --- Spec URL: https://pingou.fedorapeople.org/RPMs/hirte.spec SRPM URL: https://pingou.fedorapeople.org/RPMs/hirte-0.1.1-3.fc39.src.rpm
Without the man page for hirtectl in the main hirte package
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #32 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1954104 --> https://bugzilla.redhat.com/attachment.cgi?id=1954104&action=edit The .spec file difference from Copr build 5712589 to 5715857
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #33 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5715857 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #34 from Neal Gompa ngompa13@gmail.com --- Everything looks good to me now.
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #35 from Pierre-YvesChibon pingou@pingoured.fr --- Thank you !
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #36 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/hirte
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #37 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-3f9f794783 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3f9f794783
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #38 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-7f21a2f40d has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7f21a2f40d
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #39 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-7f21a2f40d has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-7f21a2f40d *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7f21a2f40d
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #40 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-3f9f794783 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-3f9f794783 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3f9f794783
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2023-04-04 00:54:37
--- Comment #41 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-7f21a2f40d has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #42 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-3f9f794783 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #43 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-97a6746095 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-97a6746095
https://bugzilla.redhat.com/show_bug.cgi?id=2180450
--- Comment #44 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-97a6746095 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org