[Bug 1308367] New: Review Request: libraknet - Cross platform C++ networking library, primarily for games
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
Bug ID: 1308367 Summary: Review Request: libraknet - Cross platform C++ networking library, primarily for games Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: johnmh@openmailbox.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://git.openblox.org/raknet.git/plain/raknet.spec SRPM URL: https://openblox.org/~johnmh/libraknet-4.081-1.fc23.src.rpm Description: RakNet is a cross platform "open source" networking library written in C++. RakNet is geared towards games, and is already used in at least one package that is currently in Fedora (blobby). It's under the BSD license, and currently owned by Oculus VR, Inc.
The upstream repository is located on GitHub: https://github.com/OculusVR/RakNet
Fedora Account System Username: johnmh
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
--- Comment #1 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- johnmh's scratch build of libraknet-4.081-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12990400
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@freenet.de
--- Comment #2 from Ralf Corsepius rc040203@freenet.de --- Am I correct in assuming you to be new to fedora packaging?
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
--- Comment #3 from John M. Harris, Jr. johnmh@openmailbox.org --- (In reply to Ralf Corsepius from comment #2)
Am I correct in assuming you to be new to fedora packaging?
Yes, this would be my first package.
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
John M. Harris, Jr. johnmh@openmailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
--- Comment #4 from John M. Harris, Jr. johnmh@openmailbox.org --- Revised spec file and SRPM
Spec URL: https://git.openblox.org/raknet.git/plain/libraknet.spec SRPM URL: https://openblox.org/~johnmh/libraknet-4.081-1.fc23.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
--- Comment #5 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- johnmh's scratch build of libraknet-4.081-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12990732
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
--- Comment #6 from John M. Harris, Jr. johnmh@openmailbox.org --- Updated Spec file, "Packager" is no longer hard-coded and I'm no longer using wildcards like crazy (libdir/*).
SRPM URL: https://openblox.org/~johnmh/libraknet-4.081-2.fc23.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
--- Comment #7 from John M. Harris, Jr. johnmh@openmailbox.org --- Updated spec file to use cmake on RakNet's sources. Thanks to the way the upstream CMake files were written, some changes were necessary. A pull request has been made. There is currently a pull request to fix the `install` target of the generated Makefile, as well.
Spec URL: https://git.openblox.org/raknet.git/plain/libraknet.spec SRPM URL: https://github.com/JohnMHarrisJr/RakNet/releases/download/4.081-2/libraknet-...
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
--- Comment #8 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- johnmh's scratch build of libraknet-4.081-3.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13067927
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
Richard Shaw hobbes1069@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069@gmail.com
--- Comment #9 from Richard Shaw hobbes1069@gmail.com --- A little spec review:
1. rm -rf $RPM_BUILD_ROOT in %install isn't needed anymore (for a long time).
2. "cp -f" in %install
You shouldn't need to force anything as nothing should already be there but you should preserve time stamps so use "cp -p" instead.
3. find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
Since this appears to be a cmake project I would be surprised to see libtool archives in it but I haven't tried building the software yet.
4. %{_libdir}/libraknet.so
Fedora pretty much requires libraries to carry a soversion for anything going into %{_libdir}. This will take some more thought. I have a project that I have to maintain the soversion manually. It's not terribly problematic but I do have to check changes against abi-compliance-checker to see if I need to bump the version.
5. %changelog
a. There should be one line between changelog entries. b. Your name and email address should be in them (it's ok to mangle the email address if that's a concern). c. The release should be on the end.
So your current changelog would become:
%changelog * Sat Feb 20 2016 John M. Harris <email address> - 4.081-3 - Use actual RakNet sources and CMake to generate build files.
* Mon Feb 15 2016 John M. Harris <email address> - 4.081-2 - Updated spec file to use a wildcard for headers, not for libraries.
* Mon Feb 15 2016 John M. Harris <email address> - 4.081-1 - Initial packaging of raknet.
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
--- Comment #10 from John M. Harris, Jr. johnmh@openmailbox.org --- Updated spec file, patched CMake files from upstream for SO versioning.
Spec URL: https://git.openblox.org/raknet.git/plain/libraknet.spec SRPM URL: https://github.com/JohnMHarrisJr/RakNet/releases/download/4.081-4/libraknet-...
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
--- Comment #11 from Michael Schwendt bugs.michael@gmx.net ---
%files %license LICENSE %{_libdir}/libraknet.so.4.081 %{_libdir}/libraknet.so
%files devel %{_includedir}/raknet/*.h
Placement of build-time .so files: https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
Unowned directory /usr/include/raknet/: https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Owner...
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
--- Comment #12 from John M. Harris, Jr. johnmh@openmailbox.org --- Updated spec file, %files devel now lists %{_includedir}/raknet/ instead of %{_includedir}/raknet/*.h
libraknet.so has been moved from %files to %files devel
Spec URL: https://git.openblox.org/raknet.git/plain/libraknet.spec SRPM URL: https://github.com/JohnMHarrisJr/RakNet/releases/download/4.081-5/libraknet-...
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
Ben Rosser rosser.bjr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1364745
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] (FE-GAMESIG) Games SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ignatenko@redhat.com, | |vrutkovs@redhat.com Summary|Review Request: libraknet - |Review Request: raknet - |Cross platform C++ |C++ networking engine for |networking library, |game programmers |primarily for games | Flags| |needinfo?(vrutkovs@redhat.c | |om)
--- Comment #13 from Igor Gnatenko ignatenko@redhat.com --- please rename it to raknet or even to RakNet, as this is upstream name.
Vadim, can you make review of this simple, but useful package?
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
mark.otaris@openmailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mark.otaris@openmailbox.org
--- Comment #14 from mark.otaris@openmailbox.org --- Renamed to raknet in b722205bf223d7bbde70a54d608d0bf602ac5e14, spec is at https://git.openblox.org/raknet.git/tree/raknet.spec and SRPM at https://openblox.org/~mark/raknet-4.081-5.fc24.src.rpm.
FAS username: markotaris
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
--- Comment #15 from mark.otaris@openmailbox.org --- Actually, SRPM at https://openblox.org/~mark/raknet-4.081-6.fc24.src.rpm. I forgot to increment the release number, I am sorry.
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
Ben Rosser rosser.bjr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rosser.bjr@gmail.com Flags|needinfo?(vrutkovs@redhat.c |needinfo?(mark@net-c.com) |om) |
--- Comment #16 from Ben Rosser rosser.bjr@gmail.com --- What's the status of this review? Mark, are you interested in taking it over?
If so, I think the policy is that you should open a new review request and mark this one as a duplicate: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_... (assuming John is no longer interested in the package).
https://bugzilla.redhat.com/show_bug.cgi?id=1308367
Ben Rosser rosser.bjr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed| |2018-08-07 16:46:01
--- Comment #17 from Ben Rosser rosser.bjr@gmail.com --- Okay, I'm going to close this ticket in accordance with the stalled review policy (which I linked in my previous comment), as it's been much longer than a week with no response here...
If someone (Mark?) is still interested in packaging raknet (or a fork of raknet), please open a new ticket for that request. I'm happy to review.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla