https://bugzilla.redhat.com/show_bug.cgi?id=2118262
Bug ID: 2118262 Summary: Review Request: python-icoextract - Windows PE EXE icon extractor Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: ego.cordatus@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 2091535 Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-ra... SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-ra...
Description: icoextract is an icon extractor for Windows PE files (.exe/.dll), written in Python. It also includes a thumbnailer script (exe-thumbnailer) for Linux desktops.
This project is inspired by extract-icon-py, icoutils, and others.
icoextract aims to be:
* Lightweight * Portable (cross-platform) * Fast on large files
Fedora Account System Username: atim
---
Test passed: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-ra...
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2091535 [Bug 2091535] bottles-2022.8.14-brescia is available
https://bugzilla.redhat.com/show_bug.cgi?id=2118262
Yaroslav Sidlovsky zawertun@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |zawertun@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review? CC| |zawertun@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=2118262
--- Comment #1 from Yaroslav Sidlovsky zawertun@gmail.com --- License `MIT/Expat` is not from the list of good licenses from https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses. Please change it with `MIT`.
https://bugzilla.redhat.com/show_bug.cgi?id=2118262
--- Comment #2 from Artem ego.cordatus@gmail.com --- Spec URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-ra... SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-ra...
https://bugzilla.redhat.com/show_bug.cgi?id=2118262
Yaroslav Sidlovsky zawertun@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Yaroslav Sidlovsky zawertun@gmail.com ---
This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 20 files have unknown license. Detailed output of licensecheck in /home/zawertun/2118262-python- icoextract/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
python3-icoextract.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/icoextract/__init__.py 644 /usr/bin/env python3 python3-icoextract.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/icoextract/scripts/extract.py 644 /usr/bin/env python3 python3-icoextract.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/icoextract/scripts/icolist.py 644 /usr/bin/env python3 python3-icoextract.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/icoextract/scripts/thumbnailer.py 644 /usr/bin/env python3 python3-icoextract.noarch: W: no-manual-page-for-binary exe-thumbnailer python3-icoextract.noarch: W: no-manual-page-for-binary icoextract python3-icoextract.noarch: W: no-manual-page-for-binary icolist 1 packages and 0 specfiles checked; 4 errors, 3 warnings, 4 badness; has taken 0.0 s
Source checksums ---------------- https://github.com/jlu5/icoextract/archive/0.1.4/python-icoextract-0.1.4.tar... : CHECKSUM(SHA256) this package : 9d84a6191c02326bdf6f7689184540aba5b683b9c626ed832ff20c426f2d6746 CHECKSUM(SHA256) upstream package : 9d84a6191c02326bdf6f7689184540aba5b683b9c626ed832ff20c426f2d6746
Requires -------- python3-icoextract (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.11dist(pefile) python3dist(pefile) python3dist(pillow) python3dist(setuptools)
Provides -------- python3-icoextract: python-icoextract python3-icoextract python3.11-icoextract python3.11dist(icoextract) python3dist(icoextract)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2118262 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: SugarActivity, Perl, fonts, PHP, Ocaml, R, Java, C/C++, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2118262
--- Comment #4 from Yaroslav Sidlovsky zawertun@gmail.com --- Looks good, just tested it on listing & extracting icons from regedit.exe (from wine) - works as expected. Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2118262
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-icoextract
https://bugzilla.redhat.com/show_bug.cgi?id=2118262
--- Comment #6 from Artem ego.cordatus@gmail.com --- Thank you! Last minute fix before import for rpmlint complain:
Spec URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-ra... SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-ra...
https://bugzilla.redhat.com/show_bug.cgi?id=2118262
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d2d14d542f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d2d14d542f
https://bugzilla.redhat.com/show_bug.cgi?id=2118262
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d2d14d542f has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d2d14d542f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d2d14d542f
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2118262
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2022-11-10 22:22:04
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d2d14d542f has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com