https://bugzilla.redhat.com/show_bug.cgi?id=2075984
Bug ID: 2075984 Summary: Review Request: rust-jsonxf - Fast JSON pretty-printer and minimizer Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: carmelo.sarta.main@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/Laiot/rust-jsonxf-rpm/master/rust-jsonxf.s... SRPM URL: https://github.com/Laiot/rust-jsonxf-rpm/raw/master/rust-jsonxf-1.1.1-1.fc36... Description: Fast JSON pretty-printer and minimizer Fedora Account System Username: laiot
https://bugzilla.redhat.com/show_bug.cgi?id=2075984
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Are you packaging this crate for the binary, or for its library interface?
If you want to also ship the jsonxf binary, you'd need to take care about correctly specifying the license of all the components that get statically linked into it. I think in this case all the licenses of all crate dependencies are compatible with "MIT" so it wouldn't actually make a difference, but you need to check (and keep checking for every new version of jsonxf).
https://bugzilla.redhat.com/show_bug.cgi?id=2075984
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@redhat.com Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |pemensik@redhat.com Status|NEW |POST
--- Comment #2 from Petr Menšík pemensik@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/jsonxf-1.1.1/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 36 files have unknown license. Detailed output of licensecheck in /home/pihhan/fedora/review/2075984-rust-jsonxf/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jsonxf , rust-jsonxf-devel , rust-jsonxf+default-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://crates.io/api/v1/crates/jsonxf/1.1.1/download#/jsonxf-1.1.1.crate : CHECKSUM(SHA256) this package : 50d6889ea54a6add10ed8a757719ec88293201265fa7fe56e09ae66b6df038a6 CHECKSUM(SHA256) upstream package : 50d6889ea54a6add10ed8a757719ec88293201265fa7fe56e09ae66b6df038a6
Requires -------- jsonxf (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) rtld(GNU_HASH)
rust-jsonxf-devel (rpmlib, GLIBC filtered): (crate(getopts/default) >= 0.2.0 with crate(getopts/default) < 0.3.0~) (crate(memchr/default) >= 2.3.4 with crate(memchr/default) < 3.0.0~) /usr/bin/ruby cargo
rust-jsonxf+default-devel (rpmlib, GLIBC filtered): cargo crate(jsonxf)
rust-jsonxf-debugsource (rpmlib, GLIBC filtered):
Provides -------- jsonxf: jsonxf jsonxf(x86-64)
rust-jsonxf-devel: crate(jsonxf) rust-jsonxf-devel
rust-jsonxf+default-devel: crate(jsonxf/default) rust-jsonxf+default-devel
rust-jsonxf-debugsource: rust-jsonxf-debugsource rust-jsonxf-debugsource(x86-64)
Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2075984 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: C/C++, Haskell, R, Python, PHP, Perl, Ocaml, SugarActivity, Java, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2075984
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Note: This package ships a statically linked binary, but there is no License tag to take this fact into account. c.f. https://docs.fedoraproject.org/en-US/legal/license-field/#_rust_packages
Also, my previous comment is no longer compatible with latest guidance from Red Hat Legal - for example, licenses like "MIT" and "MIT OR Apache-2.0" can no longer be simplified to just "MIT" but need to be listed as "MIT AND (MIT OR Apache-2.0)".
https://bugzilla.redhat.com/show_bug.cgi?id=2075984
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(carmelo.sarta.mai | |n@gmail.com)
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- This package was approved a few weeks ago, but was never imported. If you're still interested, please address the issue I raised in the previous comment. The "fedora-review+" flag will also likely need to be refreshed.
https://bugzilla.redhat.com/show_bug.cgi?id=2075984
Carmelo Sarta carmelo.sarta.main@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|POST |CLOSED Flags|needinfo?(carmelo.sarta.mai | |n@gmail.com) | Last Closed| |2024-05-16 11:00:12
--- Comment #5 from Carmelo Sarta carmelo.sarta.main@gmail.com --- Closing this, not interested in packaging this crate anymore.
Kind regards, Carmelo
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com