https://bugzilla.redhat.com/show_bug.cgi?id=2159144
Bug ID: 2159144 Summary: Review Request: kvmd - An KVM(Keyboard, Video, Mouse) daemon Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: tao-j@outlook.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=2159144
Tao Jin tao-j@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Tao Jin tao-j@outlook.com --- Spec URL: https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-rawhid... SRPM URL: https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-rawhid...
There are some points that worth discuss, your opinions are appreciated.
1. The original author builds a package for each possible hardware combination https://github.com/pikvm/kvmd/blob/1b10766071ad96dcd5e788a8b2fb6e178e44e20c/... Do we also want this in fedora? Currently the default config files are located at %{_datadir}
2. The kvmd binary has to read/write /dev/gpiochip* sometimes (it is 660 on my system). So the kvmd* user has been added to the gpio group.
3. The upstream has some hardcoded code to access device_tree and vcgencmd, which may only exists in rpi distribution. So I copied some mock script (fake) to be used.
https://bugzilla.redhat.com/show_bug.cgi?id=2159144
--- Comment #2 from Tao Jin tao-j@outlook.com --- Reworked Spec:
Spec URL: https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-rawhid... SRPM URL: https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-rawhid...
Description:
The kvmd daemon is used to make the server running this service capable of being as an out of band KVM(Keyboard, Video, Mouse) machine over the network.
Fedora Account System Username: tao-j
https://bugzilla.redhat.com/show_bug.cgi?id=2159144
--- Comment #3 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5207873 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2159144
--- Comment #4 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1936702 --> https://bugzilla.redhat.com/attachment.cgi?id=1936702&action=edit The .spec file difference from Copr build 5207873 to 5207874
https://bugzilla.redhat.com/show_bug.cgi?id=2159144
--- Comment #5 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5207874 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2159144
Tao Jin tao-j@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NOTABUG Status|NEW |CLOSED Last Closed| |2024-01-25 02:24:29
Product: Fedora Version: rawhide Component: Package Review
Tao Jin tao-j@outlook.com has denied Package Review package-review@lists.fedoraproject.org's request for Tao Jin tao-j@outlook.com's needinfo: Bug 2159144: Review Request: kvmd - An KVM(Keyboard, Video, Mouse) daemon https://bugzilla.redhat.com/show_bug.cgi?id=2159144
package-review@lists.fedoraproject.org