[Bug 1021199] New: Review Request: aspell-fi - Finnish dictionaries for Aspell - package-review

List overview All Threads
Download

newer

[Bug 1021199] New: Review Request: aspell-fi - Finnish dictionaries for Aspell

older

[Bug 1016200] New: Review Request:...

[Bug 1003057] New: Review Request:...

Red Hat Bugzilla

20 Oct 2013 20 Oct '13

5:22 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Bug ID: 1021199 Summary: Review Request: aspell-fi - Finnish dictionaries for Aspell Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: kupo@kupo.se QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org

Spec URL: http://kupo.se/pub/review/aspell/aspell-fi.spec SRPM URL: http://kupo.se/pub/review/aspell/aspell-fi-0.7-1.fc19.src.rpm Description: Provides the word list/dictionaries for the following: Finnish Fedora Account System Username: opuk Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6080641

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

20 Oct 20 Oct

5:22 a.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Johan Swensson kupo@kupo.se changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:21 a.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

--- Comment #1 from Johan Swensson kupo@kupo.se --- Spec URL: http://kupo.se/pub/review/aspell/aspell-fi.spec SRPM URL: http://kupo.se/pub/review/aspell/aspell-fi-0.7-2.fc19.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6080809

%changelog * Sun Oct 20 2013 Johan Swensson kupo@kupo.se - 0.7-2 - Remove irrelevant README file

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

22 Oct 22 Oct

9:52 a.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Michael Schwendt bugs.michael@gmx.net changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

23 Oct 23 Oct

5:51 a.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Michael Schwendt bugs.michael@gmx.net changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #2 from Michael Schwendt bugs.michael@gmx.net --- Amazing that Aspell still has dependencies (repoquery --whatrequires aspell|grep -v ^aspell).

[...]

No older/retired package or stalled review request with the same name could be located.

No other package includes conflicting files:

# repoquery --whatprovides /usr/lib64/aspell-0.60/fi* #

$ rpmls -p aspell-fi-0.7-2.fc21.x86_64.rpm -rw-r--r-- /usr/lib64/aspell-0.60/fi.dat -rw-r--r-- /usr/lib64/aspell-0.60/fi.multi -rw-r--r-- /usr/lib64/aspell-0.60/fi.rws -rw-r--r-- /usr/lib64/aspell-0.60/fi_affix.dat -rw-r--r-- /usr/lib64/aspell-0.60/finnish.alias drwxr-xr-x /usr/share/doc/aspell-fi -rw-r--r-- /usr/share/doc/aspell-fi/COPYING -rw-r--r-- /usr/share/doc/aspell-fi/Copyright

The packaging style (e.g. arch-specific, deps, -debuginfo disabled) matches the other aspell-* packages.

...

URL: http://aspell.net

The author has created an own web page for this package: http://ispell-fi.sourceforge.net

File doc/README says it's an ASCII-fied copy of that page. That file could be included. WDYT?

aspell-fi.x86_64: E: incorrect-fsf-address /usr/share/doc/aspell-fi/COPYING

-> https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

With the last release being from 2000-2004, probably not much will happen related to that.

...

License: GPLv2

The README points at file "Copyright" for the "exact terms", and that one contains the "or (at your option) any later version" clause. That would be "GPLv2+". However:

Considering that the GPLv3 has been released later than 2004, and the web page doesn't contain the "or later version" clause, the file Copyright is likely just a cut'n'paste error. aspell-cs for example gets it right and has dropped the "later version" clause.

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_ver...

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarifi...

Not a big issue, just need to point that out in the review, since there are licensing clarification guidelines. A comment in the spec file above the License tag would be good.

...

./configure

For clarify:

# Custom configure script, %configure cannot and need not be used. ./configure

So, no issues that need another build for review. About the extra comments and the URL, that's up to you and may be touched before/after importing the package into dist git.

I'll contact you privately about packager account sponsorship.

APPROVED

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

24 Oct 24 Oct

3:48 p.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Michael Schwendt bugs.michael@gmx.net changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

25 Oct 25 Oct

7:13 a.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Johan Swensson kupo@kupo.se changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #3 from Johan Swensson kupo@kupo.se --- New Package SCM Request ======================= Package Name: aspell-fi Short Description: Finnish dictionaries for Aspell Owners: opuk Branches: f18 f19 f20 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:37 a.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:37 a.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:06 p.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:06 p.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

--- Comment #5 from Fedora Update System updates@fedoraproject.org --- aspell-fi-0.7-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/aspell-fi-0.7-2.fc18

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:15 p.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

--- Comment #6 from Fedora Update System updates@fedoraproject.org --- aspell-fi-0.7-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/aspell-fi-0.7-2.fc19

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:31 p.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

--- Comment #7 from Fedora Update System updates@fedoraproject.org --- aspell-fi-0.7-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/aspell-fi-0.7-2.fc20

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

26 Oct 26 Oct

1:46 p.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- aspell-fi-0.7-2.fc20 has been pushed to the Fedora 20 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4 Nov 4 Nov

8:55 p.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Fedora Update System updates@fedoraproject.org changed:

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- aspell-fi-0.7-2.fc19 has been pushed to the Fedora 19 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:56 p.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|aspell-fi-0.7-2.fc19 |aspell-fi-0.7-2.fc18

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- aspell-fi-0.7-2.fc18 has been pushed to the Fedora 18 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10 Nov 10 Nov

12:44 a.m.

New subject: [Bug 1021199] Review Request: aspell-fi - Finnish dictionaries for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=1021199

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|aspell-fi-0.7-2.fc18 |aspell-fi-0.7-2.fc20

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- aspell-fi-0.7-2.fc20 has been pushed to the Fedora 20 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

4272

Age (days ago)

4293

Last active (days ago)

package-review@lists.fedoraproject.org

16 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla