Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: heybuddy - Makes using encfs easier
https://bugzilla.redhat.com/show_bug.cgi?id=715119
Summary: Review Request: heybuddy - Makes using encfs easier Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: info-2007@fedora-blog.de QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: https://dl.dropbox.com/s/whokbypjv4neatm/gnome-encfs.spec?dl=1 SRPM URL: https://dl.dropbox.com/s/hol109qbmn9kvec/gnome-encfs-23hg-1.20110621.fc15.sr... Description: Integrate EncFS folders into the GNOME desktop by storing their passwords in the keyring and optionally mounting them at login using GNOME's autostart mechanism.
At the moment I still need a sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715119
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |metherid@gmail.com Summary|Review Request: heybuddy - |Review Request: gnome-encfs |Makes using encfs easier |- Makes using encfs easier
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715119
Yanchuan Nian yanchuan@nfs-china.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yanchuan@nfs-china.com
--- Comment #1 from Yanchuan Nian yanchuan@nfs-china.com 2011-06-22 01:05:57 EDT --- At first glance,%{_datadir}/%{name}/* should be changed to %{_datadir}/%{name}/.Otherwise,directory /usr/share/hg_date can't be removed from your system when erasing this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715119
Paul Flo Williams paul@frixxon.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |paul@frixxon.co.uk Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715119
--- Comment #2 from Yanchuan Nian yanchuan@nfs-china.com 2011-06-22 11:40:53 EDT --- Another comment: %{__install} needs argument -p to preserves the files' timestamps. https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715119
Elder Marco eldermarco@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |eldermarco@gmail.com
--- Comment #3 from Elder Marco eldermarco@gmail.com 2011-07-02 20:17:32 EDT --- Hi, just a few comments,
* The License field must be GPLv3+ (see the source file provided by upstream)
* Currently, the correct version is 0.1. (See the source file provided by upstream)
* Add each dependency on a single line: Requires: python Requires: gnome-python2-gnomekeyring Requires: fuse-encfs
It's more readable.
* %setup -q -n gnome-encfs This line could be: %setup -q -n %{name}
* %{__install} -m 755 gnome-encfs %{buildroot}%{_datadir}/%{name}/gnome-encfs.py And This line could be: %{__install} -m 755 %{name} %{buildroot}%{_datadir}/%{name}/%{name}.py
But,
* You don't need the file gnome-encfs (Source1). Just install gnome-encfs (from tarball) in %{buildroot}%{_bindir}
rpmlint: $ rpmlint /var/lib/mock/fedora-15-x86_64/result/gnome-encfs-23hg-1.20110621.fc15.* gnome-encfs.noarch: W: spelling-error %description -l en_US keyring -> keying, key ring, key-ring gnome-encfs.noarch: W: spelling-error %description -l en_US login -> loin, logic, lo gin gnome-encfs.noarch: W: spelling-error %description -l en_US autostart -> auto start, auto-start, autos tart gnome-encfs.noarch: W: no-manual-page-for-binary gnome-encfs gnome-encfs.src: W: spelling-error %description -l en_US keyring -> keying, key ring, key-ring gnome-encfs.src: W: spelling-error %description -l en_US login -> loin, logic, lo gin gnome-encfs.src: W: spelling-error %description -l en_US autostart -> auto start, auto-start, autos tart gnome-encfs.src: W: invalid-url Source0: gnome-encfs.tar.gz 2 packages and 0 specfiles checked; 0 errors, 8 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715119
--- Comment #4 from Heiko Adams info-2007@fedora-blog.de 2011-07-05 16:15:55 EDT --- updated spec and srpm: Spec URL: https://dl.dropbox.com/s/whokbypjv4neatm/gnome-encfs.spec?dl=1 SRPM URL: https://dl.dropbox.com/s/27b2gdonco1t47e/gnome-encfs-0.1hg-2.20110621.fc15.s...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715119
--- Comment #5 from Heiko Adams info-2007@fedora-blog.de 2011-07-05 16:17:32 EDT --- Can anyone please set the "need sponsor" flag?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715119
--- Comment #6 from Heiko Adams info-2007@fedora-blog.de 2011-08-21 15:06:16 EDT --- Updated files SRPM: https://dl.dropbox.com/s/3jplxy3y6nqbnv2/gnome-encfs-0.1hg-4.20110813.fc15.s... SPEC: https://dl.dropbox.com/s/whokbypjv4neatm/gnome-encfs.spec?dl=1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=715119
Felix Schwarz felix.schwarz@oss.schwarz.eu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |felix.schwarz@oss.schwarz.e | |u
--- Comment #7 from Felix Schwarz felix.schwarz@oss.schwarz.eu 2011-11-11 05:26:44 EST --- just wanted to mention that the rpm works fine for me on Fedora 16 (with a tiny change as the "README" file is now "README.md").
package-review@lists.fedoraproject.org