[Bug 2298528] New: Review Request: rust-current_platform - Find out what platform your code is running on
https://bugzilla.redhat.com/show_bug.cgi?id=2298528
Bug ID: 2298528 Summary: Review Request: rust-current_platform - Find out what platform your code is running on Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jonathansteffan@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-current_platform.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-current_platform-0.2.0-1.fc3... Description: Find out what platform your code is running on. Fedora Account System Username: jsteffan
https://bugzilla.redhat.com/show_bug.cgi?id=2298528
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Doc Type|--- |If docs needed, set a value CC| |code@musicinmybrain.net Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |code@musicinmybrain.net
https://bugzilla.redhat.com/show_bug.cgi?id=2298528
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #1 from Ben Beasley code@musicinmybrain.net --- This is a really trivial crate, and everything is as it should be. The package is APPROVED.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
The spec file is exactly as generated by rust2rpm with no configuration file, greatly simplifying the review.
Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/current_platform-0.2.0/LICENSE-APACHE.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files
This is not a serious problem; if it should be fixed, then it should be fixed in rust2rpm.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* MIT License", "zlib License". 6 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2298528-rust-current_platform/licensecheck.txt [x]: License file installed when any subpackage combination is installed.
$ rpm -qL -p results/rust-current_platform-devel-0.2.0-1.fc41.noarch.rpm /usr/share/cargo/registry/current_platform-0.2.0/LICENSE-APACHE.md /usr/share/cargo/registry/current_platform-0.2.0/LICENSE-MIT.md /usr/share/cargo/registry/current_platform-0.2.0/LICENSE-ZLIB.md
[-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- current_platform-devel , rust-current_platform+default-devel [x]: Package functions as described.
There is a single test, and it passes.
[x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures.
https://koji.fedoraproject.org/koji/taskinfo?taskID=120678046
[x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: rust-current_platform-devel-0.2.0-1.fc41.noarch.rpm rust-current_platform+default-devel-0.2.0-1.fc41.noarch.rpm rust-current_platform-0.2.0-1.fc41.src.rpm ============================================================================================ rpmlint session starts ============================================================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpv_u5ugre')] checks: 32, packages: 3
rust-current_platform+default-devel.noarch: W: no-documentation ====================================================== 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 12 filtered, 0 badness; has taken 0.3 s =======================================================
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2
rust-current_platform+default-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0 badness; has taken 0.1 s
Source checksums ---------------- https://crates.io/api/v1/crates/current_platform/0.2.0/download#/current_pla... : CHECKSUM(SHA256) this package : a74858bcfe44b22016cb49337d7b6f04618c58e5dbfdef61b06b8c434324a0bc CHECKSUM(SHA256) upstream package : a74858bcfe44b22016cb49337d7b6f04618c58e5dbfdef61b06b8c434324a0bc
Requires -------- rust-current_platform-devel (rpmlib, GLIBC filtered): cargo rust
rust-current_platform+default-devel (rpmlib, GLIBC filtered): cargo crate(current_platform)
Provides -------- rust-current_platform-devel: crate(current_platform) rust-current_platform-devel
rust-current_platform+default-devel: crate(current_platform/default) rust-current_platform+default-devel
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2298528 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, Haskell, Java, SugarActivity, Ocaml, Python, C/C++, R, fonts, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2298528
--- Comment #2 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-current_platform
https://bugzilla.redhat.com/show_bug.cgi?id=2298528
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-53d5ee0f7c (rust-current_platform-0.2.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-53d5ee0f7c
https://bugzilla.redhat.com/show_bug.cgi?id=2298528
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-07-18 15:21:29
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-53d5ee0f7c (rust-current_platform-0.2.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com