Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: jettison - A JSON StAX implementation
https://bugzilla.redhat.com/show_bug.cgi?id=508521
Summary: Review Request: jettison - A JSON StAX implementation Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sm@sandro-mathys.ch QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://red.fedorapeople.org/SRPMS/jettison.spec SRPM URL: http://red.fedorapeople.org/SRPMS/jettison-1.1-1.fc11.src.rpm Description: Jettison is a collection of Java APIs (like STaX and DOM) which read and write JSON. This allows nearly transparent enablement of JSON based web services in services frameworks like CXF or XML serialization
rpmlint on spec, srpm and noarch-rpms finishes checking without any warnings or errors.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lkundrak@v3.sk AssignedTo|nobody@fedoraproject.org |lkundrak@v3.sk Flag| |fedora-review+
--- Comment #1 from Lubomir Rintel lkundrak@v3.sk 2009-11-01 05:30:23 EDT --- Good, work; nice and clean!
1.) I suggest you use a %{version} macro here, to ease updates: jar -cf jettison-1.1.jar -C target .
Full review:
* spec file legible, uses american english * source matches upstream * packages latest version * rpmlint silent * builds fine in mock (scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1780920) * license ok, listed in %doc * javadoc built, conforming to guidelines * no prebuilt stuff * filelists sane * macros used consistently
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
Sandro Mathys sm@sandro-mathys.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Sandro Mathys sm@sandro-mathys.ch 2009-11-02 02:59:13 EDT --- Hi Lubomir, thanks for the review :) Glad to see there's nothing to complain about :) will replace jettison-1.1 with %{name}-%{version} in the mentioned line before I push the pkg.
New Package CVS Request ======================= Package Name: jettison Short Description: A JSON StAX implementation Owners: red Branches: F-11 F-12 EL-4 EL-5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-11-02 23:34:41 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
--- Comment #4 from Fedora Update System updates@fedoraproject.org 2009-11-03 02:26:55 EDT --- jettison-1.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/jettison-1.1-1.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2009-11-03 02:27:57 EDT --- jettison-1.1-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/jettison-1.1-1.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
--- Comment #6 from Sandro Mathys sm@sandro-mathys.ch 2009-11-03 02:32:08 EDT --- Building for EL-4 didn't work (probably a problem with the Java version) and F-12 currently doesn't accept updates except through requesting manual tagging.
Will update this as the one or the other gets fixed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2009-11-04 07:24:32 EDT --- jettison-1.1-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jettison'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10967
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-11-05 16:27:04 EDT --- jettison-1.1-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jettison'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0793
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-11-23 11:54:49 EDT --- jettison-1.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |1.1-1.el5 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |F13FeatureIDEA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-11-24 03:00:04 EDT --- jettison-1.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|1.1-1.el5 |1.1-1.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508521
--- Comment #11 from Sandro Mathys sm@sandro-mathys.ch 2009-12-09 10:43:53 EDT --- Won't build an EL-4 version due to lack of interest in maintaining it with java 1.5 (i.e. gcj). If someone else in the future wants to co-maintain this for EL-4 feel free to contact me.
package-review@lists.fedoraproject.org