Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-lockfile - Ruby library for creating NFS safe lockfiles
https://bugzilla.redhat.com/show_bug.cgi?id=598980
Summary: Review Request: rubygem-lockfile - Ruby library for creating NFS safe lockfiles Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sgupta@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile-1.4.3-... Description: Its a Ruby library for creating NFS safe lockfiles. rlock creates NFS resistant lockfiles.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
Shreyank Gupta sgupta@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sgupta@redhat.com Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
--- Comment #1 from Shreyank Gupta sgupta@redhat.com 2010-06-02 09:38:40 EDT --- Koji Scratch Build -------------------
http://koji.fedoraproject.org/koji/taskinfo?taskID=2225105
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
--- Comment #2 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-06-03 04:27:02 EDT --- (Removing NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-06-04 14:33:36 EDT --- For -1:
* License (tag) - Please include the following file as SOURCE1 (with full URL), install the file under %geminstdir, mark the file as %doc and include in main package.
http://codeforpeople.com/lib/license.txt
- When the license is "the same as Ruby", we use "GPLv2 or Ruby" (not v2+) for license tag in the spec file.
* bin/ directory -------------------------------------------------------------- $ rlock /usr/bin/rlock:19:in `load': no such file to load -- /usr/lib/ruby/gems/1.8/gems/lockfile-1.4.3/bin/rlock (LoadError) from /usr/bin/rlock:19 -------------------------------------------------------------- - %{geminstdir}/bin directory must not be removed and should be in main package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
Shreyank Gupta shreyankg@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shreyankg@gmail.com
--- Comment #4 from Shreyank Gupta shreyankg@gmail.com 2010-06-07 07:05:57 EDT --- Updated: --------
Spec URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile-1.4.3-...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-06-07 12:05:39 EDT --- One issue
- When using "cp" or "install" command for files, please add "-p" option to keep timestamps on installed files. https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
Please fix the above when importing this package into Fedora.
------------------------------------------------------------------ This package (rubygem-lockfile) is APPROVED by mtasaka ------------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
Shreyank Gupta shreyankg@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Shreyank Gupta shreyankg@gmail.com 2010-06-07 13:01:25 EDT --- Thanks for the review, I'll update the specfile and SRPMs tomorrow. Meanwhile ..
New Package CVS Request ======================= Package Name: rubygem-lockfile Short Description: Ruby library for creating NFS safe lockfiles Owners: shreyankg Branches: F-13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
--- Comment #7 from Kevin Fenzi kevin@tummy.com 2010-06-07 17:09:54 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
--- Comment #8 from Shreyank Gupta shreyankg@gmail.com 2010-06-08 05:28:21 EDT --- Updated: --------
Spec URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile-1.4.3-...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
--- Comment #9 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-06-08 05:51:25 EDT --- Well, I have not checked your new spec in detail, however - "install" command usually sets the permission of the file to be installed to "0755" instead of "0644". Please check if "license.txt" has 0644 permission.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
--- Comment #10 from Shreyank Gupta shreyankg@gmail.com 2010-06-08 06:03:45 EDT --- Sorry! Thanks for pointing that out:
Updated: --------
Spec URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile-1.4.3-...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
--- Comment #11 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-06-08 06:09:19 EDT --- Seems okay. Please import.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-06-08 06:30:46 EDT --- rubygem-lockfile-1.4.3-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-lockfile-1.4.3-4.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
Shreyank Gupta shreyankg@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |601641
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
Shreyank Gupta shreyankg@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |601633
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-06-08 15:29:29 EDT --- rubygem-lockfile-1.4.3-4.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-lockfile'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rubygem-lockfile-1.4.3-4.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-06-10 15:21:57 EDT --- rubygem-lockfile-1.4.3-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598980
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |rubygem-lockfile-1.4.3-4.fc | |13 Resolution| |ERRATA
package-review@lists.fedoraproject.org