[Bug 2259838] New: Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

Bug ID: 2259838
           Summary: Review Request: checkpointctl - a tool for analysis of
                    container checkpoints
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://github.com/rst0git/checkpointctl-rpm/blob/main/checkpointctl.spec
SRPM URL:
https://github.com/rst0git/checkpointctl-rpm/raw/main/checkpointctl-1.1.0-1....
Description: A command-line tool for in-depth analysis of container checkpoints
Fedora Account System Username: rstoyanov

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |%{git0}

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6942756
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

Radostin Stoyanov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

Spec URL:
https://raw.githubusercontent.com/rst0git/checkpointctl-rpm/main/checkpointc...
SRPM URL:
https://github.com/rst0git/checkpointctl-rpm/raw/main/checkpointctl-1.1.0-3....
Description: A command-line tool for in-depth analysis of container checkpoints
Fedora Account System Username: rstoyanov

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #2 from Radostin Stoyanov  ---
Spec URL:
https://raw.githubusercontent.com/rst0git/checkpointctl-rpm/main/checkpointc...
SRPM URL:
https://github.com/rst0git/checkpointctl-rpm/raw/main/checkpointctl-1.1.0-3....
Description: A command-line tool for in-depth analysis of container checkpoints
Fedora Account System Username: rstoyanov

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #3 from Fedora Review Service  ---
Created attachment 2010060
  --> https://bugzilla.redhat.com/attachment.cgi?id=2010060&action=edit
The .spec file difference from Copr build 6942756 to 6945515

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #4 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6945515
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

Adrian Reber  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #5 from Adrian Reber  ---
The review tool complains about "[!]: Uses parallel make %{?_smp_mflags}
macro.". It does not make much sense for a Go package but you could still add
"%{?_smp_mflags}" after make.

You could also add a "%check" section and run the test suite.

I am not sure about the `with_debug` logic. Is that needed?

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #6 from Adrian Reber  ---
You should also install the auto-completion files.

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #7 from Radostin Stoyanov  ---
Spec URL:
https://raw.githubusercontent.com/rst0git/checkpointctl-rpm/main/checkpointc...
SRPM URL:
https://github.com/rst0git/checkpointctl-rpm/raw/main/checkpointctl-1.1.0-5....
Description: A command-line tool for in-depth analysis of container checkpoints
Fedora Account System Username: rstoyanov

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #8 from Fedora Review Service  ---
Created attachment 2010744
  --> https://bugzilla.redhat.com/attachment.cgi?id=2010744&action=edit
The .spec file difference from Copr build 6945515 to 6964190

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #9 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6964190
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

Adrian Reber  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #10 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/checkpointctl

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

--- Comment #11 from Fedora Update System  ---
FEDORA-2024-0d67ae4669 has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0d67ae4669

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2024-01-29 11:49:12

--- Comment #12 from Fedora Update System  ---
FEDORA-2024-0d67ae4669 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #13 from Fedora Update System  ---
FEDORA-2024-4f3d8b7775 (checkpointctl-1.1.0-1.fc39) has been submitted as an
update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f3d8b7775

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #14 from Fedora Update System  ---
FEDORA-2024-cff378ace4 (checkpointctl-1.1.0-1.fc38) has been submitted as an
update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-cff378ace4

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #15 from Fedora Update System  ---
FEDORA-EPEL-2024-8e51f8ba56 (checkpointctl-1.1.0-1.el9) has been submitted as
an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-8e51f8ba56

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #16 from Fedora Update System  ---
FEDORA-2024-4f3d8b7775 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-4f3d8b7775 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f3d8b7775

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #17 from Fedora Update System  ---
FEDORA-EPEL-2024-8e51f8ba56 has been pushed to the Fedora EPEL 9 testing
repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-8e51f8ba56

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #18 from Fedora Update System  ---
FEDORA-2024-cff378ace4 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-cff378ace4 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-cff378ace4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #19 from Fedora Update System  ---
FEDORA-EPEL-2024-8e51f8ba56 (checkpointctl-1.1.0-1.el9) has been pushed to the
Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #20 from Fedora Update System  ---
FEDORA-2024-4f3d8b7775 (checkpointctl-1.1.0-1.fc39) has been pushed to the
Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #21 from Fedora Update System  ---
FEDORA-2024-cff378ace4 (checkpointctl-1.1.0-1.fc38) has been pushed to the
Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #22 from Fedora Update System  ---
FEDORA-2025-5c1d116fa3 (checkpointctl-1.4.0-1.fc44) has been submitted as an
update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-5c1d116fa3

[Bug 2259838] Review Request: checkpointctl - a tool for analysis of container checkpoints

https://bugzilla.redhat.com/show_bug.cgi?id=2259838

--- Comment #23 from Fedora Update System  ---
FEDORA-2025-5c1d116fa3 (checkpointctl-1.4.0-1.fc44) has been pushed to the
Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.