[Bug 2313237] New: Review Request: rust-x509-parser - Parser for the X.509 v3 format (RFC 5280 certificates)
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
Bug ID: 2313237 Summary: Review Request: rust-x509-parser - Parser for the X.509 v3 format (RFC 5280 certificates) Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-x509-parser/rust-x509-parser.s... SRPM URL: https://dcavalca.fedorapeople.org/review/rust-x509-parser/rust-x509-parser-0...
Description: Parser for the X.509 v3 format (RFC 5280 certificates).
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2312640
--- Comment #1 from Davide Cavalca davide@cavalca.name --- $ cat rust2rpm.toml [tests] run = ["none"] comments = ["Tests fail to build due to missing artifacts"]
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2312640 [Bug 2312640] Review Request: rust-oid-registry - Object Identifier (OID) database
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/x5 | |09-parser
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8030619 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tfanelli@redhat.com
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- *** Bug 2332216 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2330124
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2330124 [Bug 2330124] Review Request: rust-oid-registry - Object Identifier (OID) database
https://bugzilla.redhat.com/show_bug.cgi?id=2313237 Bug 2313237 depends on bug 2312640, which changed state.
Bug 2312640 Summary: Review Request: rust-oid-registry - Object Identifier (OID) database https://bugzilla.redhat.com/show_bug.cgi?id=2312640
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2312638 (rust-der-parser)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2312638 [Bug 2312638] Review Request: rust-der-parser - Parser/encoder for ASN.1 BER/DER data
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
--- Comment #4 from Davide Cavalca davide@cavalca.name --- Spec URL: https://dcavalca.fedorapeople.org/review/rust-x509-parser/rust-x509-parser.s... SRPM URL: https://dcavalca.fedorapeople.org/review/rust-x509-parser/rust-x509-parser-0...
Changelog: - regenerate with rust2rpm 27
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8481939 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2313237 Bug 2313237 depends on bug 2312638, which changed state.
Bug 2312638 Summary: Review Request: rust-der-parser - Parser/encoder for ASN.1 BER/DER data https://bugzilla.redhat.com/show_bug.cgi?id=2312638
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
--- Comment #7 from Davide Cavalca davide@cavalca.name --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8491609 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #9 from Fabio Valentini decathorpe@gmail.com --- Package looks almost good to me.
The package.include setting in Cargo.toml is very strange though: I'm quite sure that `.gitignore` and `.travis.yml` should just be dropped from that list. `Cargo.toml` is always included in published crates, so there's no need to list it explicitly.
And I'm a bit confused why the tests fail with missing files, when there's a lot of stuff in "assets" that *does* look like test data. Are the paths in test code just wrong?
Can the "assets" directory be excluded from packaged files, if it's indeed just test input files?
https://bugzilla.redhat.com/show_bug.cgi?id=2313237
--- Comment #10 from Tyler Fanelli tfanelli@redhat.com --- Polite ping -- is there any update here? This dependency is preventing me from packaging one of my projects.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com