https://bugzilla.redhat.com/show_bug.cgi?id=2325318
Bug ID: 2325318 Summary: Review Request: aqute-bnd-epel - BND Tool Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/aqute-bnd-epel.spec SRPM URL: https://salimma.fedorapeople.org/aqute-bnd-epel-6.3.1-11.1.fc41.src.rpm
Description: The bnd tool helps you create and diagnose OSGi bundles. The key functions are: - Show the manifest and JAR contents of a bundle - Wrap a JAR so that it becomes a bundle - Create a Bundle from a specification and a class path - Verify the validity of the manifest entries The tool is capable of acting as: - Command line tool - File format - Directives - Use of macros
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2325318
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1914423 (EPELPackagersSIG), | |2325258
--- Comment #1 from Michel Lind michel@michel-slm.name --- *** Bug 2325259 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1914423 [Bug 1914423] Tracker for epel-packagers-sig https://bugzilla.redhat.com/show_bug.cgi?id=2325258 [Bug 2325258] Please branch and build google-gson in epel10
https://bugzilla.redhat.com/show_bug.cgi?id=2325318
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://bnd.bndtools.org/
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8244153 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local Read more: https://fedoraproject.org/wiki/Packaging:Java - No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - No javadoc subpackage present Read more: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2325318
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2325260 Doc Type|--- |If docs needed, set a value
--- Comment #3 from Michel Lind michel@michel-slm.name --- COPR build: https://copr.fedorainfracloud.org/coprs/salimma/antlr4-el10/build/8244161/
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2325260 [Bug 2325260] Please branch and build maven-mapping in epel10
https://bugzilla.redhat.com/show_bug.cgi?id=2325318
--- Comment #4 from Michel Lind michel@michel-slm.name --- Diff from c10s spec
https://paste.centos.org/view/9dc4275e
https://bugzilla.redhat.com/show_bug.cgi?id=2325318
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Status|NEW |POST Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Packaging looks reasonable for an EPEL fork with a subset of packages * Licensing is correctly handled * Package builds and installs * No serious issues from rpmlint
FYI: In the future, attach diffs to the bug rather than linking to paste.centos.org, since pastes expire after a single day.
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2325318
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #6 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/aqute-bnd-epel
https://bugzilla.redhat.com/show_bug.cgi?id=2325318 Bug 2325318 depends on bug 2325260, which changed state.
Bug 2325260 Summary: Please branch and build maven-mapping in epel10 https://bugzilla.redhat.com/show_bug.cgi?id=2325260
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2325318
Zenon Panoussis redhatbugs@provocation.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |redhatbugs@provocation.net
--- Comment #7 from Zenon Panoussis redhatbugs@provocation.net --- # mock -r alma+epel-10-x86_64 aqute-bnd-epel-6.3.1-11.1.fc41.src.rpm
works fine, but
# mock -r alma+epel-10-x86_64 --define "with bnd_maven_plugin" aqute-bnd-epel-6.3.1-11.1.fc41.src.rpm
ends with
warning: /builddir/build/SPECS/aqute-bnd-epel.spec: line 44: unexpected argument to non-parametric macro %with error: bare words are no longer supported, please use "...": bnd_maven_plugin error: ^ error: /builddir/build/SPECS/aqute-bnd-epel.spec:44: bad %if condition: bnd_maven_plugin
Line 44 is: %if %{with bnd_maven_plugin}. Changing it to %if 0%{?_with_bnd_maven_plugin} solves the problem at line 44 and runs into the next on line 80, so this seems to confirm the solution.
A separate problem when all the bare words have been fixed, occurs during the build:
[ERROR] UndeclaredThrowableException: InvocationTargetException: Plugin org.apache.maven.plugins:maven-source-plugin:3.2.1 or one of its dependencies could not be resolved: [ERROR] Cannot access central (https://repo.maven.apache.org/maven2) in offline mode and the artifact org.apache.maven.plugins:maven-source-plugin:jar:3.2.1 has not been downloaded from it before.
Indeed, maven-source-plugin was not pulled in, despite mvn(org.apache.maven.plugins:maven-source-plugin) being part of the conditional BuildRequires. So there's still something wrong with those %if macros.
https://bugzilla.redhat.com/show_bug.cgi?id=2325318
--- Comment #8 from Zenon Panoussis redhatbugs@provocation.net --- On line 44 of the spec, none of the following triggers the conditional BuildRequires to pull in maven-source-plugin:
%if %{with "bnd_maven_plugin"} %if ( %{with bnd_maven_plugin} ) %if %{?_with_bnd_maven_plugin} %if %{?_with_bnd_maven_plugin:1} %if 0%{?_with_bnd_maven_plugin:1}
Some of them bail out already on rpmbuild -bs, others pass the rpmbuild lint but fail to actually do what is expected of them during build. This is really a serious lapse in the documentation of "bare words are no longer supported" (and chronically in the documentation of rpm macros in general), much more than a bug in this particular package.
Whatever the correct syntax eventually turns out to be, it should work for all current epel versions and their respective versions of rpm. Which, I suspect and fear, might require a rethinking of how and when changes are introduced to rpm itself.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com