[Bug 2328685] New: Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

Bug ID: 2328685
           Summary: Review Request: rust-pipeline - Macro collection to
                    pipe |> your functions calls, like in F# or Elixir
           Product: Fedora
           Version: rawhide
               URL: https://github.com/johannhof/pipeline.rs
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://petersen.fedorapeople.org/reviews/rust-pipeline/rust-pipeline.spec
SRPM URL:
https://petersen.fedorapeople.org/reviews/rust-pipeline/rust-pipeline-0.5.0-...

Description:
A macro collection to pipe |> your functions calls, like in F# or
Elixir.

Fedora Account System Username: petersen

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=126247844

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8311245
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- License file LICENSE is not marked as %license
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

--- Comment #2 from Jens Petersen  ---
Spec URL:
https://petersen.fedorapeople.org/reviews/rust-pipeline/rust-pipeline.spec
SRPM URL:
https://petersen.fedorapeople.org/reviews/rust-pipeline/rust-pipeline-0.5.0-...

- sync with rust2rpm

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

--- Comment #3 from Fedora Review Service  ---
Created attachment 2059736
  --> https://bugzilla.redhat.com/attachment.cgi?id=2059736&action=edit
The .spec file difference from Copr build 8311245 to 8311269

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged

--- Comment #4 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8311269
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]

--- Comment #5 from Fabio Valentini  ---
Package looks good to me. One minor thing and one general question:

- Can you regenerate the spec with rust2rpm v27? It looks like you made no
modifications on top of what's generated, so that should be easy, I hope :)

- What are you packaging this crate for? It's ancient (last release in 2015,
almost 10 years ago), and it raises a lot of compiler warnings on build. It's
not a blocker for getting it reviewed, but whatever depends on this crate on
might want to stop using it (or not) :)

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

--- Comment #6 from Jens Petersen  ---
Good points:

(In reply to Fabio Valentini from comment #5)
> Package looks good to me.

Thanks for looking at it
> Can you regenerate the spec with rust2rpm v27? It looks like you made no
>
> modifications on top of what's generated, so that should be easy, I hope :)

Sure thing, will do
> What are you packaging this crate for? It's ancient (last release in 2015,
>
> almost 10 years ago), and it raises a lot of compiler warnings on build.
> It's not a blocker for getting it reviewed, but whatever depends on this
> crate on might want to stop using it (or not) :)

elan -> markdown -> pipeline (hope I got that right:)

I was also naively surprised markdown is not in fedora (I suppose one could
call that a package smell, giggle?).
Maybe I should suggest an alternative to upstream??
I forget why it even needs markdown support...

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

--- Comment #7 from Jens Petersen  ---
(An new major version of elan came out in January btw, which feels slightly
like a lost op)

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

--- Comment #8 from Jens Petersen  ---
Spec URL:
https://petersen.fedorapeople.org/reviews/rust-pipeline/rust-pipeline.spec
SRPM URL:
https://petersen.fedorapeople.org/reviews/rust-pipeline/rust-pipeline-0.5.0-...

- rust2rpm 27

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

--- Comment #9 from Fedora Review Service  ---
Created attachment 2078858
  --> https://bugzilla.redhat.com/attachment.cgi?id=2078858&action=edit
The .spec file difference from Copr build 8311269 to 8723079

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

--- Comment #10 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8723079
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

Ben Beasley  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Ben Beasley  ---
Notes on the ancient/unmaintained status of this crate:

The last release was nine years ago, and the crate appears unmaintained
upstream. However, it is a legitimate dependency for the current *stable*
release (0.3.0) of the markdown crate, which itself is in kind of a weird
state: 0.3.0 was released over four years ago, then a total rewrite started
with a new primary maintainer, with alpha releases steadily trickling out over
the past two years or so. Some projects now depend on alpha versions of
markdown, and some depend on stable 0.3.0, and effectively these are two
different crates sharing a name and an identity on crates.io. Under these
circumstances, packaging rust-pipeline seems to make sense. It is at least
simple enough that it should not be too troublesome to maintain without
upstream support. Hopefully it can be dropped if the markdown rewrite ever
reaches the point where it makes a stable release, and upstream projects
can be encouraged to update their dependencies.

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST

--- Comment #12 from Fabio Valentini  ---
Thank you - the package looks good to me, even though the code itself looks
rather dusty :)

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |RELEASE_PENDING

--- Comment #13 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-pipeline

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

--- Comment #14 from Jens Petersen  ---
Thank you for the review, Fabio!

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |MODIFIED

--- Comment #15 from Fedora Update System  ---
FEDORA-2025-d4966963cf (rust-pipeline-0.5.0-1.fc43) has been submitted as an
update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d4966963cf

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |rust-pipeline-0.5.0-1.fc43

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(code@musicinmybra
                   |                            |in.net)

--- Comment #16 from Jens Petersen  ---
@[e-mail] thank you very much for the detailed explanation -
very helpful!

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(code@musicinmybra |
                   |in.net)                     |

[Bug 2328685] Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir

https://bugzilla.redhat.com/show_bug.cgi?id=2328685

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2025-03-12 11:47:55

--- Comment #17 from Fedora Update System  ---
FEDORA-2025-d4966963cf (rust-pipeline-0.5.0-1.fc43) has been pushed to the
Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.