Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197292
Summary: Review Request: perl-Contextual-Return Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: cweyl@alumni.drew.edu QAContact: fedora-package-review@redhat.com
Spec URL: http://home.comcast.net/~ckweyl/perl-Contextual-Return.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-Contextual-Return-v0.1.0-0.fc5.src.rpm
Description: This module allows you to define return values of a perl sub which are appropriate given the calling context.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Contextual-Return
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197292
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |tibbs@math.uh.edu OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Contextual-Return
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197292
------- Additional Comments From tibbs@math.uh.edu 2006-06-29 20:23 EST ------- Note that BuildRequires: perl is not required, and BuildRequires: perl(Test::More) is doubly redundant as it is part of the base Perl package.
For some reason this package provides perl(Carp) and perl(DB), probably because the dependency generator finds "package Carp" and "package DB" somewhere in the package. You will need to filter these.
Some tests are skipped due to missing modules. You should add BR: perl(Test::Pod) and perl(Test::Pod::Coverage) for better test coverage.
Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: 2651c1c521ad4b42e0efbeac664fade6 Contextual-Return-v0.1.0.tar.gz * latest version is being packaged. O BuildRequires are proper (perl and perl(Test::More) are unnecessary) * package builds in mock (development, x86_64). * rpmlint is silent. X final provides and requires are sane: X perl(Carp) perl(Contextual::Return) perl(Contextual::Return::Failure) perl(Contextual::Return::Lvalue) perl(Contextual::Return::Value) X perl(DB) perl-Contextual-Return = v0.1.0-0.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Contextual::Return) perl(Scalar::Util) perl(Want) perl(overload) perl(strict) perl(version) perl(warnings) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. X %check is present and all tests pass, but some are skipped due to missing modules which are present in the distro: All tests successful, 2 tests skipped. Files=17, Tests=180, 1 wallclock secs ( 0.62 cusr + 0.21 csys = 0.83 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Contextual-Return
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197292
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |197304 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Contextual-Return
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197292
------- Additional Comments From cweyl@alumni.drew.edu 2006-06-29 21:08 EST ------- Spec URL: http://home.comcast.net/~ckweyl/perl-Contextual-Return.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-Contextual-Return-v0.1.0-0.1.fc5.src.rp...
Updated BR, added provides filter.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Contextual-Return
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197292
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-07-03 13:11 EST ------- All tests now pass with none skipped: All tests successful. Files=17, Tests=184, 1 wallclock secs ( 0.75 cusr + 0.28 csys = 1.03 CPU)
The provides are OK now: perl(Contextual::Return) perl(Contextual::Return::Failure) perl(Contextual::Return::Lvalue) perl(Contextual::Return::Value) perl-Contextual-Return = v0.1.0-0.1.fc6
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Contextual-Return
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197292
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From cweyl@alumni.drew.edu 2006-07-03 13:56 EST ------- Imported and building for devel -- will build for FC-4, FC-5 after branching.
Thanks!
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla