Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: jjack - JACK audio driver for the Java Sound API
https://bugzilla.redhat.com/show_bug.cgi?id=491579
Summary: Review Request: jjack - JACK audio driver for the Java Sound API Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: oget.fedora@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://oget.fedorapeople.org/review/jjack.spec SRPM URL: http://oget.fedorapeople.org/review/jjack-0.3-1.fc10.src.rpm Description: JJack is a JACK audio driver for the Java Sound API and a framework for the Java programming language that allows Java applications to use the JACK Audio Connection Kit. Audio processor clients can be designed to:
* create their own sounds (as a synthesizer or sample-player) * change the sound-output of other clients (e.g. as an effects-device) * analyse the audio streams generated by other clients (e.g. display the wave form)
rpmlint is silent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
Orcan 'oget' Ogetbil oget.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |492203
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
Mattias Ellert mattias.ellert@fysast.uu.se changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mattias.ellert@fysast.uu.se Flag| |fedora-review+
--- Comment #1 from Mattias Ellert mattias.ellert@fysast.uu.se 2009-04-26 07:38:12 EDT --- Fedora review jjack-0.3-1.fc10.src.rpm 2009-04-26
rpmlint:
4 packages and 1 specfiles checked; 0 errors, 0 warnings.
* Package is named according to guidelines
* Specfile is named after the package
* The package follows the guidelines for a java package using JNI
* License is Fedora approved: LGPLv2+
* The License tags in the sources only says LGPL without version. According to the https://fedoraproject.org/wiki/Licensing page LGPL without version is equivalent to LGPLv2+. ("Note that this is LGPLv2+, not LGPL+, because version 2 was the first version of LGPL.") The version number in the LICENSE file itself is not relevant for (L)GPL.
* The LICENSE file is packaged as %doc
* Specfile is written in legible English
* Sources matches upstream to the extent possible (differences are documented):
$ diff -ur SRPM/jjack-0.3 jjack-0.3 Only in jjack-0.3/doc/www: mp3 Only in SRPM/jjack-0.3/doc/www: ogg
* Package compiles in mock (Fedora 10)
* BuildRequires are sane
* Package owns directories it creates
* No duplicate files
* Permissions are sane and %files has %defattr
* %clean clears buildroot
* Macros are used consistently
* Documentation is in javadoc subpackage
* %doc is not runtime essential
* Package does not own other's directories
* %install clears buildroot
* Installed files are valid UTF-8
One small suggestion: The wrapper script passes its arguments on as
$1 $2 $3 $4 $5
It is probably better to instead do
"$@"
(including the quotes). This will work better in cases where there are empty arguments ("") or quoted arguments containing spaces, subtleties that now get lost.
Package approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
Orcan 'oget' Ogetbil oget.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Orcan 'oget' Ogetbil oget.fedora@gmail.com 2009-04-26 11:10:44 EDT --- Thanks a lot, I will update the script.
New Package CVS Request ======================= Package Name: jjack Short Description: JACK audio driver for the Java Sound API Owners: oget Branches: F-9 F-10 F-11 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-04-27 01:21:38 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
--- Comment #4 from Fedora Update System updates@fedoraproject.org 2009-04-27 04:00:02 EDT --- jjack-0.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/jjack-0.3-2.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2009-04-27 04:01:31 EDT --- jjack-0.3-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/jjack-0.3-2.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2009-04-27 04:02:31 EDT --- jjack-0.3-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/jjack-0.3-2.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
Orcan 'oget' Ogetbil oget.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #7 from Orcan 'oget' Ogetbil oget.fedora@gmail.com 2009-04-27 14:44:08 EDT --- Package imported and built. Closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-04-27 17:31:52 EDT --- jjack-0.3-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |0.3-2.fc10 Resolution|RAWHIDE |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-04-27 17:37:14 EDT --- jjack-0.3-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.3-2.fc10 |0.3-2.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-05-08 23:58:50 EDT --- jjack-0.3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491579
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.3-2.fc9 |0.3-2.fc11
package-review@lists.fedoraproject.org