[Bug 253588] New: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation - package-review

List overview All Threads
Download

newer

[Bug 253588] New: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

older

[Bug 434703] New: Review Request:...

[Bug 433129] New: Review Request:...

Red Hat Bugzilla

20 Aug 2007 20 Aug '07

11:43 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253588

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rjones@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://annexia.org/tmp/ocaml/ocaml-cil.spec SRPM URL: http://annexia.org/tmp/ocaml/ocaml-cil-1.3.6-2.fc8.src.rpm Description: CIL (C Intermediate Language) is a high-level representation along with a set of tools that permit easy analysis and source-to-source transformation of C programs.

CIL is both lower-level than abstract-syntax trees, by clarifying ambiguous constructs and removing redundant ones, and also higher-level than typical intermediate languages designed for compilation, by maintaining types and a close relationship with the source program. The main advantage of CIL is that it compiles all valid C programs into a few core constructs with a very clean semantics. Also CIL has a syntax-directed type system that makes it easy to analyze and manipulate C programs. Furthermore, the CIL front-end is able to process not only ANSI-C programs but also those using Microsoft C or GNU C extensions. If you do not use CIL and want instead to use just a C parser and analyze programs expressed as abstract-syntax trees then your analysis will have to handle a lot of ugly corners of the language (let alone the fact that parsing C itself is not a trivial task).

In essence, CIL is a highly-structured, "clean" subset of C. CIL features a reduced number of syntactic and conceptual forms. For example, all looping constructs are reduced to a single form, all function bodies are given explicit return statements, syntactic sugar like "->" is eliminated and function arguments with array types become pointers.

-- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by thread

Red Hat Bugzilla

16 Sep 16 Sep

9:31 a.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

michel.sylvan@gmail.com changed:

------- Additional Comments From michel.sylvan@gmail.com 2007-09-16 00:01 EST ------- Will review this

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

18 Sep 18 Sep

2:03 a.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

tkuratom@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED

------- Additional Comments From tkuratom@redhat.com 2007-09-17 16:33 EST ------- Testing BZ problem

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2:05 a.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

a.badger@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |michel.sylvan@gmail.com

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

22 Sep 22 Sep

4:25 a.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

------- Additional Comments From michel.sylvan@gmail.com 2007-09-21 18:55 EST ------- Here's the initial review. Most things are fine, with apart from the problems noted below. I've built it on my Rawhide x86_64 box a few days ago, but currently it does not build in mock:

- F7 does not have ocaml-findlib{,-devel}: http://koji.fedoraproject.org/koji/taskinfo?taskID=169938

Building against Rawhide on Koji failed mysteriously, trying against dist-f8 now, but it looked like a build server problem anyway.

Documentation should probably be split into -doc, as it pertains the use of cilly as well, and introduces the infrastructure in general. Your call.

Oh, and perl(CilConfig) should provide a version number!

MUST FAILED: • clean buildroot before install: no • rpmlint ocaml-cil.src:66: W: unversioned-explicit-provides perl(CilConfig)

• build dependencies complete: : can't build on FC7, no ocaml-findlib* • -doc: might want to create separate -doc, since it also contains documentation on cilly

PASSED:

• package name: hmm. it produces a tool that is useful for programming in C, so in a way it's an application written in OCaml, but to customize it you need to write in OCaml, so it's an OCaml lib. probably OK as it is • spec file name: matches • package guideline-compliant: yes • license complies with guidelines: yes • license field accurate: yes • license file not deleted: yes • spec in US English: yes • spec legible: yes • source matches upstream: yes • builds under >= 1 archs, others excluded • own all directories: yes • no dupes in %files: yes • permission: yes • %clean must clean RPM_BUILD_ROOT: yes • macros used consistently: yes • must contain code: yes • headers in -devel: yes • devel must require versioned base package: yes • filenames UTF-8

SHOULD FAILED: • package build in mock on all architectures

PASSED: • package functioned as described: yes • scriplets are sane: yes • other subpackages should require versioned base: yes • require package, not files: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:40 a.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

------- Additional Comments From michel.sylvan@gmail.com 2007-09-21 19:10 EST ------- Build on Koji failed for F8 as well. It builds fine for i386, x86_64 has not finished, but you need to exclude PPC as well: http://koji.fedoraproject.org/koji/taskinfo?taskID=169952

Also note that URL has changed to http://cil.sourceforge.net/

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

5 Nov 5 Nov

8:34 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

------- Additional Comments From michel.sylvan@gmail.com 2007-11-05 10:04 EST ------- ping

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

6 Nov 6 Nov

5:48 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

------- Additional Comments From rjones@redhat.com 2007-11-06 07:18 EST ------- Hi yes, still here, and will get around to this RSN!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7 Nov 7 Nov

9:54 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

------- Additional Comments From rjones@redhat.com 2007-11-07 11:24 EST ------- I'm unclear from Koji what the actual error was on PPC. (Unfortunately I don't have access to an actual PPC to test).

You said 'clean buildroot before install', but I think I'm doing that. However I moved the commands around to make that clear.

Spec: http://www.annexia.org/tmp/ocaml/ocaml-cil.spec SRPM: http://www.annexia.org/tmp/ocaml/ocaml-cil-1.3.6-3.fc8.src.rpm

+* Wed Nov 7 2007 Richard W.M. Jones rjones@redhat.com - 1.3.6-3 +- Change upstream URL. +- perl(CilConfig) set to package version +- Split out documentation into a separate -doc package. +

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

13 Nov 13 Nov

1:35 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

------- Additional Comments From michel.sylvan@gmail.com 2007-11-13 03:05 EST ------- Didn't notice the update -- sorry. Will get back to it before this weekend.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

16 Nov 16 Nov

10:52 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

------- Additional Comments From michel.sylvan@gmail.com 2007-11-16 12:22 EST ------- You need to excludeArch ppc as well: http://koji.fedoraproject.org/koji/taskinfo?taskID=244937

(might want to bug the upstream developers about Linux/ppc support, since the ppc target is supported for OS X)

Completed build: http://koji.fedoraproject.org/koji/taskinfo?taskID=244948

Question: does ocaml-cil work without the .ml and .o files? From the packaging guidelines (http://fedoraproject.org/wiki/Packaging/OCaml):

*.o files are not normally included. There is however one exception -- if file is needed for link (like gtkInit.cmx and gtkInit.o in lablgtk or std_exit.cmx and std_exit.o in OCaml itself), then it should be included.

*.ml files are not normally included. The exception is if the file describes a module signature and there is no corresponding .mli file, then the .ml file should be included. (Note that Debian is more permissive and they often distribute *.ml files, allowing the programmer to peek at the implementation of a module).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

13 Jan 13 Jan

11:49 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

bugzilla@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide

michel.sylvan@gmail.com changed:

------- Additional Comments From michel.sylvan@gmail.com 2008-01-13 13:19 EST ------- Richard, any chance you could update the package soon? Thanks.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

15 Jan 15 Jan

3:13 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

rjones@redhat.com changed:

------- Additional Comments From rjones@redhat.com 2008-01-15 04:43 EST ------- Probably won't be this week, but it's still on my list ...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12 Feb 12 Feb

6:09 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

------- Additional Comments From rjones@redhat.com 2008-02-12 07:39 EST ------- This is the updated package:

Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-cil.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-cil-1.3.6-4.fc8.src.rpm

* Wed Nov 7 2007 Richard W.M. Jones rjones@redhat.com - 1.3.6-4 - ExcludeArch ppc - CIL doesn't build on PPC as it turns out.

The *.ml files are required. We can't strip cilly.byte.exe because strip will remove the bytecode from the file.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

29 Feb 29 Feb

2:48 a.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

michel.sylvan@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From michel.sylvan@gmail.com 2008-02-28 16:18 EST ------- Builds on i386 and x86_64; rpmlint output is clean, apart from the *.ml and cilly.byte.exe file that's been discussed.

Looks good -- APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2:56 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

rjones@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From rjones@redhat.com 2008-02-29 04:26 EST ------- New Package CVS Request ======================= Package Name: ocaml-cil Short Description: CIL - Infrastructure for C Program Analysis and Transformation Owners: rjones Branches: F-8 InitialCC: rjones Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:34 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-02-29 12:04 EST ------- cvs done.

Please make sure to file a bug and block bug 239077 for the ppc build issues.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1 Mar 1 Mar

6:10 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

------- Additional Comments From rjones@redhat.com 2008-03-01 07:40 EST ------- I added two new bugs in fact, because bug 239077 was unrelated to the reason for the ExcludeArch.

ppc: bug 435546 ppc64: bug 435545

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

6:58 p.m.

New subject: [Bug 253588] Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-cil - CIL - Infrastructure for C Program Analysis and Transformation

https://bugzilla.redhat.com/show_bug.cgi?id=253588

rjones@redhat.com changed:

------- Additional Comments From rjones@redhat.com 2008-03-01 08:28 EST ------- F-8: http://koji.fedoraproject.org/koji/taskinfo?taskID=481892 devel: http://koji.fedoraproject.org/koji/taskinfo?taskID=481885

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

6352

Age (days ago)

6546

Last active (days ago)

package-review@lists.fedoraproject.org

18 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla