[Bug 592628] New: Review Request: key-mon - Utility to show live keyboard and mouse status
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: key-mon - Utility to show live keyboard and mouse status
https://bugzilla.redhat.com/show_bug.cgi?id=592628
Summary: Review Request: key-mon - Utility to show live keyboard and mouse status Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kushaldas@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://kushaldas.in/tmp/key-mon.spec SRPM URL: http://kushaldas.in/tmp/key-mon-0.15-1.fc13.src.rpm Description: Utility to show live keyboard and mouse status for teaching and screencasts.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592628
--- Comment #1 from Kushal Das kushaldas@gmail.com 2010-05-15 15:46:48 EDT --- Forgot to add patch0 URL: http://kushaldas.in/tmp/su.patch
Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2190240
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592628
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |metherid@gmail.com AssignedTo|nobody@fedoraproject.org |metherid@gmail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592628
--- Comment #2 from Rahul Sundaram metherid@gmail.com 2010-05-29 04:51:39 EDT ---
You can drop the following: - python macro definition on top - Buildroot definition - no need to clean the buildroot in install section - clean section
The su patch requires a comment as per
http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_a...
You could run sed in a loop
License status is unclear. Source files don't have a proper license attribution and does not specify the version. LGPL also requires that you include a copy of the license along with the source. Please contact upstream and ask them to fix these issues.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592628
Moritz Barsnick moritz@barsnick.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |moritz@barsnick.net
--- Comment #3 from Moritz Barsnick moritz@barsnick.net 2010-06-28 16:35:06 EDT --- In the meantime, 1.2.2 has been released. It uses Xlib to track the keys (which actually pics up the correct ones when multiple displays are active, unlike the hardcoded device before), so more need for beesu. Some other Requires (pygtk2?) need to be added though.
The license seems to be ASL 2.0 now (COPYING is provided).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592628
--- Comment #4 from Moritz Barsnick moritz@barsnick.net 2010-06-28 16:37:10 EDT --- Created an attachment (id=427507) --> (https://bugzilla.redhat.com/attachment.cgi?id=427507) proposed changes to initially provided SPEC file
This patch shows most of the potential changes to accommodate for key-mon-1.2.2, and also puts the requested loop around sed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592628
Moritz Barsnick moritz@barsnick.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #427507|0 |1 is obsolete| |
--- Comment #5 from Moritz Barsnick moritz@barsnick.net 2010-06-28 16:40:22 EDT --- Created an attachment (id=427508) --> (https://bugzilla.redhat.com/attachment.cgi?id=427508) proposed changes to initially provided SPEC file
Oops, previous patch was against wrong old SPEC. :) This one should be correct.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592628
Moritz Barsnick moritz@barsnick.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #427508|0 |1 is obsolete| |
--- Comment #6 from Moritz Barsnick moritz@barsnick.net 2010-06-29 10:12:28 EDT --- Created an attachment (id=427695) --> (https://bugzilla.redhat.com/attachment.cgi?id=427695) latest version of proposed changes to initially provided SPEC file
Some fixes to the previous SPEC update suggestions: - fix the sed loop to use both variants of the shebang - add Requires: python-xlib - add some comments
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592628
Golo Fuchert packages@golotop.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |packages@golotop.de
--- Comment #7 from Golo Fuchert packages@golotop.de 2010-10-22 18:58:18 EDT --- I get the following from rpmlint on the rpm:
key-mon.noarch: E: explicit-lib-dependency python-xlib key-mon.noarch: W: spelling-error %description -l en_US screencasts -> screen casts, screen-casts, screenplays key-mon.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/keymon/config.py 0644L /usr/bin/env key-mon.noarch: W: no-manual-page-for-binary key-mon 1 packages and 0 specfiles checked; 2 errors, 2 warnings.
Have you tried building the package without the "Requires: python-xlib"? Concerning the non-executable-script error: I just took a quick look into the file and it looks like a module. Then the shebang should be unnecessary and should be removed. You made a comment on this in the SPEC file that it is skipped for some reasons, however, if I add it to the list in "for file in ..." it works fine here. I think you should fix those or comment on them at least.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592628
Marc-Andre Lureau marcandre.lureau@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #427695|0 |1 is obsolete| |
--- Comment #8 from Marc-Andre Lureau marcandre.lureau@redhat.com 2011-06-03 09:30:58 EDT --- Created attachment 502810 --> https://bugzilla.redhat.com/attachment.cgi?id=502810 updated spec
$ rpmlint key-mon key-mon.noarch: W: no-manual-page-for-binary key-mon 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint key-mon.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla