https://bugzilla.redhat.com/show_bug.cgi?id=1242727
Bug ID: 1242727 Summary: Review Request: perl-MooX-Roles-Pluggable - Moo eXtension for pluggable roles Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: TicoTimo@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-... SRPM URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-... Description: This module allows a class consuming several roles based on rules passed to Module::Pluggable::Object. Fedora Account System Username: ttorling
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10338401
copr: https://copr.fedoraproject.org/coprs/ttorling/perl-meta-cpan-support/monitor...
This is the fourth of four new packages to support meta-cpan (https://github.com/rehsack/meta-cpan) and Packager::Utils (https://github.com/rehsack/Packager-Utils) for Fedora.
I am in need of a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |psabata@redhat.com Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
--- Comment #1 from Petr Šabata psabata@redhat.com --- Based on my feedback from the other two reviews, try to fix this package first. I would just repeat myself and it will be a good exercise for you :)
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
--- Comment #2 from Tim Orling TicoTimo@gmail.com --- Spec URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-...
SRPM URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-...
Git URL: https://fedorapeople.org/cgit/ttorling/public_git/perl-MooX-Roles-Pluggable....
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10613754
copr: https://copr.fedoraproject.org/coprs/ttorling/perl-meta-cpan-support/build/1...
It appears Module::Pluggable, Moo, Moo::Role are not in EPEL6 It appears Moo and Moo::Role are not in EPEL7
Many dependencies for Moo in EPEL7 are not met: http://koji.fedoraproject.org/koji/taskinfo?taskID=10613995
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
--- Comment #3 from Petr Šabata psabata@redhat.com --- (In reply to Tim Orling from comment #2)
It appears Module::Pluggable, Moo, Moo::Role are not in EPEL6 It appears Moo and Moo::Role are not in EPEL7
Many dependencies for Moo in EPEL7 are not met: http://koji.fedoraproject.org/koji/taskinfo?taskID=10613995
I'll consider this Fedora only then.
* Unless you plan to package Moo for EL7, you may use EU::MM 6.76+ NO_PACKLIST feature, available in all stable Fedoras:
BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
If you do this, you won't need to remove .packlist files in %install. This will also allow you to drop the dependencies on coreutils and findutils.
* Missing a build deps -- perl(lib), from t/01-basic.t:10 and t/02-fatal.t:10, and perl(Module::Pluggable::Object) from lib/MooX/Roles/Pluggable.pm:7.
That seems to be all. Good! :)
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
--- Comment #4 from Tim Orling TicoTimo@gmail.com --- Spec URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-...
SRPM URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-...
Git URL: https://fedorapeople.org/cgit/ttorling/public_git/perl-MooX-Roles-Pluggable....
koji: rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10680276 f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=10680278 f22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10680280 f21: http://koji.fedoraproject.org/koji/taskinfo?taskID=10680282
Thank you for reviewing for Fedora only, that was what was intended.
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Petr Šabata psabata@redhat.com --- Okay, looks fine now. Approving.
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
Tim Orling TicoTimo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Tim Orling TicoTimo@gmail.com --- New Package SCM Request ======================= Package Name: perl-MooX-Roles-Pluggable Short Description: Moo eXtension for pluggable roles Upstream URL: http://search.cpan.org/dist/MooX-Roles-Pluggable/ Owners: ttorling psabata Branches: f21 f22 f23 InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- perl-MooX-Roles-Pluggable-0.003-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-MooX-Roles-Pluggable-0.003-3.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-MooX-Roles-Pluggable-0.003-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/perl-MooX-Roles-Pluggable-0.003-3.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-MooX-Roles-Pluggable-0.003-3.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/perl-MooX-Roles-Pluggable-0.003-3.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-MooX-Roles-Pluggable-0.003-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2015-10-16 02:58:18
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-MooX-Roles-Pluggable-0.003-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1242727
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- perl-MooX-Roles-Pluggable-0.003-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org