[Bug 196793] New: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

Summary: Review Request: php-pear-MDB2 - PEAR: Database
                    Abstraction Layer
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-MDB2.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-MDB2-2.1.0-1.src.rpm

Description:
PEAR::MDB2 is a merge of the PEAR::DB and Metabase php database abstraction
layers.

It provides a common API for all supported RDBMS. The main difference to most
other DB abstraction packages is that MDB2 goes much further to ensure
portability.

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |196823
              nThis|                            |

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |php-pear-MDB2

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |190101
              nThis|                            |

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|196823                      |
              nThis|                            |

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-06-28 22:15 EST -------
MUST ITEMS:
+ No rpmlint output
+ name OK
+ meets packaging guidelines
+ BSD license, not included
+ spec in legible American English
+ source matches upstream
fc452e0e48c2ad67ca8e0af41c462535  MDB2-2.1.0.tgz
+ builds on FC5 i386
+ appropriate BuildRequires
+ no locales
+ no shared libraries
+ not relocatable
+ does not create directories
+ no duplicate %files
+ OK permissions
+ OK %clean section
+ consistent macros
+ OK code / content
+ no large documentation
+ benign %docs
+ no header files or static libraries
+ no pkgconfig
+ no .so libraries
+ no devel package
+ no .la files
+ no GUI
+ does not share files or directories with others

SHOULD:
- does NOT include license from upstream

Approved, IMHO, though including a BSD license would be nice :)  Also, I can't
officially change the status to FE-ACCEPT, somebody else will have to do that.

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-06-28 22:18 EST -------
I asked tibbs to look into sponsering you last night, I'll nudge him again
tonight and see if he can get you to approve this package for me.

Thanks for the review!

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-06-28 22:21 EST -------
Likewise!

One last thing I forgot to mention, %build is empty, and should probably just be
removed altogether... but not a showstopper

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-06-29 02:34 EST -------
I have updated the spec file to remove the %build, the only reference to a
license I could find was on http://pear.php.net/package/MDB2 which just links to
a license template.  I could not find any reference to an actual license at the
packages external home page http://oss.backendmedia.com/index.php?area=MDB2

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-06-29 02:40 EST -------
ah nevermind, the license is at the top of the source files, so it is already
included in every file.  I can cut&paste one of these text files for the license.

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-06-29 02:53 EST -------
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-MDB2.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-MDB2-2.1.0-2.src.rpm

%changelog
* Wed Jun 28 2006 Christopher Stone  2.1.0-2
- Remove %%build section since it is not used
- Add LICENSE to %%doc

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-06-29 03:26 EST -------
Hey, I have put up another version here:
http://tkmame.retrogames.com/fedora-extras/php-pear-MDB2.spec

The main difference is that it puts the documentation in both the Fedora
standard location AND the pear standard location.

The result is a much cleaner looking spec file, tell me what you think.

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-06-29 04:53 EST -------
I can't access the specfile URL at the moment to check, but note that especially
if this is not a noarch package, removing the %build section (even if it's
empty) is not a good idea, see bug 192422.  Even if it is noarch, I'd recommend
keeping it to avoid similar nasty surprises in the future.

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-06-29 05:06 EST -------
It's noarch

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |196802

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |197974
              nThis|                            |

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

Bug 196793 depends on bug 196802, which changed state.

Bug 196802 Summary: 16M memory needs to be set in pear/pecl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196802

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |ERRATA
             Status|MODIFIED                    |CLOSED

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|197974                      |
              nThis|                            |

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-09-03 21:05 EST -------
Update SPEC file and SRPM to match latest template

SPEC: http://tkmame.retrogames.com/fedora-extras/php-pear-MDB2.spec
SRPM: http://tkmame.retrogames.com/fedora-extras/php-pear-MDB2-2.1.0-4.src.rpm

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-09-04 13:11 EST -------
rpmlint is ok.
build in mock succed.

should not you upgrade to latest upstream version (2.2.2 stable) before release it ?

Requires php version is 4.3.2.

I think i could(will) do the review for you.

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-09-04 16:51 EST -------
Yes you are correct, I need to upgrade to 2.2.2

There are still a couple little things being ironed out on the template php
spec, see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198706

I'll do an upgrade in the next day or two with these changes for you to formally
review.  Then we can get php-pear-Log out.

Discussions on Fedora packaging mailing list led to the agreement that if the
package requires a php version of < 5.x then it's not needed because no
supported Fedora distributions use a php version older than this.

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-09-06 14:02 EST -------
SPEC: http://tkmame.retrogames.com/fedora-extras/php-pear-MDB2.spec
SRPM: http://tkmame.retrogames.com/fedora-extras/php-pear-MDB2-2.2.2-1.src.rpm

%changelog
* Wed Sep 06 2006 Christopher Stone  2.2.2-1
- Upstream sync
- Update spec to latest template

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-09-06 16:22 EST -------
Can't assign this bug to myself for the moment.
Will do the review ASAP.

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

------- Additional Comments From [e-mail]  2006-09-06 17:44 EST -------
Build and install fine on FC5.
rpmlint is ok.
previous version build in mock (mock broken for me on this moment).
all MUST items are OK.
Great job done on this template.

I also though "including a BSD license would be nice :)" but i never find one
good copy.

APPROVED.

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

[Bug 196793] Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - PEAR: Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 196793] Review Request: php-pear-MDB2 - Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: php-pear-   |Review Request: php-pear-
                   |MDB2 - PEAR: Database       |MDB2 - Database Abstraction
                   |Abstraction Layer           |Layer
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-04-23 20:22 EST -------
Branch Package CVS Request
=======================
Package Name: php-pear-MDB2
Short Description: Database Abstraction Layer
Owners: [e-mail]
Branches: EL-5
InitialCC:

[Bug 196793] Review Request: php-pear-MDB2 - Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 196793] Review Request: php-pear-MDB2 - Database Abstraction Layer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-MDB2 - Database Abstraction Layer
Alias: php-pear-MDB2

https://bugzilla.redhat.com/show_bug.cgi?id=196793

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide