[Bug 1344410] New: Review Request: hoedown - Standards compliant, fast, secure markdown processing library in C

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344410

            Bug ID: 1344410
           Summary: Review Request: hoedown - Standards compliant, fast,
                    secure markdown processing library in C
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: ignatenko(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/hoedown.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/hoedown-3.0.7-1.fc24.s...
Description:
Hoedown is a revived fork of Sundown, the Markdown parser based on the original
code of the Upskirt library by Natacha Porté. Features:
* Fully standards compliant
* Massive extension support
* UTF-8 aware
* Tested & Ready to be used on production
* Customizable renderers
* Optimized for speed
* Zero-dependency
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1344410] Review Request: hoedown - Standards compliant, fast, secure markdown processing library in C

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344410

Igor Gnatenko <ignatenko(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |hoedown



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1344410] Review Request: hoedown - Standards compliant, fast, secure markdown processing library in C

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344410

Igor Gnatenko <ignatenko(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |915043




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=915043
[Bug 915043] Package rust (lang)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1344410] Review Request: hoedown - Standards compliant, fast, secure markdown processing library in C

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344410



--- Comment #1 from Josh Stone <jistone(a)redhat.com&gt; ---
Preliminary review:

- Shouldn't the library go in a separate subpackage?  The executables won't be
needed for library users.  I'd expect one of these layouts:
  - hoedown, hoedown-libs, hoedown-devel
  - hoedown, libhoedown, libhoedown-devel

- The library needs %post/%postun ldconfig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1344410] Review Request: hoedown - Standards compliant, fast, secure markdown processing library in C

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344410



--- Comment #2 from Igor Gnatenko <ignatenko(a)redhat.com&gt; ---
(In reply to Josh Stone from comment #1)
>  Preliminary review:
>  
>  - Shouldn't the library go in a separate subpackage?  The executables won't
>  be needed for library users.  I'd expect one of these layouts:
>    - hoedown, hoedown-libs, hoedown-devel
>    - hoedown, libhoedown, libhoedown-devel 
hm, there is only 2 binaries with small
size. is it worth to make libs
subpackage?
>  
>  - The library needs %post/%postun ldconfig 
ah yes, forgot about it. Will add it.

Anything else to fix?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1344410] Review Request: hoedown - Standards compliant, fast, secure markdown processing library in C

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344410



--- Comment #3 from Josh Stone <jistone(a)redhat.com&gt; ---
>  hm, there is only 2 binaries with small size. is it worth to make
> libs subpackage? 
I can't find official guidelines on this, but I prefer to avoid installing
things in /bin unnecessarily.  If most people will be using this in library
form, as with rustdoc, then they don't need the binaries.

You can take python for precedent -- its main binary is even smaller than
these.

>  Anything else to fix? 
Not that I see.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1344410] Review Request: hoedown - Standards compliant, fast, secure markdown processing library in C

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344410



--- Comment #4 from Igor Gnatenko <ignatenko(a)redhat.com&gt; ---
(In reply to Josh Stone from comment #3)
>  > hm, there is only 2 binaries with small size. is it worth to
> make libs subpackage?
>  
>  I can't find official guidelines on this, but I prefer to avoid installing
>  things in /bin unnecessarily.  If most people will be using this in library
>  form, as with rustdoc, then they don't need the binaries. 
There are no
guidelines about that, it's up to maintainer if he wants to have
libs subpkg. I will make it.
>  
>  You can take python for precedent -- its main binary is even smaller than
>  these.
>  
>  > Anything else to fix?
>  
>  Not that I see. 
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1344410] Review Request: hoedown - Standards compliant, fast, secure markdown processing library in C

https://bugzilla.redhat.com/show_bug.cgi?id=1344410

Igor Gnatenko <i.gnatenko.brain(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |WONTFIX
        Last Closed|                            |2018-08-22 03:30:29



--- Comment #5 from Igor Gnatenko <i.gnatenko.brain(a)gmail.com&gt; ---
Unfortunately I don't have time to work on these review requests anymore,
sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component