[Bug 196847] New: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression
                    testing framework for unit tests
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-PHPUnit2.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-PHPUnit2-2.3.6-1.src.rpm

Description:
PHPUnit is a family of PEAR packages (PHPUnit2 for PHP 5, PHPUnit for PHP 4)
that supports the development of object-oriented PHP applications using the
concepts and methods of Agile Software Development, Extreme Programming,
Test-Driven Development and Design-by-Contract Development by providing an
elegant and robust framework for the creation, execution and analysis of
Unit Tests.

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |196843

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |php-pear-PHPUnit2

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |190101, 196749

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |196802

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

Bug 196847 depends on bug 196802, which changed state.

Bug 196802 Summary: 16M memory needs to be set in pear/pecl
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196802

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |ERRATA
             Status|MODIFIED                    |CLOSED

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

------- Additional Comments From [e-mail]  2006-08-31 04:57 EST -------
Created an attachment (id=135268)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=135268&action=vie...)
logfile from rpmbuild

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2006-08-31 04:58 EST -------
grant me some questions: why it is necessary to build these package as root? and
why is the install method through rpm, instead of using pear?

ok, the way by rpm is even ok and it is possibly better way to avoid obsolete
files in the filesystem. but the build of that package is only possible as root.

attached is a logfile of the buildprocess, unfortunatelly it did not build.

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|197974                      |
              nThis|                            |

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2006-09-02 04:22 EST -------
Daniel, Build failed because you didn't use the latest php-pear (1.4.9-1.2 on
fc5) with /etc/rpm/macros.pear.

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

Bug 196847 depends on bug 196749, which changed state.

Bug 196749 Summary: Review Request: php-pecl-xdebug - PECL package for debugging PHP scripts
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196749

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

Bug 196847 depends on bug 190101, which changed state.

Bug 190101 Summary: Review Request: php-pear-Log
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190101

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

Bug 196847 depends on bug 196843, which changed state.

Bug 196843 Summary: Review Request: php-pear-Benchmark - PEAR: Framework to benchmark PHP scripts or function calls
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196843

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-09-09 20:36 EST -------
I'll go ahead and review this one, but I'll leave the other version of this
package alone because frankly I don't think it's a terribly good idea to include
multiple versions in the same repository in that manner.  It's up to you how you
do version upgrades; if the new version is that much better or more useful and
isn't unstable then I'd just upgrade to it immediately.

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

------- Additional Comments From [e-mail]  2006-09-09 20:42 EST -------
please review the alpha version if you are just going to review one.  This one
is not important to me, the alpha version one I need in FE.

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-09-11 15:25 EST -------
I'm going to go ahead and approve this.  If you want to update to the alpha
version, or someone else wants to approve the -alpha package, then that's fine
with me.

* source files match upstream:
   95fe5e8dbb36462dd4d3f3daf8a4e8b3  PHPUnit2-2.3.6.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text is included in each source file.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent (except for the bogus warning)
* final provides and requires are sane:
   php-pear(PHPUnit2) = 2.3.6
   php-pear-PHPUnit2 = 2.3.6-1.fc6
  =
   /bin/sh
   /usr/bin/pear
   /usr/bin/php
   php >= 5.0.2
   php-pear(Benchmark)
   php-pear(Log)
   php-pear(PEAR)
   php-pecl(Xdebug)
* %check is not present; not possible to run the test suite.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/show_bug.cgi?id=196847

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide