[Bug 2076023] New: Review Request: rust-cargo-manifest - Helper crate to parse and manipulate manifests

https://bugzilla.redhat.com/show_bug.cgi?id=2076023

Bug ID: 2076023
           Summary: Review Request: rust-cargo-manifest - Helper crate to
                    parse and manipulate manifests
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://raw.githubusercontent.com/Laiot/rust-cargo-manifest-rpm/master/rust-...
SRPM URL:
https://github.com/Laiot/rust-cargo-manifest-rpm/raw/master/rust-cargo-manif...
Description: Helper crate to parse and manipulate manifests 
Fedora Account System Username: laiot

[Bug 2076023] Review Request: rust-cargo-manifest - Helper crate to parse and manipulate manifests

https://bugzilla.redhat.com/show_bug.cgi?id=2076023

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Fabio Valentini  ---
Please modify the Summary in the spec file.
Markdown markup is useless in there, it is only ever rendered as plain text.
For example:

Summary:        Helper crate to parse and manipulate Cargo.toml files

Other than that:

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable
for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

I'm curious what you need this crate for?

[Bug 2076023] Review Request: rust-cargo-manifest - Helper crate to parse and manipulate manifests

https://bugzilla.redhat.com/show_bug.cgi?id=2076023

--- Comment #2 from Carmelo Sarta  ---
Hi Fabio, thank you for all your reviews!
I needed this package for a sub-package of Bevy called bevy-macro-utils (
https://crates.io/crates/bevy_macro_utils )

[Bug 2076023] Review Request: rust-cargo-manifest - Helper crate to parse and manipulate manifests

https://bugzilla.redhat.com/show_bug.cgi?id=2076023

--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-cargo-manifest

[Bug 2076023] Review Request: rust-cargo-manifest - Helper crate to parse and manipulate manifests

https://bugzilla.redhat.com/show_bug.cgi?id=2076023

--- Comment #4 from Fabio Valentini  ---
Oh, so you're packaging Bevy? What for? :)

[Bug 2076023] Review Request: rust-cargo-manifest - Helper crate to parse and manipulate manifests

https://bugzilla.redhat.com/show_bug.cgi?id=2076023

Carmelo Sarta  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |RAWHIDE
             Status|POST                        |CLOSED
        Last Closed|                            |2022-05-05 13:51:48