https://bugzilla.redhat.com/show_bug.cgi?id=1644268
Bug ID: 1644268 Summary: Review Request: mythes-eo - Esperanto thesaurus Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: carmen@carmenbianca.eu QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://www.carmenbianca.eu/mythes-eo.spec SRPM URL: https://www.carmenbianca.eu/mythes-eo-0.20180330-1.fc29.src.rpm Description: Esperanto thesaurus Fedora Account System Username: carmenbianca
This is my first package, and I am seeking a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
Carmen Bianca Bakker carmen@carmenbianca.eu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
--- Comment #1 from Carmen Bianca Bakker carmen@carmenbianca.eu --- I have a working Koji build here: https://koji.fedoraproject.org/koji/taskinfo?taskID=30559258
Took a little while to figure out how to work that.
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
--- Comment #2 from Carmen Bianca Bakker carmen@carmenbianca.eu --- I discovered that the source package also includes a hyphen file. I've taken the liberty to also create a package for that.
Spec URL: https://www.carmenbianca.eu/hyphen-eo.spec SRPM URL: https://www.carmenbianca.eu/hyphen-eo-0.20180330-1.fc29.src.rpm
I'm thinking it might make much more sense to condense the both of them into a single package, though, given that they share the same upstream. But I wouldn't know how to call the parent package, or how to do that plumbing.
Ought I create a separate bug report for the hyphen package?
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
--- Comment #3 from Carmen Bianca Bakker carmen@carmenbianca.eu --- Figured out the plumbing. This package created a `hyphen-eo` RPM and `mythes-eo` RPM without creating its own `super-eo` RPM.
Spec URL: https://www.carmenbianca.eu/super-eo.spec SRPM URL: https://www.carmenbianca.eu/super-eo-0.20180330-1.fc29.src.rpm Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=30573131
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
Artur Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl
--- Comment #4 from Artur Iwicki fedora@svgames.pl ---
pushd $RPM_BUILD_ROOT/%{_datadir}/hyphen/ pushd $RPM_BUILD_ROOT/%{_datadir}/mythes/
Not needed.
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
--- Comment #5 from Carmen Bianca Bakker carmenbianca@fedoraproject.org --- (In reply to Artur Iwicki from comment #4)
pushd $RPM_BUILD_ROOT/%{_datadir}/hyphen/ pushd $RPM_BUILD_ROOT/%{_datadir}/mythes/
Not needed.
Agreed. I copied those by using other hyphen/mythes packages as template.
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
--- Comment #6 from Parag AN(पराग) panemade@gmail.com --- I will suggest use the mythes-eo as a package name instead of super-eo.
Remove following lines from spec file pushd $RPM_BUILD_ROOT/%{_datadir}/hyphen/ pushd $RPM_BUILD_ROOT/%{_datadir}/mythes/
The license-en.txt contains text "or later" hence its GPLv3+ license tag.
Do you have any other package submitted for package review as well? To get sponsored you need to show your packaging skills either by submitting few packages and/or doing un-official package reviews of other people's submitted packages. See https://da.gd/o4gt for more information
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |carmenbianca@fedoraproject. | |org Flags| |needinfo?(carmenbianca@fedo | |raproject.org)
--- Comment #7 from Parag AN(पराग) panemade@gmail.com --- Any updates here?
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
--- Comment #8 from Carmen Bianca Bakker carmenbianca@fedoraproject.org --- No updates yet due to a lack of time. I've been travelling. I should have more dispensible time now.
For clarity: I am not per se looking to become a general Fedora maintainer. I basically just want to get this super low-maintenance package into Fedora, and maintain it as need be.
As for renaming the package to mythes-eo: That will make hyphen-eo a subpackage of mythes-eo and thus explicitly depend on mythes-eo's dependencies, which is not desirable. The best course of action then would be to maintain two separate packages, but that would be a little silly for a single upstream.
The package, as it's currently written, doesn't actually end up creating a super-eo package---only the two subpackages.
I'll soon submit two other (Python) packages I want to maintain, though.
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|panemade@gmail.com |nobody@fedoraproject.org Flags|fedora-review? | |needinfo?(carmenbianca@fedo | |raproject.org) |
--- Comment #9 from Parag AN(पराग) panemade@gmail.com --- Thanks for your quick reply.
I will drop myself from this review but if you need any help with this package review do write here.
About you point (In reply to Carmen Bianca Bakker from comment #8)
As for renaming the package to mythes-eo: That will make hyphen-eo a subpackage of mythes-eo and thus explicitly depend on mythes-eo's dependencies, which is not desirable. The best course of action then would be to maintain two separate packages, but that would be a little silly for a single upstream.
No that will not happen that way. e.g. See https://src.fedoraproject.org/rpms/hunspell-be/raw/master/f/hunspell-be.spec file. Do you think hyphen-be explicitly depend on hunspell-be's dependencies? No it will not.
Just See, $ rpm -q --requires hunspell-be hunspell $ rpm -q --requires hyphen-be hyphen
Try installing hyphen-be only, I don't see hunspell will get installed.
Dependencies resolved. =============================================================================== Package Arch Version Repository Size =============================================================================== Installing: hyphen-be noarch 1.1-16.fc29 fedora 11 k Installing dependencies: hyphen x86_64 2.8.8-10.fc29 fedora 29 k
Transaction Summary =============================================================================== Install 2 Packages
Total size: 40 k Installed size: 62 k Downloading Packages: [SKIPPED] hyphen-2.8.8-10.fc29.x86_64.rpm: Already downloaded [SKIPPED] hyphen-be-1.1-16.fc29.noarch.rpm: Already downloaded Running transaction check Transaction check succeeded. Running transaction test Transaction test succeeded. Running transaction Preparing : 1/1 Installed: hyphen-2.8.8-10.fc29.x86_64 Installing : hyphen-2.8.8-10.fc29.x86_64 1/2 Running scriptlet: hyphen-2.8.8-10.fc29.x86_64 1/2 Installed: hyphen-2.8.8-10.fc29.x86_64 Installed: hyphen-be-1.1-16.fc29.noarch Installing : hyphen-be-1.1-16.fc29.noarch 2/2 Installed: hyphen-be-1.1-16.fc29.noarch Running scriptlet: hyphen-be-1.1-16.fc29.noarch 2/2 Verifying : hyphen-2.8.8-10.fc29.x86_64 1/2 Verifying : hyphen-be-1.1-16.fc29.noarch 2/2
Installed: hyphen-be-1.1-16.fc29.noarch hyphen-2.8.8-10.fc29.x86_64
The package, as it's currently written, doesn't actually end up creating a super-eo package---only the two subpackages.
Yes. I can see that. As there is no %files section so main package named super-eo is not getting generated but only the subpackages binary rpms.
But I cannot find link/relation between the super-eo package name with mythes-eo or hyphen-eo packages.
Maybe some other Sponsor want to accept such super-eo package....
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
--- Comment #10 from Carmen Bianca Bakker carmenbianca@fedoraproject.org --- (In reply to Parag AN(पराग) from comment #9)
No that will not happen that way. e.g. See https://src.fedoraproject.org/rpms/hunspell-be/raw/master/f/hunspell-be.spec file. Do you think hyphen-be explicitly depend on hunspell-be's dependencies? No it will not.
Ah, erroneous assumption on my behalf then.
I've taken the suggestions and created a new package:
https://www.carmenbianca.eu/mythes-eo.spec https://www.carmenbianca.eu/mythes-eo-0.20180330-2.fc29.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
--- Comment #11 from Carmen Bianca Bakker carmenbianca@fedoraproject.org --- Created another package at bug 1653010
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com