Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Term-Completion - Read one line of user input, with convenience functions Alias: perl-Term-Completion
https://bugzilla.redhat.com/show_bug.cgi?id=498703
Summary: Review Request: perl-Term-Completion - Read one line of user input, with convenience functions Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/Term-Completion OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Term-Completion.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Term-Completion-0.91-1.fc10.src.r...
Description: Term::Completion is an extensible, highly configurable replacement for the venerable Term::Complete package. It is object-oriented and thus allows subclassing. Two derived classes are Term::Completion::Multi and Term::Completion::Path. A prompt is printed and the user may enter one line of input, submitting the answer by pressing the ENTER key.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1332443
*rt-0.10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498703
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |484485
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498703
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498703
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-05-03 11:48:35 EDT --- Review: + package builds in mock (rawhide i586). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1332443 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 6f5920facb98b20923559f57608bb6ef Term-Completion-0.91.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs Files=9, Tests=100, 1 wallclock secs ( 0.09 usr 0.02 sys + 0.70 cusr 0.08 csys = 0.89 CPU)
+ Package perl-Term-Completion-0.91-1.fc12.noarch => Provides: perl(Term::Completion) = 0.91 perl(Term::Completion::Multi) = 0.90 perl(Term::Completion::Path) = 0.90 perl(Term::Completion::_POSIX) perl(Term::Completion::_readkey) perl(Term::Completion::_stty) perl(Term::Completion::_termsize) Requires: perl(Carp) perl(Exporter) perl(File::Spec) perl(IO::Handle) perl(POSIX) perl(Term::ReadKey) perl(base) perl(strict) perl(warnings)
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498703
--- Comment #2 from Chris Weyl cweyl@alumni.drew.edu 2009-05-03 14:31:28 EDT --- New Package CVS Request ======================= Package Name: perl-Term-Completion Short Description: Read one line of user input, with convenience functions Owners: cweyl Branches: F-9 F-10 F-11 devel InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498703
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498703
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-05-03 23:52:16 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498703
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #4 from Chris Weyl cweyl@alumni.drew.edu 2009-05-04 18:43:32 EDT --- Thanks for the review! :-)
package-review@lists.fedoraproject.org