https://bugzilla.redhat.com/show_bug.cgi?id=1917625
Bug ID: 1917625 Summary: Review Request: volk - The Vector Optimized Library of Kernels Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jskarvad@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jskarvad.fedorapeople.org/volk/volk.spec SRPM URL: https://jskarvad.fedorapeople.org/volk/volk-2.4.1-1.fc32.src.rpm Description: VOLK is the Vector-Optimized Library of Kernels. It is a library that contains kernels of hand-written SIMD code for different mathematical operations. Since each SIMD architecture can be very different and no compiler has yet come along to handle vectorization properly or highly efficiently, VOLK approaches the problem differently. VOLK is a sub-project of GNU Radio. Fedora Account System Username: jskarvad
It's dependency for bug 1917167.
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://jskarvad.fedorapeople.org/volk/volk.spec SRPM URL: https://jskarvad.fedorapeople.org/volk/volk-2.4.1-1.fc32.src.rpm Description: VOLK is the Vector-Optimized Library of Kernels. It is a library that contains kernels of hand-written SIMD code for different mathematical operations. Since each SIMD architecture can be very different and no compiler has yet come along to handle vectorization properly or highly efficiently, VOLK approaches the problem differently. VOLK is a sub-project of GNU Radio. Fedora Account System Username: jskarvad
It's dependency for bug 1917167.
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
Jan Žerdík jzerdik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jzerdik@redhat.com Assignee|nobody@fedoraproject.org |jzerdik@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
--- Comment #1 from Jan Žerdík jzerdik@redhat.com --- Rpmlint ------- Checking: volk-2.4.1-1.fc34.x86_64.rpm volk-devel-2.4.1-1.fc34.x86_64.rpm volk-doc-2.4.1-1.fc34.noarch.rpm volk-debuginfo-2.4.1-1.fc34.x86_64.rpm volk-debugsource-2.4.1-1.fc34.x86_64.rpm volk-2.4.1-1.fc34.src.rpm volk.x86_64: W: spelling-error %description -l en_US vectorization -> factorization, categorization, motorization volk.x86_64: E: non-executable-script /usr/lib64/python3.9/site-packages/volk_modtool/__init__.py 644 /usr/bin/env python volk.x86_64: E: non-executable-script /usr/lib64/python3.9/site-packages/volk_modtool/cfg.py 644 /usr/bin/env python volk.x86_64: W: no-manual-page-for-binary list_cpu_features volk.x86_64: W: no-manual-page-for-binary volk-config-info volk.x86_64: W: no-manual-page-for-binary volk_modtool volk.x86_64: W: no-manual-page-for-binary volk_profile volk-devel.x86_64: W: no-documentation volk.src: W: spelling-error %description -l en_US vectorization -> factorization, categorization, motorization 6 packages and 0 specfiles checked; 2 errors, 7 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
--- Comment #2 from Jan Žerdík jzerdik@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 - Missing dash on second line of changelog (typo)?
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later", "*No copyright* Apache License 2.0", "Apache License 2.0", "BSD 2-clause "Simplified" License", "Expat License GNU General Public License v3.0 or later", "zlib/libpng license GNU General Public License v3.0 or later", "GNU Lesser General Public License, Version 2.1". 113 files have unknown license. Detailed output of licensecheck in /home/jzerdik/1917625-volk/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/python3.9/site- packages/volk_modtool(python3-gnuradio), /usr/lib64/python3.9/site- packages/volk_modtool/__pycache__(python3-gnuradio), /usr/include/volk(gnuradio-devel), /usr/include/volk/asm(gnuradio- devel), /usr/include/volk/asm/neon(gnuradio-devel), /usr/include/volk/asm/orc(gnuradio-devel), /usr/lib64/cmake/volk(gnuradio-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in volk- devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: volk-2.4.1-1.fc34.x86_64.rpm volk-devel-2.4.1-1.fc34.x86_64.rpm volk-doc-2.4.1-1.fc34.noarch.rpm volk-debuginfo-2.4.1-1.fc34.x86_64.rpm volk-debugsource-2.4.1-1.fc34.x86_64.rpm volk-2.4.1-1.fc34.src.rpm volk.x86_64: W: spelling-error %description -l en_US vectorization -> factorization, categorization, motorization volk.x86_64: E: non-executable-script /usr/lib64/python3.9/site-packages/volk_modtool/__init__.py 644 /usr/bin/env python volk.x86_64: E: non-executable-script /usr/lib64/python3.9/site-packages/volk_modtool/cfg.py 644 /usr/bin/env python volk.x86_64: W: no-manual-page-for-binary list_cpu_features volk.x86_64: W: no-manual-page-for-binary volk-config-info volk.x86_64: W: no-manual-page-for-binary volk_modtool volk.x86_64: W: no-manual-page-for-binary volk_profile volk-devel.x86_64: W: no-documentation volk.src: W: spelling-error %description -l en_US vectorization -> factorization, categorization, motorization 6 packages and 0 specfiles checked; 2 errors, 7 warnings.
Rpmlint (debuginfo) ------------------- Checking: volk-debuginfo-2.4.1-1.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- volk-devel.x86_64: W: no-documentation volk.x86_64: W: spelling-error %description -l en_US vectorization -> factorization, categorization, motorization volk.x86_64: E: non-executable-script /usr/lib64/python3.9/site-packages/volk_modtool/__init__.py 644 /usr/bin/env python volk.x86_64: E: non-executable-script /usr/lib64/python3.9/site-packages/volk_modtool/cfg.py 644 /usr/bin/env python volk.x86_64: W: no-manual-page-for-binary list_cpu_features volk.x86_64: W: no-manual-page-for-binary volk-config-info volk.x86_64: W: no-manual-page-for-binary volk_modtool volk.x86_64: W: no-manual-page-for-binary volk_profile 5 packages and 0 specfiles checked; 2 errors, 6 warnings.
Source checksums ---------------- https://github.com/gnuradio/volk/releases/download/v2.4.1/gpg_volk_release_k... : CHECKSUM(SHA256) this package : fd777dc1960dd2b5888e755212b141d1c2e774aeca5b40438a13725e7391461c CHECKSUM(SHA256) upstream package : fd777dc1960dd2b5888e755212b141d1c2e774aeca5b40438a13725e7391461c https://github.com/gnuradio/volk/releases/download/v2.4.1/volk-2.4.1.tar.gz.... : CHECKSUM(SHA256) this package : 0b1ba1980180d6c850a1312edfd51e55fe7b24d986b223b64178d640a7dcfe6c CHECKSUM(SHA256) upstream package : 0b1ba1980180d6c850a1312edfd51e55fe7b24d986b223b64178d640a7dcfe6c https://github.com/gnuradio/volk/releases/download/v2.4.1/volk-2.4.1.tar.gz : CHECKSUM(SHA256) this package : 61d681f90e0f30894f806ab050e9ba28260799c01f1ed0f58623942d8c7f4d48 CHECKSUM(SHA256) upstream package : 61d681f90e0f30894f806ab050e9ba28260799c01f1ed0f58623942d8c7f4d48
Requires -------- volk (rpmlib, GLIBC filtered): /usr/bin/python3 libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) liborc-0.4.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libvolk.so.2.4()(64bit) python(abi) rtld(GNU_HASH)
volk-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) libvolk.so.2.4()(64bit) volk(x86-64)
volk-doc (rpmlib, GLIBC filtered): volk
volk-debuginfo (rpmlib, GLIBC filtered):
volk-debugsource (rpmlib, GLIBC filtered):
Provides -------- volk: libvolk.so.2.4()(64bit) volk volk(x86-64)
volk-devel: cmake(CpuFeatures) cmake(Volk) cmake(cpufeatures) cmake(volk) pkgconfig(volk) volk-devel volk-devel(x86-64)
volk-doc: volk-doc
volk-debuginfo: debuginfo(build-id) volk-debuginfo volk-debuginfo(x86-64)
volk-debugsource: volk-debugsource volk-debugsource(x86-64)
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1917625 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python, C/C++ Disabled plugins: Perl, fonts, Haskell, PHP, R, SugarActivity, Ocaml, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
--- Comment #3 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to Jan Žerdík from comment #2) Thanks for the review.
Issues:
- Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782
Hopefully fixed, it's also mentioned in the Fedora Packaging Guidelines.
- Missing dash on second line of changelog (typo)?
This is probably OK although it is not explicitly mentioned in the guidelines. It's the second line of the first item of the first entry containing keyword for automation.
* first entry - first item first item continuation - second item
Spec URL: https://jskarvad.fedorapeople.org/volk/volk.spec SRPM URL: https://jskarvad.fedorapeople.org/volk/volk-2.4.1-2.fc32.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
Jan Žerdík jzerdik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
--- Comment #4 from Jaroslav Škarvada jskarvad@redhat.com --- Thanks Jan.
It seems some tests are failing on s390x and ppc64le, I will address it upstream before pushing it into fedora:
92 - qa_volk_32fc_s32fc_multiply_32fc (Failed) 93 - qa_volk_32fc_s32fc_rotatorpuppet_32fc (Failed) 102 - qa_volk_32fc_x2_s32fc_multiply_conjugate_add_32fc (Failed)
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
--- Comment #5 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to Jaroslav Škarvada from comment #4)
Thanks Jan.
It seems some tests are failing on s390x and ppc64le, I will address it upstream before pushing it into fedora:
92 - qa_volk_32fc_s32fc_multiply_32fc (Failed) 93 - qa_volk_32fc_s32fc_rotatorpuppet_32fc (Failed) 102 - qa_volk_32fc_x2_s32fc_multiply_conjugate_add_32fc (Failed)
Upsstream ticket: https://github.com/gnuradio/volk/issues/442
Maybe I will temporally bypass the tests in order to finish the gnuradio rebase and then handle this problem in the rawhide. IMHO not much people use gnuradio at s390x and ppc64le so it shouldn't cause much harm.
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
--- Comment #6 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to Jaroslav Škarvada from comment #5)
Maybe I will temporally bypass the tests in order to finish the gnuradio rebase and then handle this problem in the rawhide. IMHO not much people use gnuradio at s390x and ppc64le so it shouldn't cause much harm.
The problem will probably require API change of volk, which may take some time, see discussion in upstream ticket for details. It seems the problem was always there for ppc64le and s390x, so we already have this problem in gnuradio < 3.9.0.0, which means that if we temporaly bypass the testsuite the situation will be the same, i.e. the gnuradio could coredump on s390x and ppc64le under some circumstances. So I am going ahead with what we currently have. I will update and rebuild all packages later when the upstream update addressing this problem will be available.
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
--- Comment #7 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/volk
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
Jan Žerdík jzerdik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
Jan Žerdík jzerdik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1917625
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2021-02-02 23:16:43
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com