[Bug 421871] New: Review Request: libvirt-cim - A CIM provider for libvirt - package-review

List overview All Threads
Download

newer

[Bug 421871] New: Review Request: libvirt-cim - A CIM provider for libvirt

older

[Bug 492834] New: Review Request:...

[Bug 250904] New: Review Request:...

Red Hat Bugzilla

12 Dec 2007 12 Dec '07

4:23 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=421871

Summary: Review Request: libvirt-cim - A CIM provider for libvirt Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: danms@us.ibm.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://static.danplanet.com/pkg/fedora-9/libvirt-cim.spec SRPM URL: http://static.danplanet.com/pkg/fedora-9/libvirt-cim-0.1-1.fc9.src.rpm Description: libvirt-cim is a CIM provider for virtualization platforms supported by libvirt. It enables remote enterprise-class management of virtual machines.

Note: We have not made a formal code release yet. We will do so soon and will update the spec with a URL at that point.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=289649

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

6 Jan 6 Jan

5:42 a.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libvirt-cim - A CIM provider for libvirt

https://bugzilla.redhat.com/show_bug.cgi?id=421871

matt_domsch@dell.com changed:

------- Additional Comments From matt_domsch@dell.com 2008-01-06 00:42 EST ------- Release: what's extra_release there for?

BuildRoot: value acceptable, but two better choices are available.

Source: misssing full URL to the file.

Why explicit Requires for libxml2 and libvirt versions? README lists libvirt-0.2.3, while spec Requires libvirt >= 0.3.2. typo? somewhere?

%pre needs a comment explaining what you're trying to do. It looks like the provider-register call in %pre is trying to unregister (e.g. -d is delete). It took me a while to figure it out, because you are invoking scripts that are part of its own (not yet installed) package (which fails on first install, so you hit the ||true clause).

%post: don't automatically restart the service, use cond-restart. You don't want it started on initial install from kickstart, for example.

$ rpmlint *.rpm libvirt-cim.src: W: strange-permission libvirt-cim.spec 0600 otherwise file permissions look ok, no other lint warnings.

rpaths used, which need to be removed. Drop files in /etc/ld.so.conf.d/ adding /usr/lib*/cmpi/.

Remove *.so files.

Review criteria: rpmlint attached, trivial spec permission fix at checkin time OK package name OK spec file name OK with changes above, should meet packaging guidelines FIX+RECHECK license LGPLv2.1+ OK license field matches OK license included in %doc OK spec is English OK spec mostly legible, modulo comments above. OK can't presently judge source matches upstream, until formal upstream tarball is released. FIX+RECHECK package compiles on at least x86_64 F9(rawhide) in mock. OK spec doesn't use locales OK ldconfig called appropriately OK package not relocatable OK package owns its directories OK no duplicate files OK defaddr line present, permissions sane OK %clean OK macros OK contains code OK no large docs no header files OK no static libs OK no pkgconfig files OK .so files present but not in a -devel package, delete them. FIX+RECHECK no .la files OK no GUI files OK directory ownership OK %install cleans first OK all filesname UTF-8 OK

license included OK translated summary & description, not present. SHOULD, but OK package builds in mock on x86_64. OK package not tested. scriptlets sane, if commented. FIX+RECHECK no subpackages OK no .pc files OK no file deps OK

Please fix and repost.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7 Jan 7 Jan

6:02 p.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libvirt-cim - A CIM provider for libvirt

https://bugzilla.redhat.com/show_bug.cgi?id=421871

danms@us.ibm.com changed:

------- Additional Comments From danms@us.ibm.com 2008-01-07 13:02 EST ------- - Removed extra_release - Source URL will be updated when the upstream release is made - Removed explicit Requires - Commented %pre. Following convention here. - Changed to cond-restart - chrpath reports no rpath set on my .so's. CIM providers *are* .so files and must remain as such. See sblim-cmpi-base (et al) for other examples. These are not development libraries, they are plugin-type libraries.

SPEC: http://static.danplanet.com/pkg/fedora-9/libvirt-cim.spec SRPM: http://static.danplanet.com/pkg/fedora-9/libvirt-cim-0.1-2.fc9.src.rpm

Thanks!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

6:56 p.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libvirt-cim - A CIM provider for libvirt

https://bugzilla.redhat.com/show_bug.cgi?id=421871

matt_domsch@dell.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review- |fedora-review+

------- Additional Comments From matt_domsch@dell.com 2008-01-07 13:56 EST ------- Thanks for the quick turn.

Building on x86_64, I do see RPATHs being used.

$ find . -name *.so | xargs -n 1 chrpath -l | grep RPATH ./usr/lib64/cmpi/libVirt_HostedDependency.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_AllocationCapabilities.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_VSMigrationService.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_VirtualSystemManagementService.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_ComputerSystemIndication.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_ElementCapabilities.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_ResourcePoolConfigurationService.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_SettingsDefineState.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_ElementConformsToProfile.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_VSSDComponent.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_SystemDevice.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_HostedService.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_HostedResourcePool.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_VirtualSystemManagementCapabilities.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_SettingsDefineCapabilities.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_ElementAllocatedFromPool.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_ResourceAllocationFromPool.so: RPATH=/usr/lib64/cmpi ./usr/lib64/cmpi/libVirt_ElementSettingData.so: RPATH=/usr/lib64/cmpi

other trivial things:

rpmlint warning: libvirt-cim.x86_64: W: percent-in-%pre. This comes from %pre's comment header mentioning %post. Just drop the %.

Be sure spec file permissions are 644 when you cvs checkin to get rid of the other rpmlint warning.

A comment about .so files being plugins would be helpful.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:08 p.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libvirt-cim - A CIM provider for libvirt

https://bugzilla.redhat.com/show_bug.cgi?id=421871

------- Additional Comments From danms@us.ibm.com 2008-01-07 18:08 EST ------- Hmm, RPATH is only on some of them. How weird. I added the code to "fix" libtool, and now they're gone.

Fixed the comment issue (that was dumb of me).

For reference, the fixed version: SRPM: http://static.danplanet.com/pkg/fedora-9/libvirt-cim-0.1-3.fc9.src.rpm SPEC: http://static.danplanet.com/pkg/fedora-9/libvirt-cim.spec

Thanks!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:09 p.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libvirt-cim - A CIM provider for libvirt

https://bugzilla.redhat.com/show_bug.cgi?id=421871

danms@us.ibm.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From danms@us.ibm.com 2008-01-07 18:09 EST ------- New Package CVS Request ======================= Package Name: libvirt-cim Short Description: A CIM provider for libvirt Owners: danms Branches: F-9 InitialCC: Cvsextras Commits: No

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:20 p.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libvirt-cim - A CIM provider for libvirt

https://bugzilla.redhat.com/show_bug.cgi?id=421871

------- Additional Comments From matt_domsch@dell.com 2008-01-07 18:19 EST ------- great, thanks. APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8 Jan 8 Jan

3:27 a.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libvirt-cim - A CIM provider for libvirt

https://bugzilla.redhat.com/show_bug.cgi?id=421871

kevin@tummy.com changed:

------- Additional Comments From kevin@tummy.com 2008-01-07 22:27 EST ------- cvs done.

Any particular reason to disallow cvsextras commits?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:17 p.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: libvirt-cim - A CIM provider for libvirt

https://bugzilla.redhat.com/show_bug.cgi?id=421871

danms@us.ibm.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

13 Oct 13 Oct

11:54 p.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=421871

Kaitlin Rupert kaitlin@linux.vnet.ibm.com changed:

--- Comment #8 from Kaitlin Rupert kaitlin@linux.vnet.ibm.com 2008-10-13 19:54:46 EDT --- Package Change Request ====================== Package Name: libvirt-cim New Branches: dist-f10 Owners: danms

Add Fedora 10 branch.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

15 Oct 15 Oct

10:04 p.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=421871

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #9 from Kevin Fenzi kevin@tummy.com 2008-10-15 18:04:10 EDT --- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

22 Apr 22 Apr

1:15 a.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=421871

--- Comment #10 from Kaitlin Rupert kaitlin@linux.vnet.ibm.com 2009-04-21 21:14:58 EDT --- Package Change Request ====================== Package Name: libvirt-cim New Branches: dist-f11 Owners: kaitlin, danms

Add Fedora 11 branch.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6 Oct 6 Oct

6:18 p.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=421871

--- Comment #11 from Kaitlin Rupert kaitlin@linux.vnet.ibm.com 2009-10-06 14:18:44 EDT --- Package Change Request ====================== Package Name: libvirt-cim Owners: danms kailtin

danms is the current owner and I am a co-maintainer. Dan has not been maintaining the project for the past 7 months. Would like to switch ownership over to Kaitlin and remove Dan as a co-maintainer.

Thanks!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:21 p.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=421871

--- Comment #12 from Dan Smith danms@us.ibm.com 2009-10-06 14:21:54 EDT --- Seconded :)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:25 p.m.

New subject: [Bug 421871] Review Request: libvirt-cim - A CIM provider for libvirt

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=421871

--- Comment #13 from Kevin Fenzi kevin@tummy.com 2009-10-06 14:25:23 EDT --- You guys can do this yourself. ;)

Dan, go to: https://admin.fedoraproject.org/pkgdb/packages/name/libvirt-cim

and orphan the package, and Kaitlin can take full ownership.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5768

Age (days ago)

6432

Last active (days ago)

package-review@lists.fedoraproject.org

14 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla