https://bugzilla.redhat.com/show_bug.cgi?id=1484164
Bug ID: 1484164 Summary: Review Request: libsocketpp - C++ Standard I/O TCP sockets Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: chucks.8090@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/softwaresale/libsocketpp_rpm_build_files/m...
SRPM URL: https://raw.githubusercontent.com/softwaresale/libsocketpp_rpm_build_files/m...
Description: Libsocketpp is a C++ development library for creating TCP sockets with the standard C++ I/O interface. This means that socket objects will behave like C++'s cout and cin. This project integrates well with existing C TCP socket code.
Note: This is my first package submission to the Fedora Project, so I will need a sponsor. I am the creator and packager for libsocketpp, so I am extra dedicated to the project and spend quite a lot of time on it.
Also, the package is submitted is technically called libsocketpp-devel because it is a development library and not a standalone package. Please let me know what I need to do to fix this. Thanks!
Fedora Account System Username: softwaresale
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
chucks.8090@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
Iwicki Artur fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl
--- Comment #1 from Iwicki Artur fedora@svgames.pl ---
Group: Development/Tools
The "Group:" tag should not be used. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
License: GPL+
"GPL+" should only be used when upstream doesn't specify the licence version. You're using GPL v3 or later, so the tag should be "GPLv3+". https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
--- Comment #2 from chucks.8090@gmail.com --- Thanks. I'll get that fixed up. Quick question: because this is a development library, should I add the suffix "-devel" to my package or not?
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
Rex Dieter rdieter@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@gmail.com
--- Comment #3 from Rex Dieter rdieter@gmail.com --- don't rename it, it's fine as-is
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
--- Comment #4 from chucks.8090@gmail.com --- Ok. Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Well, actually, the package spec needs to be reorganized and the package does need to be slightly renamed...
Here's a relatively simple example of how a library package looks: https://src.fedoraproject.org/rpms/libbluray/blob/master/f/libbluray.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
--- Comment #6 from Charlie Sale chucks.8090@gmail.com --- Thanks. I'll get that fixed and uploaded very soon. Are any of you able to formally review my package or sponsor me? That would be really helpful...
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
--- Comment #7 from Charlie Sale chucks.8090@gmail.com --- Everything is up to date. Note, the URLS from above need to be updated. Here they are:
Spec: https://raw.githubusercontent.com/softwaresale/libsocketpp_rpm_build_files/m...
SRPM: https://raw.githubusercontent.com/softwaresale/libsocketpp_rpm_build_files/m...
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #8 from Neal Gompa ngompa13@gmail.com --- I can sponsor, and I'll take the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
--- Comment #9 from Charlie Sale chucks.8090@gmail.com --- Thanks a ton Neal. Let me know if you have any questions for me regarding sponsorship. My email is chucks.8090@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
--- Comment #10 from Charlie Sale chucks.8090@gmail.com --- Hey Neal. Can I have an update on the review process of my package? Is there anything I can fix for you?
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
--- Comment #11 from Neal Gompa ngompa13@gmail.com ---
%autosetup -n %{name}-%{version}
This is redundant, just use "%autosetup", as "-n %{name}-%{version}" is the default
make %{?_smp_mflags}
Use %make_build
rm -f $RPM_BUILD_ROOT/%{_infodir}/dir rm -f $RPM_BUILD_ROOT/%{_libdir}/libsocketpp.la
Use %{buildroot} instead of $RPM_BUILD_ROOT
ldconfig
Use "/sbin/ldconfig"
%postun ldconfig
Use "%postun -p /sbin/ldconfig"
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
--- Comment #12 from Neal Gompa ngompa13@gmail.com ---
%global gittag0 v1.0.0
This is unnecessary, as %{version} is already defined at 1.0.0
Source0: https://github.com/softwaresale/%%7Bname%7D/archive/%%7Bgittag0%7D/%%7Bname%...
Change usage of "%{gittag0}" to "v%{version}". This lets you control the version bump from a single location.
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
--- Comment #13 from Charlie Sale chucks.8090@gmail.com --- Hey Neal
I am actually retracting my submission due to C++20 releasing a networking library, which makes libsocketpp redundant and therefore unnecessary. Thanks for your time anyways!
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
Charlie Sale chucks.8090@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DEFERRED Last Closed| |2017-09-13 10:39:22
https://bugzilla.redhat.com/show_bug.cgi?id=1484164
Jonathan Wakely jwakely@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jwakely@redhat.com
--- Comment #14 from Jonathan Wakely jwakely@redhat.com --- This code leaks memory and doesn't close sockets.
Fedora already has a number of mature C++ libraries providing similar functionality (boost-asio, asio, poco-net, ...) so I don't see why we would want this anyway.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com