[Bug 1898100] New: Review Request: <main package name here> - <short summary here>

https://bugzilla.redhat.com/show_bug.cgi?id=1898100

Bug ID: 1898100
           Summary: Review Request: <main package name here> - <short
                    summary here>
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://build.opensuse.org/package/view_file/home:KingMint/BeeBEEP/beebeep.s...

SRPM URL:
https://build.opensuse.org/package/binary/download/home:KingMint/BeeBEEP/Fed...

Description: BeeBEEP is a secure network chat. You can talk and send files with
all your
friends inside a local area network such of an office, home or internet cafe
without a server.

Fedora Account System Username: Evert

Please review this package.

Thanks in advance.

[Bug 1898100] Review Request: beebeep - My first package that i want to contribute to the community

https://bugzilla.redhat.com/show_bug.cgi?id=1898100

Evert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: <main       |Review Request: beebeep -
                   |package name here> - <short |My first package that i
                   |summary here>               |want to contribute to the
                   |                            |community

[Bug 1898100] Review Request: beebeep - My first package that i want to contribute to the community

https://bugzilla.redhat.com/show_bug.cgi?id=1898100

--- Comment #1 from Evert  ---
spec file with actual changelog:

%global debug_package %{nil}

Name: beebeep
Summary: Secure Network Chat
Version: 5.8.2
Release: 1
Group: Applications/Communications
URL: http://sourceforge.net/projects/beebeep/
Source0:
https://sourceforge.net/projects/beebeep/files/Sources/%%7Bname%7D-code-%%7B...
License: Qt Public License
BuildRequires: qt5-qtbase-devel
BuildRequires: qt5-qtmultimedia-devel
BuildRequires: qt5-qtx11extras-devel

%description
BeeBEEP is a secure network chat. You can talk and send files with all your
friends inside a local area network such of an office, home or internet cafe
without a server.

%prep
%setup -q -n %{name}-code-r1352

%build
qmake-qt5 -recursive
make %{?_smp_mflags}

%install
mkdir -p %{buildroot}%{_bindir}
mv test/%{name} %{buildroot}%{_bindir}/%{name}
mkdir -p %{buildroot}%{_libdir}
cp -a test/* %{buildroot}%{_libdir}

%files
%doc *.txt
%{_bindir}/%{name}
%{_libdir}/lib*

%changelog
* Mon Nov 16 2020 Evert <[e-mail] 5.8.2
- Build for Fedora 33

* Fri Sep 06 2019 Wei-Lun Chao  - 5.6.8
- Rebuild for Fedora

[Bug 1898100] Review Request: beebeep - My first package that i want to contribute to the community

https://bugzilla.redhat.com/show_bug.cgi?id=1898100

Artur Frenszek-Iwicki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #2 from Artur Frenszek-Iwicki  ---
The spec should be posted as a link, not in a comment. 
As for the links in the original post:
a) The spec links points to an HTML web-view of the file. Please use "raw file"
links.
b) The SRPM link asks me to log in before I can fetch the file.
> Review Request: beebeep - My first package that i want to contribute to the community

The ticket title should describe what the package does.
> Group: Applications/Communications

Not used in Fedora.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_section...
> License: Qt Public License

The LICENSE.txt file in the repo says that it's actually GPLv3.
https://sourceforge.net/p/beebeep/code/HEAD/tree/LICENSE.txt
> %global debug_package %{nil}

This is generally a red flag. We *want* debuginfo to be generated. If your
package fails to build without this line, it means that the binaries (i.e.
executables and libraries) do not contain debug symbols; either they are
compiled without debuginfo degeneration, or they are stripped at some point.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/
> qmake-qt5 -recursive

Use the "%qmake_qt5" macro here instead. It should set up Fedora's CXXFLAGS
properly, possibly solving the issue with missing debuginfo.

[Bug 1898100] BeeBEEP is a secure network chat. You can talk and send files with all your friends inside a local area network such of an office, home or internet cafe without a server.

https://bugzilla.redhat.com/show_bug.cgi?id=1898100

Evert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: beebeep -   |BeeBEEP is a secure network
                   |My first package that i     |chat. You can talk and send
                   |want to contribute to the   |files with all your friends
                   |community                   |inside a local area network
                   |                            |such of an office, home or
                   |                            |internet cafe without a
                   |                            |server.

[Bug 1898100] BeeBEEP is a secure network chat. You can talk and send files with all your friends inside a local area network such of an office, home or internet cafe without a server.

https://bugzilla.redhat.com/show_bug.cgi?id=1898100

Olivier Lemasle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Olivier Lemasle  ---
Two additional points:
1. The changelog is incorrect (mentions an outdated version)
2. This Bugzilla ticket's summary should have this format: "Review Request:
<main package name here> - <short summary here>"

[Bug 1898100] BeeBEEP is a secure network chat. You can talk and send files with all your friends inside a local area network such of an office, home or internet cafe without a server.

https://bugzilla.redhat.com/show_bug.cgi?id=1898100

Troy Curtis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         Whiteboard|                            |NotReady

--- Comment #4 from Troy Curtis  ---
Setting to NotReady until some of the comments are addressed.

needinfo canceled: [Bug 1898100] BeeBEEP is a secure network chat. You can talk and send files with all your friends inside a local area network such of an office, home or internet cafe without a server.

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for Evert
's needinfo:
Bug 1898100: BeeBEEP is a secure network chat. You can talk and send files with
all your friends inside a local area network such of an office, home or
internet cafe without a server.
https://bugzilla.redhat.com/show_bug.cgi?id=1898100

--- Comment #6 from Package Review  ---
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.