[Bug 837687] New: Review Request: python-cmd2 - Extra features for standard library's cmd module
https://bugzilla.redhat.com/show_bug.cgi?id=837687
Bug ID: 837687 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: python-cmd2 - Extra features for standard library's cmd module Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: rbean@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://threebean.org/rpm/python-cmd2.spec SRPM URL: http://threebean.org/rpm/python-cmd2-0.6.4-1.fc17.src.rpm Description: Enhancements for standard library's cmd module.
Drop-in replacement adds several features for command-prompt tools:
* Searchable command history (commands: "hi", "li", "run") * Load commands from file, save to file, edit commands in file * Multi-line commands * Case-insensitive commands * Special-character shortcut commands (beyond cmd's "@" and "!") * Settable environment parameters * Parsing commands with flags * > (filename), >> (filename) redirect output to file * < (filename) gets input from file * bare >, >>, < redirect to/from paste buffer * accepts abbreviated commands when unambiguous * `py` enters interactive Python console * test apps against sample session transcript (see example/example.py)
Useable without modification anywhere cmd is used; simply import cmd2.Cmd in place of cmd.Cmd.
See docs at http://packages.python.org/cmd2/
Fedora Account System Username: ralph
rpmlint output -------------- --- ~/rpmbuild ยป rpmlint {SRPMS,SPECS}/python-cmd2* python-cmd2.src: W: spelling-error Summary(en_US) cmd -> cm, cad, cod python-cmd2.src: W: spelling-error %description -l en_US cmd -> cm, cad, cod python-cmd2.src: W: spelling-error %description -l en_US li -> lee, Li, lo python-cmd2.src: W: spelling-error %description -l en_US cmd's -> cad's, cod's, cud's python-cmd2.src: W: spelling-error %description -l en_US filename -> file name, file-name, filament python-cmd2.src: W: spelling-error %description -l en_US py -> pt, p, y python-cmd2.src: W: spelling-error %description -l en_US Cmd -> Cm, Cd, Cmdr 1 packages and 1 specfiles checked; 0 errors, 7 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=837687
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |837688
https://bugzilla.redhat.com/show_bug.cgi?id=837687
Ross Delinger rossdylan@csh.rit.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rossdylan@csh.rit.edu Assignee|nobody@fedoraproject.org |rossdylan@csh.rit.edu
--- Comment #1 from Ross Delinger rossdylan@csh.rit.edu --- I got this one
https://bugzilla.redhat.com/show_bug.cgi?id=837687
Ross Delinger rossdylan@csh.rit.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=837687
--- Comment #2 from Ross Delinger rossdylan@csh.rit.edu --- Looks good to me one, spelling error in the description s/useable/usable/ after that is fixed you are good to go!
Package Review ==============
Key: - = N/A x = Pass ! = Fail ? = Not evaluated
==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [ ]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [ ]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [ ]: MUST Package contains no bundled libraries. [ ]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [ ]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [ ]: MUST Macros in Summary, %description expandable at SRPM build time. [ ]: MUST Package contains desktop file if it is a GUI application. [ ]: MUST Package requires other packages for directories it uses. [ ]: MUST Package uses nothing in %doc for runtime. [ ]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [ ]: MUST Large documentation files are in a -doc subpackage, if required. [ ]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* UNKNOWN" For detailed output of licensecheck see file: /home/rossdylan/rpmbuild/REVIEWS/837687-python-cmd2/licensecheck.txt [ ]: MUST License file installed when any subpackage combination is installed. [ ]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [ ]: MUST Package is named according to the Package Naming Guidelines. [ ]: MUST Package does not generate any conflict. [ ]: MUST Package obeys FHS, except libexecdir and /usr/target. [ ]: MUST Package must own all directories that it creates. [ ]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [ ]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [ ]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [ ]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [ ]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [ ]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [ ]: SHOULD Package functions as described. [ ]: SHOULD Latest version is packaged. [ ]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [ ]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: SHOULD Package should compile and build into binary rpms on all supported architectures. [ ]: SHOULD %check is present and all tests pass. [ ]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.
Rpmlint ------- Checking: python3-cmd2-0.6.4-1.fc17.noarch.rpm python-cmd2-0.6.4-1.fc17.src.rpm python-cmd2-0.6.4-1.fc17.noarch.rpm python3-cmd2.noarch: W: spelling-error Summary(en_US) cmd -> cm, cad, cod python3-cmd2.noarch: W: spelling-error %description -l en_US cmd -> cm, cad, cod python3-cmd2.noarch: W: spelling-error %description -l en_US li -> lee, Li, lo python3-cmd2.noarch: W: spelling-error %description -l en_US cmd's -> cad's, cod's, cud's python3-cmd2.noarch: W: spelling-error %description -l en_US filename -> file name, file-name, filament python3-cmd2.noarch: W: spelling-error %description -l en_US py -> pt, p, y python3-cmd2.noarch: W: spelling-error %description -l en_US Cmd -> Cm, Cd, Cmdr python-cmd2.src: W: spelling-error Summary(en_US) cmd -> cm, cad, cod python-cmd2.src: W: spelling-error %description -l en_US cmd -> cm, cad, cod python-cmd2.src: W: spelling-error %description -l en_US li -> lee, Li, lo python-cmd2.src: W: spelling-error %description -l en_US cmd's -> cad's, cod's, cud's python-cmd2.src: W: spelling-error %description -l en_US filename -> file name, file-name, filament python-cmd2.src: W: spelling-error %description -l en_US py -> pt, p, y python-cmd2.src: W: spelling-error %description -l en_US Cmd -> Cm, Cd, Cmdr python-cmd2.noarch: W: spelling-error Summary(en_US) cmd -> cm, cad, cod python-cmd2.noarch: W: spelling-error %description -l en_US cmd -> cm, cad, cod python-cmd2.noarch: W: spelling-error %description -l en_US li -> lee, Li, lo python-cmd2.noarch: W: spelling-error %description -l en_US cmd's -> cad's, cod's, cud's python-cmd2.noarch: W: spelling-error %description -l en_US filename -> file name, file-name, filament python-cmd2.noarch: W: spelling-error %description -l en_US py -> pt, p, y python-cmd2.noarch: W: spelling-error %description -l en_US Cmd -> Cm, Cd, Cmdr 3 packages and 0 specfiles checked; 0 errors, 21 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint python-cmd2 python3-cmd2 python-cmd2.noarch: I: enchant-dictionary-not-found en_US python-cmd2.noarch: W: spelling-error %description -l en_US useable -> usable python3-cmd2.noarch: W: spelling-error %description -l en_US useable -> usable 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:'
Requires -------- python3-cmd2-0.6.4-1.fc17.noarch.rpm (rpmlib, GLIBC filtered):
python(abi) = 3.2 python3-pyparsing
python-cmd2-0.6.4-1.fc17.noarch.rpm (rpmlib, GLIBC filtered):
pyparsing python(abi) = 2.7
Provides -------- python3-cmd2-0.6.4-1.fc17.noarch.rpm:
python3-cmd2 = 0.6.4-1.fc17
python-cmd2-0.6.4-1.fc17.noarch.rpm:
python-cmd2 = 0.6.4-1.fc17
MD5-sum check ------------- /home/rossdylan/rpmbuild/REVIEWS/837687-python-cmd2/upstream/cmd2-0.6.4.tar.gz : MD5SUM this package : 60a07255bbcb4342888b1574f46e56ea MD5SUM upstream package : 60a07255bbcb4342888b1574f46e56ea
Generated by fedora-review 0.2.0git External plugins:
https://bugzilla.redhat.com/show_bug.cgi?id=837687
--- Comment #3 from Ralph Bean rbean@redhat.com --- Okay, updated with the spelling error corrected.
Spec URL: http://threebean.org/rpm/python-cmd2.spec SRPM URL: http://threebean.org/rpm/python-cmd2-0.6.4-2.fc17.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=837687
Ross Delinger rossdylan@csh.rit.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Ross Delinger rossdylan@csh.rit.edu --- approved!
https://bugzilla.redhat.com/show_bug.cgi?id=837687
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Ralph Bean rbean@redhat.com --- New Package SCM Request ======================= Package Name: python-cmd2 Short Description: Extra features for standard library's cmd module Owners: ralph Branches: f17 f16 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=837687
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=837687
--- Comment #7 from Ralph Bean rbean@redhat.com --- Pushed to testing -- https://admin.fedoraproject.org/updates/python-cmd2
https://bugzilla.redhat.com/show_bug.cgi?id=837687
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |ERRATA Last Closed| |2012-07-05 22:46:11
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla