[Bug 1671234] New: Review Request: mpris-scrobbler - User daemon to submit currently playing song to LastFM, LibreFM, ListenBrainz
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
Bug ID: 1671234 Summary: Review Request: mpris-scrobbler - User daemon to submit currently playing song to LastFM, LibreFM, ListenBrainz Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: low Assignee: nobody@fedoraproject.org Reporter: jflory7@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
This is my second package and I am seeking a sponsor.
* Spec URL: https://pagure.io/jflory7-rpm-specs/blob/master/f/rpmbuild/SPECS/mpris-scrob... * SRPM URL: https://pagure.io/jflory7-rpm-specs/blob/master/f/rpmbuild/SRPMS/brightlight... * Description: mpris-scrobbler is a minimalist user daemon that submits the currently playing song to LastFM, LibreFM, ListenBrainz, and compatible services. To retrieve song information, it uses the MPRIS DBus interface, so it works with any media player that exposes this interface (https://github.com/mariusor/mpris-scrobbler). * Fedora Account System Username: jflory7
This package is also hosted in COPR and was built in Koji on F28, F29, and Rawhide.
* https://copr.fedorainfracloud.org/coprs/jflory7/mpris-scrobbler/ * https://koji.fedoraproject.org/koji/taskinfo?taskID=32354678
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
--- Comment #1 from Justin W. Flory jflory7@gmail.com --- Typo in previous comment. SRPM URL is here: https://pagure.io/jflory7-rpm-specs/blob/master/f/rpmbuild/SRPMS/mpris-scrob...
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i.gnatenko.brain@gmail.com
--- Comment #2 from Igor Gnatenko i.gnatenko.brain@gmail.com --- --- mpris-scrobbler.spec~ 2019-01-31 14:26:20.002065328 +0100 +++ mpris-scrobbler.spec 2019-01-31 14:29:44.673263100 +0100 @@ -7,19 +7,17 @@ URL: https://github.com/mariusor/mpris-scrobbler Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
-BuildRequires: cmake -BuildRequires: dbus dbus-devel -BuildRequires: expat expat-devel +BuildRequires: meson BuildRequires: gcc -BuildRequires: json-c json-c-devel -BuildRequires: libcurl libcurl-devel -BuildRequires: libevent libevent-devel -BuildRequires: m4 make -BuildRequires: meson ninja-build -BuildRequires: openssl openssl-devel -BuildRequires: scdoc +BuildRequires: pkgconfig(dbus-1) +BuildRequires: pkgconfig(libcurl) +BuildRequires: pkgconfig(libevent) +BuildRequires: pkgconfig(json-c) +BuildRequires: /usr/bin/m4 +BuildRequires: /usr/bin/scdoc +BuildRequires: systemd-rpm-macros
-Requires: xdg-utils +Requires: /usr/bin/xdg-open
%description @@ -47,13 +45,12 @@
%files -%doc %{_mandir}/man1/mpris-scrobbler.1.gz -%doc %{_mandir}/man5/mpris-scrobbler-credentials.5.gz -%doc %{_mandir}/man1/mpris-scrobbler-signon.1.gz %license LICENSE %{_bindir}/%{name} %{_bindir}/%{name}-signon -/usr/lib/systemd/user/%{name}.service +%{_mandir}/man1/mpris-scrobbler{,-signon}.1* +%{_mandir}/man5/mpris-scrobbler-credentials.5* +%{_userunitdir}/%{name}.service
%changelog
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
--- Comment #3 from Justin W. Flory jflory7@gmail.com --- Thanks for the help, Igor. I pushed this new commit to address your feedback:
https://pagure.io/jflory7-rpm-specs/c/dc2a6dd39caf67030bb116262a40adcc670a7b...
Is there anything else worth doing before requesting a new dist-git repo?
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
--- Comment #4 from Justin W. Flory jflory7@gmail.com --- Oh, also, I built the changes in Koji for f30 and epel7, and I currently have a Copr build pending:
https://koji.fedoraproject.org/koji/taskinfo?taskID=32354678 https://koji.fedoraproject.org/koji/taskinfo?taskID=32369473 https://copr.fedorainfracloud.org/coprs/jflory7/mpris-scrobbler/build/852635...
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- - It seems you are already member of the packager group so you don't need a sponsor
- You need to add the SystemD scriptlets:
BuildRequires: systemd-rpm-macros %{?systemd_requires}
[...] %post %systemd_user_post %{name}.service
%preun %systemd_user_preun %{name}.service
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_syste...
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in mpris-scrobbler See: https://fedoraproject.org/wiki/Packaging:Scriptlets#User_units
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated". 36 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review /mpris-scrobbler/review-mpris-scrobbler/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mpris- scrobbler-debuginfo , mpris-scrobbler-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: mpris-scrobbler-0.3.1-1.fc30.x86_64.rpm mpris-scrobbler-debuginfo-0.3.1-1.fc30.x86_64.rpm mpris-scrobbler-debugsource-0.3.1-1.fc30.x86_64.rpm mpris-scrobbler-0.3.1-1.fc30.src.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
--- Comment #6 from Justin W. Flory jflory7@gmail.com --- (In reply to Robert-André Mauchin from comment #5)
- It seems you are already member of the packager group so you don't need a
sponsor
- You need to add the SystemD scriptlets:
Thanks for catching this. I added them in this commit [1]. I built a new SRPM [2] and tested in Koji [3][4][5] and COPR [6].
--- [1] https://pagure.io/jflory7-rpm-specs/c/4b10e204257e0aa3e27d2ab041b50120031df0... [2] https://pagure.io/jflory7-rpm-specs/blob/master/f/rpmbuild/SRPMS/mpris-scrob... [3] https://koji.fedoraproject.org/koji/taskinfo?taskID=32855917 [4] https://koji.fedoraproject.org/koji/taskinfo?taskID=32855924 [5] https://koji.fedoraproject.org/koji/taskinfo?taskID=32855931 [6] https://copr.fedorainfracloud.org/coprs/jflory7/mpris-scrobbler/build/859336...
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #7 from Robert-André Mauchin zebob.m@gmail.com --- All OK, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
--- Comment #8 from Igor Gnatenko i.gnatenko.brain@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mpris-scrobbler
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- mpris-scrobbler-0.3.1-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0a4f5af14e
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- mpris-scrobbler-0.3.1-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ed77c002a0
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- mpris-scrobbler-0.3.1-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-f7122502db
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- mpris-scrobbler-0.3.1-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0a4f5af14e
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- mpris-scrobbler-0.3.1-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ed77c002a0
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- mpris-scrobbler-0.3.1-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-f7122502db
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-02-27 01:15:45
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- mpris-scrobbler-0.3.1-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- mpris-scrobbler-0.3.1-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1671234
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- mpris-scrobbler-0.3.1-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com