[Bug 593959] New: Review Request: <maven-assembly-plugin> - <Maven Assembly Plugin>

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: <maven-assembly-plugin> - <Maven Assembly Plugin>

https://bugzilla.redhat.com/show_bug.cgi?id=593959

Summary: Review Request: <maven-assembly-plugin> - <Maven
                    Assembly Plugin>
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://yyang.fedorapeople.org/maven2/maven-assembly-plugin.spec
SRPM URL:
http://yyang.fedorapeople.org/maven2/maven-assembly-plugin-2.2-0.1.beta5.src...
Description: A Maven 2 plugin to create archives of your project's sources,
classes, dependencies etc. from flexible assembly descriptors.

[Bug 593959] Review Request: <maven-assembly-plugin> - <Maven Assembly Plugin>

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

Yang Yong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |593607

[Bug 593959] Review Request: <maven-assembly-plugin> - <Maven Assembly Plugin>

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 593959] Review Request: <maven-assembly-plugin> - <Maven Assembly Plugin>

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

--- Comment #1 from huwang  2010-05-20 03:11:50 EDT ---
I'll take this one.

[Bug 593959] Review Request: <maven-assembly-plugin> - <Maven Assembly Plugin>

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Review Request:             |Review Request:
                   |<maven-assembly-plugin> -   |maven-assembly-plugin -
                   |<Maven Assembly Plugin>     |Maven Assembly Plugin

--- Comment #2 from Alexander Kurtakov  2010-05-20 06:39:20 EDT ---
yyang: Please enter name and summary correctly.

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

--- Comment #3 from huwang  2010-05-23 04:21:18 EDT ---
It built failed, plexus-active--collections package is not still imported.

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

Bug 593959 depends on bug 593607, which changed state.

Bug 593607 Summary: Review Request: plexus-active-collections - Plexus Container-Backed Active Collections
https://bugzilla.redhat.com/show_bug.cgi?id=593607

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

--- Comment #4 from huwang  2010-06-02 11:26:53 EDT ---
NEEDSWORK: rpmlint must be run on every package. The output should be posted in
the review.
maven-assembly-plugin.noarch: E: devel-dependency java-devel
maven-assembly-plugin.noarch: W: no-documentation
maven-assembly-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-assembly-plugin
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
Please fix the error.

maven-assembly-plugin.src: W: strange-permission
maven-assembly-plugin-jpp-depmap.xml 0764
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Need to fix this.

maven-assembly-plugin.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

BTW, I think it is better to add epoch 0 to provides.

OK: The package must be named according to the  Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
OK: Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun.
OK: Packages must NOT bundle copies of system libraries.
OK: If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package. Without this, use of Prefix: /usr is considered a
blocker. 
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present.
OK: Header files must be in a -devel package. 
OK: Static libraries must be in a -static package. 
OK: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package. 
OK: In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name} = %{version}-%{release}
OK: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
OK: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.

OK: Packages must not own files or directories already owned by other packages.
The rule of thumb here is that the first package to be installed should own the
files or directories that other packages may rely upon. This means, for
example, that no package in Fedora should ever share ownership with any of the
files or directories owned by the filesystem or man package. If you feel that
you have a good reason to own a file or directory that another package owns,
then please present that at package review time. 
OK: All filenames in rpm packages must be valid UTF-8.

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

--- Comment #5 from Yang Yong  2010-06-03 05:10:04 EDT ---
Please review again.

Spec URL: http://yyang.fedorapeople.org/maven2/maven-assembly-plugin.spec
SRPM URL:
http://yyang.fedorapeople.org/maven2/maven-assembly-plugin-2.2-0.2.beta5.src...

Changelog:
- Chmod 0644 for depmap.xml
- Fix Obsoletes and Provides
- Change to BR java

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

--- Comment #6 from Yang Yong  2010-06-03 23:04:54 EDT ---
New Package CVS Request
=======================
Package Name: maven-assembly-plugin
Short Description: Plugin to create archives from project's descriptors
Owners: yyang
Branches: devel
InitialCC: huwang liweinan akurtako dbhole

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

--- Comment #7 from huwang  2010-06-03 23:37:29 EDT ---
oh, I think you made a mistake for creating cvs request.

Anyway, now the package looks good to me.
Package is APPROVED.

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

--- Comment #8 from Yang Yong  2010-06-04 03:13:13 EDT ---
New Package CVS Request
=======================
Package Name: maven-assembly-plugin
Short Description: Plugin to create archives from project's descriptors
Owners: yyang
Branches: devel
InitialCC: huwang liweinan akurtako dbhole

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

Yang Yong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #9 from Kevin Fenzi  2010-06-07 16:57:54 EDT ---
Cvs done except user 'liweinan' doesn't seem to exist.

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

Yang Yong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #10 from Yang Yong  2010-06-08 07:14:15 EDT ---
Kevin, cvs is not done after 12 hours passed, may caused by wrong CC, please
create cvs again and leave CC blank, thanks.

New Package CVS Request
=======================
Package Name: maven-assembly-plugin
Short Description: Plugin to create archives from project's descriptors
Owners: yyang
Branches: devel
InitialCC:

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=593959

Yang Yong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

--- Comment #11 from Yang Yong  2010-06-08 22:27:42 EDT ---
http://koji.fedoraproject.org/koji/buildinfo?buildID=177381