https://bugzilla.redhat.com/show_bug.cgi?id=2183331
Bug ID: 2183331 Summary: Review Request: rust-winnow - Byte-oriented, zero-copy, parser combinators library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-winnow.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-winnow-0.4.1-1.fc38.src.rpm
Description: A byte-oriented, zero-copy, parser combinators library.
Fedora Account System Username: decathorpe
koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=99336562
https://bugzilla.redhat.com/show_bug.cgi?id=2183331
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/wi | |nnow
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5731286 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2183331
Aleksei Bavshin alebastr89@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alebastr89@gmail.com Assignee|nobody@fedoraproject.org |alebastr89@gmail.com Flags| |fedora-review? Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value
--- Comment #2 from Aleksei Bavshin alebastr89@gmail.com --- Looks good with minor comments.
# * missing dev-dependencies: circular, snapbox, term-transcript
You can run `%cargo_test -- --doc` and `%cargo_test -- --lib` even without the listed packages. In fact, most of dev-dependencies are there only for examples. And for `debug`...
%package -n %{name}+unstable-doc-devel
Does this feature have any use other than in docs.rs documentation? Well, it's not harmful either so IMO it's fine to leave it.
https://bugzilla.redhat.com/show_bug.cgi?id=2183331
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- (In reply to Aleksei Bavshin from comment #2)
Looks good with minor comments.
# * missing dev-dependencies: circular, snapbox, term-transcript
You can run `%cargo_test -- --doc` and `%cargo_test -- --lib` even without the listed packages. In fact, most of dev-dependencies are there only for examples. And for `debug`...
Huh, you're right. I've removed those dependencies and added running unit and doc tests.
%package -n %{name}+unstable-doc-devel
Does this feature have any use other than in docs.rs documentation? Well, it's not harmful either so IMO it's fine to leave it.
Right, it's not harmful since it doesn't pull in any extra dependencies ...
Updated files behind the same URLs.
[fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2183331
--- Comment #4 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1955402 --> https://bugzilla.redhat.com/attachment.cgi?id=1955402&action=edit The .spec file difference from Copr build 5731286 to 5738121
https://bugzilla.redhat.com/show_bug.cgi?id=2183331
--- Comment #5 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5738121 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2183331
Aleksei Bavshin alebastr89@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #6 from Aleksei Bavshin alebastr89@gmail.com --- Looks good. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2183331
--- Comment #7 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-winnow
https://bugzilla.redhat.com/show_bug.cgi?id=2183331
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-819f0f3a80 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-819f0f3a80
https://bugzilla.redhat.com/show_bug.cgi?id=2183331
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-04-03 22:01:34
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-819f0f3a80 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org