https://bugzilla.redhat.com/show_bug.cgi?id=1480957
Bug ID: 1480957 Summary: Review Request: golang-github-axgle-mahonia - Character-set conversion library implemented in Go Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...
Description: Character-set conversion library implemented in Go
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/gocode/src/github.com/axgle/mahonia See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
rpmlint: 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Shouldn't the Release tag include the git hash? There seems to be no released version.
+ package name is OK ? license is acceptable (MIT) ? license is not specified correctly Where did you see the MIT license? README.md says this is derived from http://code.google.com/p/mahonia/, which lists BSD 3-clause.
Either way, you should open a ticket upstream asking for a license file to be included. Actually adding the license file is not necessary, but the ticket should be opened according to the guidelines [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text].
+ latest version + P/R/BR look OK + builds and install OK + fedora-review and rmplint are happy (modulo the issue listed above)
rpmlint: golang-github-BurntSushi-freetype-go-unit-test-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Blah, please ignore the last paragraph, I pasted the wrong text, the right rpmlint output is above.
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
--- Comment #3 from sensor.wen@gmail.com --- I opened a new ticket in the upstream for license.
https://github.com/axgle/mahonia/issues/4
Release and license tag is fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
--- Comment #4 from sensor.wen@gmail.com --- https://github.com/FZUG/repo/blob/master/rpms/deepin_project/golang-github-a...
I think project owner is leave. Could you approve it?
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1476590
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1476590 [Bug 1476590] Review Request: deepin-daemon - Daemon handling the DDE session settings
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Sorry for the delay, I am travelling.
Everything looks good, package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-axgle-mahonia
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-axgle-mahonia-0-0.1.gitc528b74.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b71d187af0
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-axgle-mahonia-0-0.1.gitc528b74.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b71d187af0
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sztsian@gmail.com Alias| |golang-github-axgle-mahonia
https://bugzilla.redhat.com/show_bug.cgi?id=1480957
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-07-22 09:31:07
--- Comment #9 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
package-review@lists.fedoraproject.org