[Bug 1688309] New: Review Request: gnome-latex - Integrated LaTeX Environment for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
Bug ID: 1688309 Summary: Review Request: gnome-latex - Integrated LaTeX Environment for the GNOME desktop Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: walter.pete@yandex.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://pwalter.fedorapeople.org/gnome-latex.spec SRPM URL: https://pwalter.fedorapeople.org/gnome-latex-3.32.0-1.fc31.src.rpm Description: This is a rename of latexila -> gnome-latex, following the rename done upstream. Fedora Account System Username: pwalter
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com ---
- {_datadir}/metainfo → %{_metainfodir}
- You also need to validate the Appdata:
BuildRequires: libappstream-glib
[…]
appstream-util validate-relax --nonet %{buildroot}%{_datadir}/metainfo/org.gnome.gnome-latex.appdata.xml
- Build fails:
checking for DEP... no BUILDSTDERR: configure: error: Package requirements ( BUILDSTDERR: glib-2.0 >= 2.56 BUILDSTDERR: gio-2.0 >= 2.56 BUILDSTDERR: gtk+-3.0 >= 3.22 BUILDSTDERR: gtksourceview-4 >= 4.0 BUILDSTDERR: tepl-4 >= 4.2 BUILDSTDERR: gspell-1 >= 1.8 BUILDSTDERR: gee-0.8 >= 0.10 BUILDSTDERR: gsettings-desktop-schemas BUILDSTDERR: ) were not met: BUILDSTDERR: Package 'tepl-4', required by 'virtual:world', not found BUILDSTDERR: Consider adjusting the PKG_CONFIG_PATH environment variable if you BUILDSTDERR: installed software in a non-standard prefix. BUILDSTDERR: Alternatively, you may set the environment variables DEP_CFLAGS BUILDSTDERR: and DEP_LIBS to avoid the need to call pkg-config. BUILDSTDERR: See the pkg-config man page for more details. BUILDSTDERR: error: Bad exit status from /var/tmp/rpm-tmp.c3Rz6s (%build) BUILDSTDERR: Bad exit status from /var/tmp/rpm-tmp.c3Rz6s (%build)
tepl is only at version 3.0.0 in Rawhide. You need to contact the maintainer of propose a PR to update to 4.2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
Phil Wyett philwyett@kathenas.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |philwyett@kathenas.org
--- Comment #2 from Phil Wyett philwyett@kathenas.org --- There is a PR for updating TEPL to 4.2.
https://src.fedoraproject.org/rpms/tepl/pull-request/1
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
--- Comment #3 from Phil Wyett philwyett@kathenas.org --- I have a WIP for this very update. Maybe we can combine work.
http://rpm.kathenas.org/fedora/testing/
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
--- Comment #4 from Phil Wyett philwyett@kathenas.org --- I have updated the spec file to 3.32.0-2 on:
http://rpm.kathenas.org/fedora/testing/
This incorporates changes by submitter and subsequent suggestions.
Feel free to discard %changelog. :-D
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- - Using the tepl 4.2.0 from the PR, I still get an error from OP's SPEC:
Checking for DCONF_DEP... no BUILDSTDERR: configure: error: Package requirements (dconf) were not met: BUILDSTDERR: Package 'dconf', required by 'virtual:world', not found BUILDSTDERR: Consider adjusting the PKG_CONFIG_PATH environment variable if you BUILDSTDERR: installed software in a non-standard prefix. BUILDSTDERR: Alternatively, you may set the environment variables DCONF_DEP_CFLAGS BUILDSTDERR: and DCONF_DEP_LIBS to avoid the need to call pkg-config. BUILDSTDERR: See the pkg-config man page for more details. BUILDSTDERR: error: Bad exit status from /var/tmp/rpm-tmp.uINJ3a (%build) BUILDSTDERR: Bad exit status from /var/tmp/rpm-tmp.uINJ3a (%build)
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
--- Comment #6 from Phil Wyett philwyett@kathenas.org --- (In reply to Robert-André Mauchin from comment #5)
- Using the tepl 4.2.0 from the PR, I still get an error from OP's SPEC:
Checking for DCONF_DEP... no BUILDSTDERR: configure: error: Package requirements (dconf) were not met: BUILDSTDERR: Package 'dconf', required by 'virtual:world', not found BUILDSTDERR: Consider adjusting the PKG_CONFIG_PATH environment variable if you BUILDSTDERR: installed software in a non-standard prefix. BUILDSTDERR: Alternatively, you may set the environment variables DCONF_DEP_CFLAGS BUILDSTDERR: and DCONF_DEP_LIBS to avoid the need to call pkg-config. BUILDSTDERR: See the pkg-config man page for more details. BUILDSTDERR: error: Bad exit status from /var/tmp/rpm-tmp.uINJ3a (%build) BUILDSTDERR: Bad exit status from /var/tmp/rpm-tmp.uINJ3a (%build)
If you use my original or latest spec file. You will not get the error.
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
--- Comment #7 from Pete Walter walter.pete@yandex.com --- Thanks, added appdata validation and the missing dconf-devel BuildRequires.
Spec URL: https://pwalter.fedorapeople.org/gnome-latex.spec SRPM URL: https://pwalter.fedorapeople.org/gnome-latex-3.32.0-2.fc31.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #8 from Robert-André Mauchin zebob.m@gmail.com --- (In reply to Phil Wyett from comment #6)
If you use my original or latest spec file. You will not get the error.
I know, sorry but I need the original reporter to update his SPEC. Maybe you can work together to co-maitain this package? It would be great.
- Only issue:
gnome-latex.src:53: W: mixed-use-of-spaces-and-tabs (spaces: line 53, tab: line 1)
You need to either use spaces or tabs, not both.
Package is approved. Please work with Kalev and Phil's PR to update TEPL to 4.2 Please fix the above issue before import.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "FSF All Permissive License", "GPL (v3 or later)", "Expat License", "GNU General Public License", "FSF Unlimited License (with Retention) GNU General Public License", "FSF Unlimited License (with Retention)", "GNU Lesser General Public License (v2.1 or later)", "GPL (v2 or later)". 1048 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gnome-latex/review-gnome- latex/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gtk-doc(vips- devel, iio-sensor-proxy-docs, garcon-devel, libxml2-devel, libcanberra-devel, gedit-devel, gtef-devel, libunity-gtk-parser-devel, gtk4-devel-docs, gtkspell3-devel, exo-devel, libgnome-devel, unique3-docs, gsequencer-devel-doc, gspell-doc, libnma-devel, gnome- online-accounts-devel, gnome-autoar-devel, libdbusmenu-doc, flatpak- devel, ibus-devel-docs, raptor2-devel, libmodulemd1-devel, anjuta- devel, clutter-gst3-devel, libgexiv2-devel, clipsmm-doc, libxfce4ui- devel, nautilus-devel, gtk-doc, xfconf-devel, gfbgraph-devel, uprof- devel, gsound-devel, vte291-devel, fprintd-devel, libzapojit-devel, bamf-devel, gstreamer1-vaapi-devel-docs, libfm-devel-docs, dbus-doc, gst-devtools-devel, harfbuzz-devel, libgdl-devel, rasqal-devel, template-glib-devel, parole-devel, xed-doc, libxmlb-devel, nautilus- python-devel, libpeas-devel, goocanvas2-devel, cutter-devel, gobject- introspection-devel, libxfce4util-devel, libgnome-keyring-devel, gnome-desktop3-devel, libdazzle-devel, unique-devel, libldm-devel, gtk3-devel-docs, yelp-devel, geoclue2-devel, libgtop2-devel, gcr- devel, libchamplain-devel, libgxps-devel, glade3-libgladeui-devel, gtranslator, gegl04-devel-docs, gtkimageview-devel, gimp-devel, cheese-libs-devel, gocl-devel, jsonrpc-glib-devel, libgweather-devel, buildstream-docs, libgit2-glib-devel, upower-devel-docs, intel-gpu- tools, dconf-devel, libgpod-doc, libu2f-host-devel, libsoup-devel, glade-devel, maliit-framework-docs, libgda-devel, p11-kit-devel, gtksourceview4-devel, lasem-devel, libmodulemd-devel, webkit2gtk3-doc, gnome-bluetooth-libs-devel, gom-devel, librsvg2-devel, libwnck3-devel, polkit-docs, libcryptui-devel, libcloudproviders-devel, libxklavier- devel, libhandy-devel, tracker-docs, gnome-todo-devel, gnome-calendar, anaconda-widgets-devel, json-glib-devel, geocode-glib-devel, gnome- desktop-devel, tumbler-devel, xreader-doc, libwnck-devel, udisks- devel, gmime30-devel, gtk2-devel-docs, gstreamer-plugins-base-devel- docs, poppler-glib-doc, ORBit2-devel, eog-devel, redland-devel, gstreamer1-rtsp-server-devel-docs, tomoe-devel, libidn2-devel, libsecret-devel, amtk-devel, latexila-doc, tepl-devel, libgdata- devel), /usr/share/gtk-doc/html(vips-devel, iio-sensor-proxy-docs, garcon-devel, libxml2-devel, libcanberra-devel, gedit-devel, gtef- devel, libunity-gtk-parser-devel, gtk4-devel-docs, gtkspell3-devel, exo-devel, libgnome-devel, unique3-docs, gsequencer-devel-doc, gspell- doc, libnma-devel, gnome-online-accounts-devel, gnome-autoar-devel, libdbusmenu-doc, flatpak-devel, ibus-devel-docs, raptor2-devel, libmodulemd1-devel, anjuta-devel, clutter-gst3-devel, libgexiv2-devel, clipsmm-doc, libxfce4ui-devel, nautilus-devel, xfconf-devel, gfbgraph- devel, uprof-devel, gsound-devel, vte291-devel, fprintd-devel, libzapojit-devel, bamf-devel, gstreamer1-vaapi-devel-docs, libfm- devel-docs, dbus-doc, gst-devtools-devel, harfbuzz-devel, libgdl- devel, rasqal-devel, template-glib-devel, devhelp-devel, parole-devel, xed-doc, libxmlb-devel, nautilus-python-devel, libpeas-devel, goocanvas2-devel, cutter-devel, gobject-introspection-devel, libxfce4util-devel, libgnome-keyring-devel, gnome-desktop3-devel, libdazzle-devel, unique-devel, libldm-devel, gtk3-devel-docs, yelp- devel, geoclue2-devel, libgtop2-devel, gcr-devel, libchamplain-devel, libgxps-devel, glade3-libgladeui-devel, gtranslator, gegl04-devel- docs, gtkimageview-devel, gimp-devel, cheese-libs-devel, gocl-devel, jsonrpc-glib-devel, libgweather-devel, buildstream-docs, libgit2-glib- devel, upower-devel-docs, intel-gpu-tools, dconf-devel, libgpod-doc, libu2f-host-devel, libsoup-devel, glade-devel, maliit-framework-docs, libgda-devel, p11-kit-devel, gtksourceview4-devel, lasem-devel, libmodulemd-devel, webkit2gtk3-doc, gnome-bluetooth-libs-devel, gom- devel, librsvg2-devel, libwnck3-devel, polkit-docs, libcryptui-devel, libcloudproviders-devel, libxklavier-devel, libhandy-devel, tracker- docs, gnome-todo-devel, gnome-calendar, anaconda-widgets-devel, json- glib-devel, geocode-glib-devel, gnome-desktop-devel, tumbler-devel, xreader-doc, libwnck-devel, udisks-devel, gmime30-devel, gtk2-devel- docs, gstreamer-plugins-base-devel-docs, poppler-glib-doc, ORBit2-devel, eog-devel, redland-devel, gstreamer1-rtsp-server-devel- docs, tomoe-devel, libidn2-devel, libsecret-devel, amtk-devel, latexila-doc, tepl-devel, libgdata-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gnome- latex [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2150400 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: gnome-latex-3.32.0-2.fc31.x86_64.rpm gnome-latex-doc-3.32.0-2.fc31.noarch.rpm gnome-latex-debuginfo-3.32.0-2.fc31.x86_64.rpm gnome-latex-debugsource-3.32.0-2.fc31.x86_64.rpm gnome-latex-3.32.0-2.fc31.src.rpm gnome-latex.x86_64: W: spelling-error %description -l en_US toolbars -> toolbar, tool bars, tool-bars gnome-latex.x86_64: W: spelling-error %description -l en_US tex -> Tex, ex, text gnome-latex-doc.noarch: W: obsolete-not-provided latexila-doc gnome-latex.src: W: spelling-error %description -l en_US toolbars -> toolbar, tool bars, tool-bars gnome-latex.src: W: spelling-error %description -l en_US tex -> Tex, ex, text gnome-latex.src:53: W: mixed-use-of-spaces-and-tabs (spaces: line 53, tab: line 1) 5 packages and 0 specfiles checked; 0 errors, 6 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
--- Comment #9 from Phil Wyett philwyett@kathenas.org --- (In reply to Robert-André Mauchin from comment #8)
(In reply to Phil Wyett from comment #6)
If you use my original or latest spec file. You will not get the error.
I know, sorry but I need the original reporter to update his SPEC. Maybe you can work together to co-maitain this package? It would be great.
Always happy to contribute.
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
--- Comment #10 from Pete Walter walter.pete@yandex.com --- Thanks guys for the review! I've requested the repo now.
Help is always welcome! Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
--- Comment #11 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-latex
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
Pete Walter walter.pete@yandex.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |gnome-latex-3.32.0-2.fc31 Resolution|--- |RAWHIDE Last Closed| |2019-03-16 10:14:17
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- tepl-4.2.0-1.fc30 gnome-latex-3.32.0-2.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8aeaddc281
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- gnome-latex-3.32.0-2.fc30, tepl-4.2.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8aeaddc281
https://bugzilla.redhat.com/show_bug.cgi?id=1688309
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- gnome-latex-3.32.0-2.fc30, tepl-4.2.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com