[Bug 2173500] New: Review Request: bqlmon - a ncurses interface to monitor the current number of bytes in-flight in the queue

https://bugzilla.redhat.com/show_bug.cgi?id=2173500

Bug ID: 2173500
           Summary: Review Request: bqlmon - a ncurses interface to
                    monitor the current number of bytes in-flight in the
                    queue
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://raw.githubusercontent.com/EdgeKing810/bqlmon/master/package-fedora/b...
SRPM URL:
https://github.com/EdgeKing810/bqlmon/raw/master/package-fedora/bqlmon-1.0-1...
Description: This program uses the Linux Byte Queue Limits support that some
Linux Ethernet drivers do support. Byte Queue Limits is refered to below as
BQL. The program provides a ncurses interface to monitor the current number of
bytes in-flight in the queue.
Fedora Account System Username:

[Bug 2173500] Review Request: bqlmon - a ncurses interface to monitor the current number of bytes in-flight in the queue

https://bugzilla.redhat.com/show_bug.cgi?id=2173500

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Petr Pisar  ---
Where did you get the Source0 archive from? At that URL is just an HTML web
page. If you used a git tree snapshot, then please follow
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots
to set proper Version and
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_revision
to set Source0 value.

[Bug 2173500] Review Request: bqlmon - a ncurses interface to monitor the current number of bytes in-flight in the queue

https://bugzilla.redhat.com/show_bug.cgi?id=2173500

Artur Frenszek-Iwicki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Artur Frenszek-Iwicki  ---
> %global debug_package %{nil}

No-go. We require debuginfo to be present in Fedora. The distro's CFLAGS
include flags for generating debuginfo, so this should happen by default.
If Fedora's CFLAGS are not respected, you may need to patch the Makefile.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_debuginfo_packag...
> %description
> This program uses the Linux Byte Queue Limits support that some Linux Ethernet drivers do support.
> Byte Queue Limits is refered to below as BQL. The program provides a ncurses interface to monitor
> the current number of bytes in-flight in the queue.

The description text should be wrapped so that all lines fit within 80
characters.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_desc...

Also, please fix the Source0 issue that Petr mentioned.