https://bugzilla.redhat.com/show_bug.cgi?id=1700438
Bug ID: 1700438 Summary: Review Request: yq - a lightweight and portable command-line YAML processor Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: bndabbs@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-be.cloud.fedoraproject.org/results/bndabbs/rocknsm-devel_brad/e...
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/bndabbs/rocknsm-devel_brad/e...
Description: I am maintainer for an open source project called RockNSM (https://github.com/rocknsm/rock) and we currently rely on a Go application called yq (https://github.com/mikefarah/yq) to edit YAML files through a whiptail TUI. At the moment, we are packaging yq as an RPM ourselves, but I would love to bring it into EPEL to make it more available to everyone else. The author for yq already publishes packages for Ubuntu and Homebrew, so having an official package for Red Hat flavored systems would really round things out.
I understand that I will need a sponsor in order to become a maintainer for this package. You can see some of my contributions to RPM development, here: https://github.com/rocknsm/rpms.
Fedora Account System Username: bndabbs
https://bugzilla.redhat.com/show_bug.cgi?id=1700438
bndabbs@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1700438
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Not needed:
rm -rf %{buildroot}
- No, you don't have access to Internet in mock/koji, this will never work:
# Get go dependencies go get -u github.com/kardianos/govendor go install github.com/kardianos/govendor
Instead package the deps first then BR them:
BuildRequires: golang(import path)
- You should use the Go macros loosely defined in https://fedoraproject.org/wiki/More_Go_packaging Note that we are in the process of rewriting them for F31 (https://eclipseo.fedorapeople.org/guidelines/packaging-guidelines/Golang/ )
# Generated by go2rpm %bcond_without check
# https://github.com/mikefarah/yq %global goipath github.com/mikefarah/yq Version: 2.3.0
%gometa
%global common_description %{expand: Yq is a portable command-line yaml processor.}
Name: yq Release: 1%{?dist} Summary: Portable command-line yaml processor
License: MIT URL: %{gourl} Source0: %{gosource}
BuildRequires: golang(github.com/pkg/errors) BuildRequires: golang(gopkg.in/imdario/mergo.v0) BuildRequires: golang(gopkg.in/mikefarah/yaml.v2) BuildRequires: golang(gopkg.in/op/go-logging.v1) BuildRequires: golang(gopkg.in/spf13/cobra.v0)
%description %{common_description}
%package devel Summary: %{summary} BuildArch: noarch
%description devel %{common_description}
This package contains library source intended for building other packages which use import path with %{goipath} prefix.
%prep %forgeautosetup -p1
%build %gobuildroot %gobuild -o _bin/yq %{goipath}
%install %goinstall install -m 0755 -vd %{buildroot}%{_bindir} install -m 0755 -vp _bin/* %{buildroot}%{_bindir}/
%if %{with check} %check %gochecks %endif
%files %license LICENSE %doc docs examples README.md %{_bindir}/*
%changelog * Mon Mar 25 2019 Bradford Dabbs brad@perched.io - 2.3.0-1 - Initial package
https://bugzilla.redhat.com/show_bug.cgi?id=1700438
bndabbs@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed| |2019-06-17 13:30:04
https://bugzilla.redhat.com/show_bug.cgi?id=1700438
Dusty Mabe dustymabe@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dustymabe@redhat.com Flags| |needinfo?(bndabbs@gmail.com | |)
--- Comment #2 from Dusty Mabe dustymabe@redhat.com --- hey bndabbs you closed this. Do you still want it in fedora? I'd like to have it in Fedora too.
https://bugzilla.redhat.com/show_bug.cgi?id=1700438
bndabbs@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(bndabbs@gmail.com | |) |
--- Comment #3 from bndabbs@gmail.com --- (In reply to Dusty Mabe from comment #2)
hey bndabbs you closed this. Do you still want it in fedora? I'd like to have it in Fedora too.
It would be great to have it in Fedora. I just didn't have to time to be a maintainer for it due to some changes in my full-time role.
https://bugzilla.redhat.com/show_bug.cgi?id=1700438
--- Comment #4 from bndabbs@gmail.com --- (In reply to Dusty Mabe from comment #2)
hey bndabbs you closed this. Do you still want it in fedora? I'd like to have it in Fedora too.
It would be great to have it in Fedora. I just didn't have to time to be a maintainer for it due to some changes in my full-time role.
package-review@lists.fedoraproject.org