[Bug 225718] New: Merge Review: eel2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225718

Summary: Merge Review: eel2
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: eel2

http://cvs.fedora.redhat.com/viewcvs/devel/eel2/
Initial Owner: [e-mail]

[Bug 225718] Merge Review: eel2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: eel2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225718

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-04-14 12:26 EST -------
GOOD:
* Package name conforms to the Fedora Naming Guidelines
* Group and License tags properly in place
* Locales handled correctly
* All necessary BuildRequires listed.
* Package builds OK in Mock.
* Source matches upstream
md5sum: dd06a56773af79e4292e63c6bcca9449  eel-2.18.0.1.tar.bz2

NEEDSWORK:
* Source url not given in the spec
* eel2-devel should not own %{_libdir}/pkgconfig, the -devel %files section
should have /usr/lib/pkgconfig/eel-2.0.pc instead
* rpmlint warnings:
$ rpmlint eel2-2.18.0.1-3.fc7.src.rpm
W: eel2 mixed-use-of-spaces-and-tabs (spaces: line 17, tab: line 16)
$ rpmlint eel2-2.18.0.1-3.fc7.x86_64.rpm
W: eel2 spurious-executable-perm /usr/share/doc/eel2-2.18.0.1/COPYING
$ rpmlint eel2-devel-2.18.0.1-3.fc7.x86_64.rpm
W: eel2-devel no-documentation   (can be ignored!)

Minor nit:
$RPM_OPT_FLAGS already includes a '-g' option

[Bug 225718] Merge Review: eel2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: eel2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225718

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium

------- Additional Comments From [e-mail]  2007-04-23 08:41 EST -------
Fixed in -5

[Bug 225718] Merge Review: eel2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: eel2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225718

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-05-07 00:54 EST -------
I'm sorry I almost forgot about this.

All issues in comment #1 are now fixed; rpmlint is now silent on the srpm and
the binaries (except for the ignorable one), and all packaged files are properly
owned.

APPROVED

[Bug 225718] Merge Review: eel2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: eel2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225718

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |CURRENTRELEASE

------- Additional Comments From [e-mail]  2007-08-10 21:37 EST -------
Review done.