[Bug 2293043] New: Review Request: python-crick - High performance approximate and streaming algorithms

https://bugzilla.redhat.com/show_bug.cgi?id=2293043

Bug ID: 2293043
           Summary: Review Request: python-crick - High performance
                    approximate and streaming algorithms
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://gui1ty.fedorapeople.org/review/python-crick.spec
SRPM URL:
https://gui1ty.fedorapeople.org/review/python-crick-0.0.6-1.fc41.src.rpm

Description:

Crick is a fast library of approximate and streaming algorithms. It is
still a work in progress, use at your own risk.

Fedora Account System Username: gui1ty

`crick` a missing dependency for `dask-expr`.

[Bug 2293043] Review Request: python-crick - High performance approximate and streaming algorithms

https://bugzilla.redhat.com/show_bug.cgi?id=2293043

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7627108
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- python3-crick : /usr/lib64/python3.13/site-packages/crick/common.h
python3-crick : /usr/lib64/python3.13/site-packages/crick/klib/khash.h 
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2293043] Review Request: python-crick - High performance approximate and streaming algorithms

https://bugzilla.redhat.com/show_bug.cgi?id=2293043

Sandro  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value

--- Comment #2 from Sandro  ---
Updated spec file excluding source and test files.

Spec URL: https://gui1ty.fedorapeople.org/review/python-crick.spec
SRPM URL:
https://gui1ty.fedorapeople.org/review/python-crick-0.0.6-2.fc41.src.rpm

[Bug 2293043] Review Request: python-crick - High performance approximate and streaming algorithms

https://bugzilla.redhat.com/show_bug.cgi?id=2293043

--- Comment #3 from Fedora Review Service  ---
Created attachment 2038400
  --> https://bugzilla.redhat.com/attachment.cgi?id=2038400&action=edit
The .spec file difference from Copr build 7627108 to 7678031

[Bug 2293043] Review Request: python-crick - High performance approximate and streaming algorithms

https://bugzilla.redhat.com/show_bug.cgi?id=2293043

--- Comment #4 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7678031
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2293043] Review Request: python-crick - High performance approximate and streaming algorithms

https://bugzilla.redhat.com/show_bug.cgi?id=2293043

Adam Williamson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]
              Flags|                            |fedora-review+

--- Comment #5 from Adam Williamson  ---
The header file issue is being referred to upstream at
https://github.com/dask/crick/pull/52 . Aside from that, this looks good to me,
passes all review requirements. Approved.

[Bug 2293043] Review Request: python-crick - High performance approximate and streaming algorithms

https://bugzilla.redhat.com/show_bug.cgi?id=2293043

Sandro  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #6 from Sandro  ---
Thanks for the review.

[Bug 2293043] Review Request: python-crick - High performance approximate and streaming algorithms

https://bugzilla.redhat.com/show_bug.cgi?id=2293043

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #7 from Fedora Update System  ---
FEDORA-2024-a3e2d4e31d (python-crick-0.0.6-1.fc41 and
python-dask-expr-1.1.6-4.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a3e2d4e31d

[Bug 2293043] Review Request: python-crick - High performance approximate and streaming algorithms

https://bugzilla.redhat.com/show_bug.cgi?id=2293043

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2024-06-28 06:38:32

--- Comment #8 from Fedora Update System  ---
FEDORA-2024-a3e2d4e31d (python-crick-0.0.6-1.fc41 and
python-dask-expr-1.1.6-4.fc41) has been pushed to the Fedora 41 stable
repository.
If problem still persists, please make note of it in this bug report.