[Bug 430441] New: Review Request: xautolock - Launches a program when your X session has been idle for some time - package-review

List overview All Threads
Download

newer

[Bug 430441] New: Review Request: xautolock - Launches a program when your X session has been idle for some time

older

[Bug 431290] New: Review Request:...

[Bug 417711] New: Review Request:...

Red Hat Bugzilla

27 Jan 2008 27 Jan '08

10:42 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=430441

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: ianweller@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://ianweller.org/rpm/xautolock/xautolock.spec SRPM URL: http://ianweller.org/rpm/xautolock/xautolock-2.2-1.fc8.src.rpm Description: A program that launches a given program when your X session has been idle for a given time.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

27 Jan 27 Jan

10:44 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle for some time

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time

https://bugzilla.redhat.com/show_bug.cgi?id=430441

ianweller@gmail.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1 Feb 1 Feb

6:29 a.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle for some time

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time

https://bugzilla.redhat.com/show_bug.cgi?id=430441

------- Additional Comments From rajeeshknambiar@gmail.com 2008-02-01 06:29 EST ------- Hi Ian, I cannot sponsor you, but I can unofficially review your package. rpm was build successfully from srpm and rpmlint didn't complain anything. Your spec file also look fine for me, except the point that you are putting the man file in directory "%{_mandir}/manl" (read man-el), not "man1" (read man-one). Is that intended, or a typo?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:46 a.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle for some time

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time

https://bugzilla.redhat.com/show_bug.cgi?id=430441

------- Additional Comments From ianweller@gmail.com 2008-02-01 10:46 EST ------- i looked at the xautolock man page and it was XAUTOLOCK(l), as in el. so i'm presuming this is correct, and it is intentionally done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

9:08 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle for some time

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time

https://bugzilla.redhat.com/show_bug.cgi?id=430441

mtasaka@ioa.s.u-tokyo.ac.jp changed:

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-01 21:08 EST ------- Removing NEEDSPONSOR (bug 417711)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

9:54 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle for some time

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time

https://bugzilla.redhat.com/show_bug.cgi?id=430441

ianweller@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From ianweller@gmail.com 2008-02-01 21:54 EST ------- New Package CVS Request ======================= Package Name: flam3 Short Description: Launches a program when your X session has been idle for some time Owners: ianweller Branches: F-7 F-8 InitialCC: ianweller Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

9:55 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle for some time

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time

https://bugzilla.redhat.com/show_bug.cgi?id=430441

------- Additional Comments From ianweller@gmail.com 2008-02-01 21:55 EST ------- Crud, I messed up the CVS request. Package Name should read `xautolock'.

Here's a new one. New Package CVS Request ======================= Package Name: xautolock Short Description: Launches a program when your X session has been idle for some time Owners: ianweller Branches: F-7 F-8 InitialCC: ianweller Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:09 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle for some time

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time

https://bugzilla.redhat.com/show_bug.cgi?id=430441

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-01 22:09 EST ------- Ah... no, even if you are sponsored, this request must be reviewed by someone. The difference is that as you are sponsored, this review request can be reviewed by non-sponsor members.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:57 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle for some time

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time

https://bugzilla.redhat.com/show_bug.cgi?id=430441

------- Additional Comments From ianweller@gmail.com 2008-02-01 23:57 EST ------- OK.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2 Feb 2 Feb

5:16 a.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle for some time

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time

https://bugzilla.redhat.com/show_bug.cgi?id=430441

pertusus@free.fr changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@free.fr

------- Additional Comments From pertusus@free.fr 2008-02-02 05:15 EST ------- gzip xautolock.man should not be done in the spec, it is done automatically by rpmbuild. Also the permission for man page should be 0644.

Man pages are automatically considered %doc.

I personally prefer to use globs like %{_mandir}/manl/xautolock.l* to catch all possibility of compression and no compression.

The l for man page is a bit strange. Currently on my box all the pages in manl are owned by lapack and blas (and the directory itself is not owned). So it is likely that it is an upstream mistake. It is not an issue for the review, but may be worth asking upstream if there is a typo in the man page.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

5:31 a.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle for some time

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time

https://bugzilla.redhat.com/show_bug.cgi?id=430441

pertusus@free.fr changed:

------- Additional Comments From pertusus@free.fr 2008-02-02 05:31 EST ------- To install the man page, there is a make target, install.man, and it installs in man1, so it is certainly a typo. I tested that the following works: make install install.man DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

Also for the build, the build flags are not the right ones. I found that the following works: make %{?_smp_mflags} CDEBUGFLAGS="$RPM_OPT_FLAGS" CC=%{__cc}

The summary is a bit too long in my opinion, but it is not a blocker.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:06 a.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle for some time

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle for some time

https://bugzilla.redhat.com/show_bug.cgi?id=430441

tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:45 a.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

ianweller@gmail.com changed:

------- Additional Comments From ianweller@gmail.com 2008-02-02 11:45 EST ------- * Sat Feb 02 2007 Ian Weller ianweller@gmail.com 2.2-2 - Shortened summary - Fixed make flags - Fixed installation of man page

Spec: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-2/xautolock.spec SRPM: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-2/xautolock-2.2-2.fc8....

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3:54 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

------- Additional Comments From ianweller@gmail.com 2008-02-02 15:54 EST ------- koji build ok http://koji.fedoraproject.org/koji/taskinfo?taskID=391426

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

6:16 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

------- Additional Comments From pertusus@free.fr 2008-02-02 18:16 EST ------- Source archive timestamp ois not kept:

$ ls -l ./xautolock-2.2.tgz ../SOURCES/xautolock-2.2.tgz -rw-r--r-- 1 dumas dumas 35288 jan 27 23:18 ../SOURCES/xautolock-2.2.tgz -rw-rw-r-- 1 dumas dumas 35288 déc 31 23:36 ./xautolock-2.2.tgz

You can use wget -N or spectool -g on the spec file.

Also the install is now done twice, once in make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" and a second time in make install install.man DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" (when make is given 2 targets, it does both).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:05 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

------- Additional Comments From ianweller@gmail.com 2008-02-02 23:05 EST ------- whoops. i shoulda seen that...

* Sat Feb 02 2007 Ian Weller ianweller@gmail.com 2.2-3 - Fixed timestamp of Source0 - Removed redundant installation spec: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-3/xautolock.spec srpm: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-3/xautolock-2.2-3.fc8....

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3 Feb 3 Feb

5:34 a.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

------- Additional Comments From pertusus@free.fr 2008-02-03 05:34 EST ------- I get a 404 not found....

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1:29 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

terjeros@phys.ntnu.no changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@phys.ntnu.no

------- Additional Comments From terjeros@phys.ntnu.no 2008-02-03 13:29 EST ------- Is this correct: Group: Applications/Internet

I would changed %files lines to: %doc Changelog License Readme Todo %{_bindir}/%{name} %{_mandir}/man1/%{name}.1*

but that's me.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2:15 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

------- Additional Comments From ianweller@gmail.com 2008-02-03 14:15 EST ------- (In reply to comment #14)

...

I get a 404 not found....

fedorapeople.org was down for some reason today, i read it on the mailing list. should work now.

(In reply to comment #15)

...

Is this correct: Group: Applications/Internet

no. fixing.

* Sun Feb 03 2008 Ian Weller ianweller@gmail.com 2.2-4 - Fixed dates in changelog (2007 -> 2008) - Fixed grouping - Tightened up files list

spec: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-4/xautolock.spec srpm: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-4/xautolock-2.2-4.fc8....

koji builds: all passed dist-fc7: http://koji.fedoraproject.org/koji/taskinfo?taskID=393437 dist-f8: http://koji.fedoraproject.org/koji/taskinfo?taskID=393430 dist-f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=393442

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

5:51 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

pertusus@free.fr changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From pertusus@free.fr 2008-02-03 17:51 EST ------- * rpmlint is silent * free software * follow guidelines * match upstream: 9526347a202694ad235d731d9d3de91f xautolock-2.2.tgz * %files section right

APPROVED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

6:03 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

ianweller@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From ianweller@gmail.com 2008-02-03 18:03 EST ------- New Package CVS Request ======================= Package Name: xautolock Short Description: Launches a program when your X session has been idle Owners: ianweller Branches: F-7 F-8 InitialCC: ianweller Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4 Feb 4 Feb

2:32 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-02-04 14:32 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:52 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

ianweller@gmail.com changed:

------- Additional Comments From ianweller@gmail.com 2008-02-04 23:52 EST ------- thanks kevin.

srpms imported, koji build ok, added to bodhi == NEXTRELEASE ==

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7 Feb 7 Feb

6:19 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

ianweller@gmail.com changed:

------- Additional Comments From ianweller@gmail.com 2008-02-07 18:19 EST ------- pushed to Fedora 7 and 8 stable repos (i forgot to link the bug numbers)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

19 Mar 19 Mar

6:48 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

ianweller@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

------- Additional Comments From ianweller@gmail.com 2008-03-19 18:48 EST ------- Package Change Request ====================== Package Name: xautolock New Branches: EL-4 EL-5

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:45 p.m.

New subject: [Bug 430441] Review Request: xautolock - Launches a program when your X session has been idle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xautolock - Launches a program when your X session has been idle

https://bugzilla.redhat.com/show_bug.cgi?id=430441

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-03-19 22:45 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

5944

Age (days ago)

5996

Last active (days ago)

package-review@lists.fedoraproject.org

25 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla