https://bugzilla.redhat.com/show_bug.cgi?id=1651962
Bug ID: 1651962 Summary: Review Request: GoldenCheetah - Cycling Performance Software Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mgansser@online.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/GoldenCheetah.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/GoldenCheetah-4.0-0.1.2018112...
Description: Golden Cheetah is a program for cyclists: - download and import activities from most popular bike computers from CycleOps, SRM, Polar, Garmin and others; - analyze, track and review performance data and metrics; - train indoors with real-time monitoring supporting trainers from Racermate, Tacx and any ANT+ device; - Golden Cheetah is free software and distributed under the GPL.
Fedora Account System Username: martinkg
rpmlint -i -v GoldenCheetah.spec /home/martin/rpmbuild/SRPMS/GoldenCheetah-4.0-0.1.20181120gitaae6243.fc29.src.rpm /home/martin/rpmbuild/RPMS/x86_64/GoldenCheetah-4.0-0.1.20181120gitaae6243.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/noarch/GoldenCheetah-data-4.0-0.1.20181120gitaae6243.fc29.noarch.rpm /home/martin/rpmbuild/RPMS/noarch/GoldenCheetah-doc-4.0-0.1.20181120gitaae6243.fc29.noarch.rpm /home/martin/rpmbuild/RPMS/x86_64/GoldenCheetah-debugsource-4.0-0.1.20181120gitaae6243.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/GoldenCheetah-debuginfo-4.0-0.1.20181120gitaae6243.fc29.x86_64.rpm GoldenCheetah.spec: I: checking GoldenCheetah.spec: I: checking-url https://github.com/GoldenCheetah/GoldenCheetah/archive/aae62438d3d291180c6dc... (timeout 10 seconds) GoldenCheetah.src: I: checking GoldenCheetah.src: I: checking-url http://www.goldencheetah.org/ (timeout 10 seconds) GoldenCheetah.src: I: checking-url https://github.com/GoldenCheetah/GoldenCheetah/archive/aae62438d3d291180c6dc... (timeout 10 seconds) GoldenCheetah.x86_64: I: checking GoldenCheetah.x86_64: I: checking-url http://www.goldencheetah.org/ (timeout 10 seconds) GoldenCheetah.x86_64: W: no-manual-page-for-binary GoldenCheetah Each executable in standard binary directories should have a man page.
GoldenCheetah-data.noarch: I: checking GoldenCheetah-data.noarch: I: checking-url http://www.goldencheetah.org/ (timeout 10 seconds) GoldenCheetah-data.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
GoldenCheetah-doc.noarch: I: checking GoldenCheetah-doc.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml The value of this tag appears to be misspelled. Please double-check.
GoldenCheetah-doc.noarch: I: checking-url http://www.goldencheetah.org/ (timeout 10 seconds) GoldenCheetah-debugsource.x86_64: I: checking GoldenCheetah-debugsource.x86_64: I: checking-url http://www.goldencheetah.org/ (timeout 10 seconds) GoldenCheetah-debuginfo.x86_64: I: checking GoldenCheetah-debuginfo.x86_64: I: checking-url http://www.goldencheetah.org/ (timeout 10 seconds) 6 packages and 1 specfiles checked; 0 errors, 3 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1651962
--- Comment #1 from MartinKG mgansser@online.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/GoldenCheetah.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/GoldenCheetah-4.0-0.2.2018112...
%changelog * Thu Nov 22 2018 Martin Gansser martinkg@fedoraproject.org - 4.0-0.2.20181120gitaae6243 - Add %%{name}-qxt-sys.patch - Add %%{name}-qwt3d-sys.patch
https://bugzilla.redhat.com/show_bug.cgi?id=1651962
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- - Add comments explaining what the patches do
- There doesn't seem to be a version 4.0, the latest is 3.5 dev branch
- Shouln't it be %patch0 and %patch1 here
%if 0%{?fedora} >=29 %patch -P 1 -p1 %else %patch -P 0 -p1 %endif
- Not needed anymore:
%post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
%postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi
%posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
- You copy the translation in the main package with %files -f %{name}.lang but own the directories in the data subpackage, this is not logical.
- Why don't you use %find_lang???
find %{buildroot}%{_datadir}/%{name}/translations -name "*.qm" | sed 's:'%{buildroot}':: s:.*/([a-zA-Z]{2}).qm:%lang(\1) \0:' > %{name}.lang
https://bugzilla.redhat.com/show_bug.cgi?id=1651962
--- Comment #3 from MartinKG mgansser@online.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/GoldenCheetah.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/GoldenCheetah-3.5-0.3.2018112...
%changelog * Fri Nov 23 2018 Martin Gansser martinkg@fedoraproject.org - 3.5-0.3.20181120gitaae6243 - Add comments explaining what the patches do - Correct version to 3.5 dev branch - Remove obsolete scriptlets - use %%find_lang macro for translation files - Remove owned directories in the data subpackage
https://bugzilla.redhat.com/show_bug.cgi?id=1651962
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- - Add gcc-c++ as a BR
Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Cannot run licensecheck: Command 'licensecheck -r /var/lib/mock/f30-candidate-x86_64/root/builddir/build/BUILD /GoldenCheetah-aae62438d3d291180c6dca4a3c366371f0d4a0c5' returned non- zero exit status -15 [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in GoldenCheetah-data , GoldenCheetah-doc , GoldenCheetah-debuginfo , GoldenCheetah-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4986880 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: GoldenCheetah-3.5-0.3.20181120gitaae6243.fc30.x86_64.rpm GoldenCheetah-data-3.5-0.3.20181120gitaae6243.fc30.noarch.rpm GoldenCheetah-doc-3.5-0.3.20181120gitaae6243.fc30.noarch.rpm GoldenCheetah-debuginfo-3.5-0.3.20181120gitaae6243.fc30.x86_64.rpm GoldenCheetah-debugsource-3.5-0.3.20181120gitaae6243.fc30.x86_64.rpm GoldenCheetah-3.5-0.3.20181120gitaae6243.fc30.src.rpm GoldenCheetah.x86_64: W: no-manual-page-for-binary GoldenCheetah GoldenCheetah-data.noarch: W: no-documentation GoldenCheetah-doc.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml 6 packages and 0 specfiles checked; 0 errors, 3 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1651962
--- Comment #5 from MartinKG mgansser@online.de --- Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1651962
--- Comment #6 from MartinKG mgansser@online.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/GoldenCheetah.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/GoldenCheetah-3.5-0.4.2018112...
%changelog * Mon Nov 26 2018 Martin Gansser martinkg@fedoraproject.org - 3.5-0.4.20181120gitaae6243 - Add %%{name}-lmfit-levmar.patch
* Fri Nov 23 2018 Martin Gansser martinkg@fedoraproject.org - 3.5-0.3.20181120gitaae6243 - Add BR gcc-c++ - Add comments explaining what the patches do - Correct version to 3.5 dev branch - Remove obsolete scriptlets - use %%find_lang macro for translation files - Remove owned directories in the data subpackage
https://bugzilla.redhat.com/show_bug.cgi?id=1651962
--- Comment #7 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/GoldenCheetah
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com