[Bug 2263055] New: Review Request: python-azure-monitor-query - Microsoft Azure Monitor Query Client Library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=2263055
Bug ID: 2263055 Summary: Review Request: python-azure-monitor-query - Microsoft Azure Monitor Query Client Library for Python Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: mhayden@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://mhayden.fedorapeople.org/python-azure-monitor-query.spec SRPM URL: https://mhayden.fedorapeople.org/python-azure-monitor-query-1.2.0-1.fc39.src...
Description: Microsoft Azure Monitor Query Client Library for Python.
Fedora Account System Username: mhayden
https://bugzilla.redhat.com/show_bug.cgi?id=2263055
Major Hayden 🤠 mhayden@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2263011
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2263011 [Bug 2263011] azure-cli-2.57.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2263055
--- Comment #1 from Major Hayden 🤠 mhayden@redhat.com --- I packaged 1.2.0 here because that's what azure-cli is currently pinned to in its 2.57.0 release. The 1.2.1 version of python-azure-monitor-query is available, but it does not meet azure-cli's criteria.
https://bugzilla.redhat.com/show_bug.cgi?id=2263055
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/Azure/az | |ure-sdk-for-python Keywords| |AutomationTriaged
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6994834 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2263055
Jeremy Cline jeremy@jcline.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |jeremy@jcline.org Status|NEW |ASSIGNED CC| |jeremy@jcline.org
https://bugzilla.redhat.com/show_bug.cgi?id=2263055
Jeremy Cline jeremy@jcline.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #3 from Jeremy Cline jeremy@jcline.org --- Very straightforward, approved. I _think_ I've set the correct review flag, but I'm a little rusty.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package does not own files or directories owned by other packages. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. (justified, so I think this is fine) [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-azure-monitor-query-1.2.0-1.fc40.noarch.rpm python-azure-monitor-query-1.2.0-1.fc40.src.rpm ======================================================= rpmlint session starts ====================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpxdvvyddc')] checks: 32, packages: 2
python3-azure-monitor-query.noarch: W: no-documentation python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/aio/__init__.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/__init__.py python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/operations/_patch.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/_patch.py:/usr/lib/python3.12/site-packages/azure/monitor/query/_generated/aio/_patch.py:/usr/lib/python3.12/site-packages/azure/monitor/query/_generated/aio/operations/_patch.py:/usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/_patch.py:/usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/aio/_patch.py:(and 2 more) python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/_serialization.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/_serialization.py python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/_vendor.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/_vendor.py python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/operations/__init__.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/aio/operations/__init__.py python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/aio/__init__.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/__init__.py python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/operations/__init__.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/aio/operations/__init__.py ================= 2 packages and 0 specfiles checked; 0 errors, 8 warnings, 10 filtered, 0 badness; has taken 0.3 s =================
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
python3-azure-monitor-query.noarch: W: no-documentation python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/aio/__init__.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/__init__.py python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/operations/_patch.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/_patch.py:/usr/lib/python3.12/site-packages/azure/monitor/query/_generated/aio/_patch.py:/usr/lib/python3.12/site-packages/azure/monitor/query/_generated/aio/operations/_patch.py:/usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/_patch.py:/usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/aio/_patch.py:(and 2 more) python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/_serialization.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/_serialization.py python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/_vendor.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/_vendor.py python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/operations/__init__.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/aio/operations/__init__.py python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/aio/__init__.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/__init__.py python3-azure-monitor-query.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/operations/__init__.py /usr/lib/python3.12/site-packages/azure/monitor/query/_generated/metrics/aio/operations/__init__.py 1 packages and 0 specfiles checked; 0 errors, 8 warnings, 6 filtered, 0 badness; has taken 0.1 s
Source checksums ---------------- https://files.pythonhosted.org/packages/source/a/azure-monitor-query/azure-m... : CHECKSUM(SHA256) this package : 2c57432443f203069e64e500c7e958ca31650f641950515ffe65555ba134c371 CHECKSUM(SHA256) upstream package : 2c57432443f203069e64e500c7e958ca31650f641950515ffe65555ba134c371
Requires -------- python3-azure-monitor-query (rpmlib, GLIBC filtered): (python3.12dist(azure-core) < 2~~ with python3.12dist(azure-core) >= 1.24) python(abi) python3.12dist(isodate) python3.12dist(typing-extensions)
Provides -------- python3-azure-monitor-query: python-azure-monitor-query python3-azure-monitor-query python3.12-azure-monitor-query python3.12dist(azure-monitor-query) python3dist(azure-monitor-query)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2263055 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: fonts, SugarActivity, Haskell, Ocaml, Java, Perl, C/C++, R, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2263055
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-azure-monitor-query
https://bugzilla.redhat.com/show_bug.cgi?id=2263055
Major Hayden 🤠 mhayden@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2024-02-06 21:37:42
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com