[Bug 2139873] New: Review Request: python-netapp_ontap - Library for working with ONTAP's REST APIs simply in Python

https://bugzilla.redhat.com/show_bug.cgi?id=2139873

Bug ID: 2139873
           Summary: Review Request: python-netapp_ontap - Library for
                    working with ONTAP's REST APIs simply in Python
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-netapp_ontap.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-netapp_ontap-9.11....
Description:
The Python client library is a package you can use when writing scripts
to access the ONTAP REST API. It provides support for several underlying
services, including connection management, asynchronous request processing,
and exception handling.
By using the Python client library, you can quickly develop robust code
to support the automation of your ONTAP deployments.
Fedora Account System Username: ignatenkobrain

[Bug 2139873] Review Request: python-netapp_ontap - Library for working with ONTAP's REST APIs simply in Python

https://bugzilla.redhat.com/show_bug.cgi?id=2139873

Igor Raits  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Igor Raits  ---
New SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-netapp_ontap-9.11....

Added URL and %autorelease/%autochangelog stuff.

[Bug 2139873] Review Request: python-netapp_ontap - Library for working with ONTAP's REST APIs simply in Python

https://bugzilla.redhat.com/show_bug.cgi?id=2139873

--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
- license spec is wrong. We now use SDPX. There are seven BSD variants listed
on
  https://docs.fedoraproject.org/en-US/legal/allowed-licenses/.

Looks OK otherwise. I'll run it through fedora-review now.

[Bug 2139873] Review Request: python-netapp_ontap - Library for working with ONTAP's REST APIs simply in Python

https://bugzilla.redhat.com/show_bug.cgi?id=2139873

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
fedora-review complains:
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.html is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

But I think this is a false positive: the file is
/usr/share/doc/python-netapp_ontap-doc/docs/models/license.html
and it seems to contain documentation for class LicenseSchema.

--

The name should have a dash, not an underscore.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming
doesn't say this very clearly, but it says that the package name should use
the canonical name, and the canonical name is described as the project name
with
some canonicalization, and the project name is described as the name used on
pypi. And on pypi we have a dash: https://pypi.org/project/netapp-ontap/

--

OK, between the license and a potential name change, I'll wait for an update.

[Bug 2139873] Review Request: python-netapp_ontap - Library for working with ONTAP's REST APIs simply in Python

https://bugzilla.redhat.com/show_bug.cgi?id=2139873

Tomas Orsava  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Tomas Orsava  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> The name should have a dash, not an underscore.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming
> doesn't say this very clearly, but it says that the package name should use
> the canonical name, and the canonical name is described as the project name
> with
> some canonicalization, and the project name is described as the name used on
> pypi. And on pypi we have a dash: https://pypi.org/project/netapp-ontap/

I agree that the name change is required. From the old Python Fedora packaging
guidelines [0]:
> The canonical name is obtained by switching the standardized name to lower case and converting all runs of non-alphanumeric characters to single “-” characters. Example: “The $$$ Tree” becomes “the-tree”.

[0]
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_auto...

I agree that it's not well described in the new guidelines, I'll try to get
that fixed.

[Bug 2139873] Review Request: python-netapp-ontap - Library for working with ONTAP's REST APIs simply in Python

https://bugzilla.redhat.com/show_bug.cgi?id=2139873

Igor Raits  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |python-netapp_ontap -       |python-netapp-ontap -
                   |Library for working with    |Library for working with
                   |ONTAP's REST APIs simply in |ONTAP's REST APIs simply in
                   |Python                      |Python

[Bug 2139873] Review Request: python-netapp-ontap - Library for working with ONTAP's REST APIs simply in Python

https://bugzilla.redhat.com/show_bug.cgi?id=2139873

--- Comment #5 from Tomas Orsava  ---
(In reply to Tomas Orsava from comment #4)
> I agree that it's not well described in the new guidelines, I'll try to get
> that fixed.

https://pagure.io/packaging-committee/pull-request/1225

[Bug 2139873] Review Request: python-netapp-ontap - Library for working with ONTAP's REST APIs simply in Python

https://bugzilla.redhat.com/show_bug.cgi?id=2139873

--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
I see
https://ignatenkobrain.fedorapeople.org/for-review/python-netapp-ontap.spec,
but the license is unchanged.