[Bug 2160771] New: Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

Bug ID: 2160771
           Summary: Review Request: flatseal - Manage Flatpak permissions
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://yselkowitz.fedorapeople.org/flatseal.spec
SRPM URL:
https://yselkowitz.fedorapeople.org/SRPMS/flatseal-1.8.1-1.fc38.src.rpm
Description: Flatseal is a graphical utility to review and modify permissions
from your Flatpak applications.
Fedora Account System Username: yselkowitz

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5227730
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]

--- Comment #2 from Neal Gompa  ---
Taking this review.

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

Yaakov Selkowitz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #3 from Yaakov Selkowitz  ---
Are you still planning on taking this review?

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #4 from Neal Gompa  ---
Initial spec review:
> Source0:        %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz

This has tags, so use those instead:
"%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz"
> desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop
>
> appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml

These should go into %check for clarity.

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #5 from Yaakov Selkowitz  ---
(In reply to Neal Gompa from comment #4)
> Initial spec review:
> > Source0:        %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz
>
> This has tags, so use those instead:
> "%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz"

The packaging guidelines say otherwise, since git tags are not immutable:

https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_ta...
> > desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop
> >
> > appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml
>
> These should go into %check for clarity.

The guidelines allow either:

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_ins...

https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data...

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #6 from Neal Gompa  ---
(In reply to Yaakov Selkowitz from comment #5)
> (In reply to Neal Gompa from comment #4)
> > Initial spec review:
> > > Source0:        %{url}/archive/%{commit}/Flatseal-%{commit}.tar.gz
> >
> > This has tags, so use those instead:
> > "%{url}/archive/v%{version}/Flatseal-%{version}.tar.gz"
>
> The packaging guidelines say otherwise, since git tags are not immutable:
>
> https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
> #_git_tags

It definitely does not say that. It only mentions screwiness with how Bitbucket
works.
> > > desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop
> > >
> > > appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml
> >
> > These should go into %check for clarity.
>
> The guidelines allow either:
>
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_desktop_file_install_usage
>
> https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
> #_app_data_validate_usage

I guess, though checks like this should be in %check...

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #7 from Yaakov Selkowitz  ---
Spec URL: https://yselkowitz.fedorapeople.org/flatseal.spec
SRPM URL:
https://yselkowitz.fedorapeople.org/SRPMS/flatseal-1.8.1-1.fc38.src.rpm
Description: Flatseal is a graphical utility to review and modify permissions
from your Flatpak applications.
Fedora Account System Username: yselkowitz

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #8 from Jakub Kadlčík  ---
Created attachment 1939881
  --> https://bugzilla.redhat.com/attachment.cgi?id=1939881&action=edit
The .spec file difference from Copr build 5227730 to 5283032

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #9 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5283032
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST

--- Comment #10 from Neal Gompa  ---
Review notes:

* Package naming follows packaging guidelines
* Package builds and installs
* Package has no serious rpmlint issues
* Package licensing is handled correctly

PACKAGE APPROVED.

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #11 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/flatseal

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #12 from Fedora Update System  ---
FEDORA-2023-15905b1689 has been submitted as an update to Fedora 37.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-15905b1689

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #13 from Fedora Update System  ---
FEDORA-EPEL-2023-750a4a2151 has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-750a4a2151

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #14 from Fedora Update System  ---
FEDORA-2023-15905b1689 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-15905b1689 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-15905b1689

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #15 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/flatpaks/flatseal

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |MODIFIED

--- Comment #16 from Fedora Update System  ---
FEDORA-FLATPAK-2023-04f87ea1a5 has been submitted as an update to Fedora 37
Flatpaks.
https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-04f87ea1a5

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #17 from Fedora Update System  ---
FEDORA-EPEL-2023-750a4a2151 has been pushed to the Fedora EPEL 9 testing
repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-750a4a2151

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #18 from Fedora Update System  ---
FEDORA-FLATPAK-2023-04f87ea1a5 has been pushed to the Fedora 37 Flatpaks
testing repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-04f87ea1a5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|ON_QA                       |CLOSED
        Last Closed|                            |2023-01-31 01:56:58

--- Comment #19 from Fedora Update System  ---
FEDORA-2023-15905b1689 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #20 from Fedora Update System  ---
FEDORA-EPEL-2023-750a4a2151 has been pushed to the Fedora EPEL 9 stable
repository.
If problem still persists, please make note of it in this bug report.

[Bug 2160771] Review Request: flatseal - Manage Flatpak permissions

https://bugzilla.redhat.com/show_bug.cgi?id=2160771

--- Comment #21 from Fedora Update System  ---
FEDORA-FLATPAK-2023-04f87ea1a5 has been pushed to the Fedora 37 Flatpaks stable
repository.
If problem still persists, please make note of it in this bug report.