https://bugzilla.redhat.com/show_bug.cgi?id=1298622
Bug ID: 1298622 Summary: Review Request: rubygem-minitest5 - minitest provides a complete suite of testing facilities Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: greg.hellings@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Note: this is a request to create a new package just for the EPEL7 branch. Currently rubygem-minitest exists in base EL packages, meaning we cannot make version 5 available in EPEL or it would mask the core EL package which is on the 4.x series.
Spec URL: http://pkgs.fedoraproject.org/cgit/rpms/rubygem-minitest.git/tree/rubygem-mi... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1148/12541148/rubygem-minites... Description: minitest provides a complete suite of testing facilities supporting TDD, BDD, mocking, and benchmarking.
minitest/unit is a small and incredibly fast unit testing framework. It provides a rich set of assertions to make your tests clean and readable.
minitest/spec is a functionally complete spec engine. It hooks onto minitest/unit and seamlessly bridges test assertions over to spec expectations.
minitest/benchmark is an awesome way to assert the performance of your algorithms in a repeatable manner. Now you can assert that your newb co-worker doesn't replace your linear algorithm with an exponential one!
minitest/mock by Steven Baker, is a beautifully tiny mock (and stub) object framework.
minitest/pride shows pride in testing and adds coloring to your test output. I guess it is an example of how to write IO pipes too. :P minitest/unit is meant to have a clean implementation for language implementors that need a minimal set of methods to bootstrap a working test suite. For example, there is no magic involved for test-case discovery.
minitest doesn't reinvent anything that ruby already provides, like: classes, modules, inheritance, methods. This means you only have to learn ruby to use minitest and all of your regular OO practices like extract-method refactorings still apply.
Fedora Account System Username: greghellings
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
greg.hellings@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |rubygem-minitest5
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mtasaka@fedoraproject.org Flags| |fedora-review?
--- Comment #1 from Mamoru TASAKA mtasaka@fedoraproject.org --- Taking.
I would appreciate it if you would review my review request (bug 1279755)
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
--- Comment #2 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- mtasaka's scratch build of rubygem-minitest5-5.8.1-2.el7.src.rpm for epel7 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12684502
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Mamoru TASAKA mtasaka@fedoraproject.org --- As this is basically EPEL branch request for existing rubygem-minitest master, approving as it is.
------------------------------------------------- This package (rubygem-minitest5) is APPROVED by mtasaka -------------------------------------------------
Some suggestions: http://pkgs.fedoraproject.org/cgit/rpms/rubygem-minitest.git/commit/?id=409c...
- Consider to update to 5.8.4 - Rakefile is not needed as this is alike "Makefile" on autotools system. - We suggest removing test/ directory on runtime package:
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test... "Do not ship tests"
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rubygem-minitest5
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
--- Comment #5 from greg.hellings@gmail.com --- Thanks! I've implemented all three of your suggestions in the newest package.
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- rubygem-minitest5-5.8.4-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-e9edb7ff2c
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #7 from Vít Ondruch vondruch@redhat.com --- What is the point of having this package in Fedora at this moment? It is already 4th source of Minitest.
I would suggest to retire it in Fedora:
https://fedoraproject.org/wiki/EPEL/FAQ#Is_it_possible_to_get_a_package_only...
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- rubygem-minitest5-5.8.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-e9edb7ff2c
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- rubygem-minitest5-5.8.4-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1298622
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-02-14 19:56:57
package-review@lists.fedoraproject.org